[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238220#comment-17238220 ] Angela Schreiber commented on OAK-6756: --- [~cschneider], fyi i used your patch to refactor the custom loginmodule factory in _oak-exercise_. from what i saw there the conversion of the jaas specific configuration options should be different: - jaasRanking -> jaas_ranking - jaasControlFlag -> jaas_controlFlag - jaasRealmName -> jaas_realmName so, there might be other issues like that hidden that would need to be carefully tested in order not to introduce regressions upon refactoring to OSGi R6 annotations. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: Angela Schreiber >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810730#comment-16810730 ] Christian Schneider commented on OAK-6756: -- I also don`t have a good way to validate. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809872#comment-16809872 ] angela commented on OAK-6756: - [~ch...@die-schneider.net], if the patch is no longer valid, the issue still is IMO. so, i would suggest to leave it open and wait for someone to fix it... i was just reluctant to apply the patch without having extensive tests that verify we don't introduce any regressions. if you have an suggestion on how to do this, i would give it another try. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809867#comment-16809867 ] Christian Schneider commented on OAK-6756: -- Is the patch still valid? It was a long time :) > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809851#comment-16809851 ] angela commented on OAK-6756: - [~ch...@die-schneider.net], why should we? i just removed the fix version, because it won't make it into 1.12.0. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809832#comment-16809832 ] Christian Schneider commented on OAK-6756: -- Should we close this? > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[
https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699113#comment-16699113
]
Julian Sedding commented on OAK-6756:
-
[~anchela], I haven't got any further documentation that I am holding back. I
suppose it is important to understand that the diff output relates to XML files
being compared. For one annotated class, there can be two XML files: one for
Declarative Services (aka SCR) and onw for the MetaType. These files can be
found in the two compared JAR files, and it may be helpful to look at the diff
report and these XML files in order to get accustomed to the diff output.
In the diff output,
- the indentation is meant to mimic the XML structure;
- lines without leading '+' or '-' just indicate the location in the XML
hierarchy;
- lines with leading '+' or '-' are additions and removals respectively.
Modifications are shown as addition and removal.
Is this information helpful? If not, can you please indicate if there is
anything in particular that I could explain?
In the attached report, I would e.g. consider it problematic that the IDs of
MetaType properties change in {{ExternalLoginModuleFactory}}. That would likely
break existing configurations. It might also be problematic that
{{ExternalPrincipalConfiguration}} before the changes is registered as both
{{PrincipalConfiguration}} and {{SecurityConfiguration}}, whereas after the
changes it would only be registered as {{PrincipalConfiguration}}. These are
just two very obvious issues. I would aim at reducing the diff to be empty or
to just contain removals of "bind"/"unbind", which get replaced (due to new
defaults) to "field" with optional "field-option" (this change only indicates
that the injection mechanism was altered).
> Convert oak-auth-external to OSGi R6 annotations
>
>
> Key: OAK-6756
> URL: https://issues.apache.org/jira/browse/OAK-6756
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: auth-external
>Reporter: Robert Munteanu
>Assignee: angela
>Priority: Major
> Fix For: 1.10
>
> Attachments: cschneider-OAK-6756.osgi-diff.txt
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694958#comment-16694958 ] angela commented on OAK-6756: - [~jsedding], i am a bit lost with the report. i got your tool and ran it on a related (but less complex) convertion and still wasn't sure i properly interprete the generated report. do you have any additional information that was is written in the README that comes with the osgi-ds-metatype-diff code base? > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela >Priority: Major > Fix For: 1.10 > > Attachments: cschneider-OAK-6756.osgi-diff.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255463#comment-16255463 ] angela commented on OAK-6756: - [~ch...@die-schneider.net], cool... thanks a lot. I will take a look asap. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela > Fix For: 1.10 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255260#comment-16255260 ] Christian Schneider commented on OAK-6756: -- Hi [~anchela], I have now removed the unnecessary changes and also rebased to current master. It would be great if you could review the current state. The build passes but I am not sure how well it tests for this highly OSGi related change. Is there a good way how I can validate if my changes work in OSGi? If it makes sense I can add some OSGi tests but I would need some help in the scope of such tests. Christian > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela > Fix For: 1.10 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254947#comment-16254947 ] angela commented on OAK-6756: - [~ch...@die-schneider.net], your patch contains changes unrelated to this issue. May I kindly ask you to refactor your patch to only include the relevant pieces and ping me again? thanks. > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu >Assignee: angela > Fix For: 1.8, 1.7.12 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6756) Convert oak-auth-external to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226463#comment-16226463 ] Christian Schneider commented on OAK-6756: -- I would like to assign myself to this issue but do not haver the rights to do so. I just created a pull request: https://github.com/apache/jackrabbit-oak/pull/73 > Convert oak-auth-external to OSGi R6 annotations > > > Key: OAK-6756 > URL: https://issues.apache.org/jira/browse/OAK-6756 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: auth-external >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.11 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
