[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary rebuild

2018-03-07 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389250#comment-16389250
 ] 

Julian Reschke commented on OAK-7310:
-

Hm, shouldn't we do that for all subprojects?

> Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary 
> rebuild
> --
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Trivial
> Fix For: 1.9.0, 1.10
>
>
> The file is used as JavaDoc package overview documentation but doesn't not 
> contain any class or interface. By default the Java compiler does not create 
> a class file for it which confuses the maven compiler plugin. The the plugin 
> interprets the 'missing' class file as an indication to rebuild the module 
> even if there are no other changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-07 Thread Marcel Reutegger (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389227#comment-16389227
 ] 

Marcel Reutegger commented on OAK-7310:
---

bq. Maybe because the plugin detects the missing class file and thus thinks a 
rebuild is needed?

Yes, most likely. I added {{-Xpkginfo:always}} locally and now the compiler 
doesn't rebuild the module when there are no changes.

> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-06 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388025#comment-16388025
 ] 

Julian Reschke commented on OAK-7310:
-

Found: 
https://stackoverflow.com/questions/6770455/maven-compiling-package-info-java-to-package-info-class

> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-06 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388023#comment-16388023
 ] 

Julian Reschke commented on OAK-7310:
-

Interesting - why does it do that? Maybe because the plugin detects the missing 
class file and thus thinks a rebuild is needed?

> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-06 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388011#comment-16388011
 ] 

Julian Reschke commented on OAK-7310:
-

trunk: [r1825997|http://svn.apache.org/r1825997] 
[r1825991|http://svn.apache.org/r1825991]


> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-06 Thread Marcel Reutegger (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388004#comment-16388004
 ] 

Marcel Reutegger commented on OAK-7310:
---

OK, I wasn't aware it gets includes as JavaDoc package overview. The reason why 
I wanted to remove it is, the maven java compiler will always detect a change 
because of this file and re-compiles the entire module even if nothing changed.

> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-06 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387986#comment-16387986
 ] 

Julian Reschke commented on OAK-7310:
-

That one line comment gets into the package overview of the API docs, thus it 
was definitely supposed to be there.

> Empty package-info.java in o.a.j.o.plugins.document.rdb
> ---
>
> Key: OAK-7310
> URL: https://issues.apache.org/jira/browse/OAK-7310
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: rdbmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Trivial
>
> The file was created with OAK-1266 a long time ago, but doesn't contain 
> anything useful than a one line comment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)