[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-18 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887805#comment-16887805
 ] 

Julian Reschke commented on OAK-8482:
-

[~dulceanu] - can this issue be set to "resolved"?

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Fix For: 1.16.0
>
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-18 Thread Andrei Dulceanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887737#comment-16887737
 ] 

Andrei Dulceanu commented on OAK-8482:
--

Fixed in trunk at r1863256.

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-17 Thread Andrei Dulceanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887153#comment-16887153
 ] 

Andrei Dulceanu commented on OAK-8482:
--

[~frm], sure I'll commit it. Thanks for reviewing!

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-17 Thread Francesco Mari (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887151#comment-16887151
 ] 

Francesco Mari commented on OAK-8482:
-

[~ierandra], [~dulceanu], the patch looks good to me. [~dulceanu], will you 
take care of the commit?

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-17 Thread Andrei Dulceanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887148#comment-16887148
 ] 

Andrei Dulceanu commented on OAK-8482:
--

[~frm], thanks for reviewing! I followed your simplified approach in the new 
patch, but treated a bit differently the {{RepositoryNotReachableException}} in 
the {{FileStore}}, i.e. didn't wrap it in a {{SegmentNotFoundException}}, since 
this is not the case anyways. I also came up with two new tests for reading 
segments. Could you please take a look?

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-17 Thread Ieran Draghiciu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887131#comment-16887131
 ] 

Ieran Draghiciu commented on OAK-8482:
--

Thanks [~dulceanu] for the test. [~frm] what do you think? It's safe to commit?
I also tested manually by deleting segments from azure and the SNFE was 
generated. When we had the timeout from Azure a RepositoryNotReachableException 
was thrown. 

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure, segment-tar
>Reporter: Ieran Draghiciu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-8482-04.patch, 
> OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-16 Thread Francesco Mari (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885942#comment-16885942
 ] 

Francesco Mari commented on OAK-8482:
-

[~ierandra], I simplified the patch by avoiding unnecessary wrapping and 
unwrapping of the {{RepositoryNotReachableException}}. Please have a look 
together with [~dulceanu]. Is there a way to add at least a test to assert that 
this patch doesn't create any regression?

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Ieran Draghiciu
>Priority: Major
> Attachments: OAK-8482-03.patch, OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (OAK-8482) Remove false positives of SNFE on azure execution time out

2019-07-15 Thread Ieran Draghiciu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885063#comment-16885063
 ] 

Ieran Draghiciu commented on OAK-8482:
--

[~frm] could you please take a look on the solution from [~dulceanu]:  
[^OAK-SNFE-false-positives-02.diff] 

> Remove false positives of SNFE on azure execution time out
> --
>
> Key: OAK-8482
> URL: https://issues.apache.org/jira/browse/OAK-8482
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Ieran Draghiciu
>Priority: Major
> Attachments: OAK-SNFE-false-positives-02.diff
>
>
> When reading a Tar file goes in execution time out a SNFE is thrown and the 
> SNFE metric is't increased.
> We need to not increase the metric and add extra logging to SNFE.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)