[jira] [Commented] (OAK-1004) Missing exports and typo in oak-core pom.xml

2013-09-10 Thread angela (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762843#comment-13762843
 ] 

angela commented on OAK-1004:
-

if fixed the missing comma at revision 1521368.

why do you think the 2 packages need to be exported? IMO they should not... so, 
i would be interested
to know why this would be needed.

 Missing exports and typo in oak-core pom.xml
 

 Key: OAK-1004
 URL: https://issues.apache.org/jira/browse/OAK-1004
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Bertrand Delacretaz
Assignee: angela
Priority: Minor
 Attachments: oak-core.patch


 There's a missing comma in the Jaas-ModuleClass statement, and I think the 
 org.apache.jackrabbit.oak.security.authentication.user and token packages 
 need to be exported. Patch follows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (OAK-1004) Missing exports and typo in oak-core pom.xml

2013-09-10 Thread angela (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762906#comment-13762906
 ] 

angela commented on OAK-1004:
-

if i remember correctly, i discussed this with antonio some time ago and he 
asked felix which said it's not needed. therefore i reverted my commit that 
moved all the login modules to the spi space which is exported.

so, let's reduce this issue to the typo. if it turns out to be required, we can 
create a separate issue for that.

 Missing exports and typo in oak-core pom.xml
 

 Key: OAK-1004
 URL: https://issues.apache.org/jira/browse/OAK-1004
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Bertrand Delacretaz
Assignee: angela
Priority: Minor
 Attachments: oak-core.patch


 There's a missing comma in the Jaas-ModuleClass statement, and I think the 
 org.apache.jackrabbit.oak.security.authentication.user and token packages 
 need to be exported. Patch follows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira