[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565121#comment-15565121 ] Stefan Egli commented on OAK-4796: -- [~chetanm], [~mreutegg], [~mduerig], finished up those

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561548#comment-15561548 ] Stefan Egli commented on OAK-4796: -- split up this task into 2 sub-tasks, things will be thu

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554084#comment-15554084 ] Chetan Mehrotra commented on OAK-4796: -- What I meant was to have simpler logic for path

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551799#comment-15551799 ] Stefan Egli commented on OAK-4796: -- Many thanks for this thorough review, [~chetanm]! I'll

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550976#comment-15550976 ] Chetan Mehrotra commented on OAK-4796: -- bq. Thing now is that for external and overflow

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550962#comment-15550962 ] Chetan Mehrotra commented on OAK-4796: -- Overall approach look fine. Below is bit high l

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548765#comment-15548765 ] Stefan Egli commented on OAK-4796: -- bq. This is wrong. We need to either do prefiltering or

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532623#comment-15532623 ] Stefan Egli commented on OAK-4796: -- As discussed offline with Marcel, I'll work on a patch

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509391#comment-15509391 ] Marcel Reutegger commented on OAK-4796: --- I like the general approach of this patch and

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509153#comment-15509153 ] Stefan Egli commented on OAK-4796: -- thx for the reviews! I'd look at fixing those points. B

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508941#comment-15508941 ] Marcel Reutegger commented on OAK-4796: --- bq. shared mutable state and is passed around

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508923#comment-15508923 ] Michael Dürig commented on OAK-4796: I meant the former: running individual hooks in par

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508916#comment-15508916 ] Marcel Reutegger commented on OAK-4796: --- bq. not allow us to scale the commit hooks ou

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507925#comment-15507925 ] Michael Dürig commented on OAK-4796: In addition to Marcel's concerns I'm a bit worried

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506883#comment-15506883 ] Marcel Reutegger commented on OAK-4796: --- Regarding the patch, would it be possible to

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506572#comment-15506572 ] Stefan Egli commented on OAK-4796: -- [~chetanm], I see, your approach is completely differen

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503621#comment-15503621 ] Chetan Mehrotra commented on OAK-4796: -- What a coincidence was just looking at this iss