[jira] [Commented] (OAK-4834) Make the role configurable for the SegmentNodeStore

2016-10-28 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614812#comment-15614812
 ] 

Tomek Rękawek commented on OAK-4834:


Since we have the SegmentNodeStoreFactory supporting the role-setting, there's 
no need to provide the same feature in the SegmentNodeStoreService.

> Make the role configurable for the SegmentNodeStore
> ---
>
> Key: OAK-4834
> URL: https://issues.apache.org/jira/browse/OAK-4834
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar, segmentmk
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: 1.6
>
> Attachments: OAK-4834.patch
>
>
> Right now the SegmentNodeStoreService can be configured with the secondary 
> boolean property. It'll be then registered as NodeStoreProvider with 
> {{role=secondary}}.
> Maybe we can make it more flexible and allow to configure any role, using 
> {{nsProvider.role}} property?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4834) Make the role configurable for the SegmentNodeStore

2016-09-21 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509780#comment-15509780
 ] 

Tomek Rękawek commented on OAK-4834:


BTW, OAK-4655 uses the same convention (nsProvider.role) for the 
factory-generated segment node store providers.

> Make the role configurable for the SegmentNodeStore
> ---
>
> Key: OAK-4834
> URL: https://issues.apache.org/jira/browse/OAK-4834
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar, segmentmk
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: 1.6
>
> Attachments: OAK-4834.patch
>
>
> Right now the SegmentNodeStoreService can be configured with the secondary 
> boolean property. It'll be then registered as NodeStoreProvider with 
> {{role=secondary}}.
> Maybe we can make it more flexible and allow to configure any role, using 
> {{nsProvider.role}} property?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4834) Make the role configurable for the SegmentNodeStore

2016-09-21 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509617#comment-15509617
 ] 

Tomek Rękawek commented on OAK-4834:


I attached the patch that modifies the old SegmentNodeStoreService and also 
introduces the same change for the segment-tar's one.

[~chetanm], could you take a look?

> Make the role configurable for the SegmentNodeStore
> ---
>
> Key: OAK-4834
> URL: https://issues.apache.org/jira/browse/OAK-4834
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar, segmentmk
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: 1.6
>
> Attachments: OAK-4834.patch
>
>
> Right now the SegmentNodeStoreService can be configured with the secondary 
> boolean property. It'll be then registered as NodeStoreProvider with 
> {{role=secondary}}.
> Maybe we can make it more flexible and allow to configure any role, using 
> {{nsProvider.role}} property?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)