[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628948#comment-15628948
]
Stefan Egli commented on OAK-4916:
--
tests will follow in OAK-4908
> Add support for excluding commits to
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628927#comment-15628927
]
Stefan Egli commented on OAK-4916:
--
Committed a modified variant (mainly with separate Interfaces for the
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601543#comment-15601543
]
Stefan Egli commented on OAK-4916:
--
Ok, after another review and an offline discussion I believe this is an
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601297#comment-15601297
]
Marcel Reutegger commented on OAK-4916:
---
The main difference is, it doesn't introduce the filtering
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601282#comment-15601282
]
Stefan Egli commented on OAK-4916:
--
[~mreutegg], how do you see your patch compare to my [previous
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595549#comment-15595549
]
Marcel Reutegger commented on OAK-4916:
---
See [^FilteringObserver.patch] for a quick sketch of my idea.
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595433#comment-15595433
]
Marcel Reutegger commented on OAK-4916:
---
I would also prefer a compositional approach. I already find
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587958#comment-15587958
]
Stefan Egli commented on OAK-4916:
--
[~chetanm], sure, no problem. I'll also look at the benchmark one of
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587657#comment-15587657
]
Chetan Mehrotra commented on OAK-4916:
--
[~egli] I would like to review the patch closely but need some
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585445#comment-15585445
]
Stefan Egli commented on OAK-4916:
--
Assuming approach in [^OAK-4916.v2.patch] is fine I plan to commit this
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572294#comment-15572294
]
Stefan Egli commented on OAK-4916:
--
Note that the issue with switching a filter [mentioned
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568342#comment-15568342
]
Stefan Egli commented on OAK-4916:
--
One way to do this would be to make the {{BackgroundObserver}} a
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567975#comment-15567975
]
Michael Dürig commented on OAK-4916:
Without looking at the code very much, it seems we are overloading
[
https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567937#comment-15567937
]
Chetan Mehrotra commented on OAK-4916:
--
Somehow not very comfortable with {{NOOP_CHANGE}} based
14 matches
Mail list logo
