[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-03-20 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932288#comment-15932288 ] Julian Reschke commented on OAK-5704: - [~mreutegg] - right, thanks for the reminder. > VersionGC: reset

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-03-20 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932262#comment-15932262 ] Marcel Reutegger commented on OAK-5704: --- The modCount field is an implementation detail and e.g. the

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-03-17 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929728#comment-15929728 ] Julian Reschke commented on OAK-5704: - We currently reset the flag if the modification date did not

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-03-09 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902874#comment-15902874 ] Julian Reschke commented on OAK-5704: - trunk: [r1786130|http://svn.apache.org/r1786130]

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-24 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882474#comment-15882474 ] Julian Reschke commented on OAK-5704: - trunk: [r1784204|http://svn.apache.org/r1784204]

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881257#comment-15881257 ] Marcel Reutegger commented on OAK-5704: --- Applied to trunk: http://svn.apache.org/r1784204 >

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881105#comment-15881105 ] Julian Reschke commented on OAK-5704: - Oops. Please apply. > VersionGC: reset _deletedOnce for

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880417#comment-15880417 ] Julian Reschke commented on OAK-5704: - trunk: [r1784128|http://svn.apache.org/r1784128] > VersionGC:

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880394#comment-15880394 ] Julian Reschke commented on OAK-5704: - On second thought, I prefer to leave things as proposed. The

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880360#comment-15880360 ] Marcel Reutegger commented on OAK-5704: --- You are right, it doesn't really make sense to collect those

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880347#comment-15880347 ] Julian Reschke commented on OAK-5704: - While reviewing the patch, I noticed that there really isn't any

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880139#comment-15880139 ] Marcel Reutegger commented on OAK-5704: --- bq. should we worry about code duplication wrt to parsing

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-21 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875920#comment-15875920 ] Julian Reschke commented on OAK-5704: - bq. The patch adds the current document id to the info message

[jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected

2017-02-21 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875908#comment-15875908 ] Marcel Reutegger commented on OAK-5704: --- I like the idea of resetting the deletedOnce flag. A couple