[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435644#comment-16435644 ] Julian Reschke commented on OAK-7406: - trunk: [r1828981|http://svn.apache.org/r1828981] > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7406.diff, OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435507#comment-16435507 ] Julian Reschke commented on OAK-7406: - New patch that should cover all subprojects: https://issues.apache.org/jira/secure/attachment/12918749/OAK-7406.diff > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff, OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435277#comment-16435277 ] Robert Munteanu commented on OAK-7406: -- [~reschke] - that might be an issue with Maven plug-in inheritance of maybe a side effect of how the maven-bundle-plugin reads configurations. But I guess that we don't want automatic inheritance of an export definition - maybe not all modules use it, but rather a way of saying "when importing com.google.common.*, use this version range ". Which I don't know can work. IMO defining the import range centrally and then using the property in specific modules is OK. > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435274#comment-16435274 ] Julian Reschke commented on OAK-7406: - [~rombert] - yes, that works (see POC). What doesn't seem to work is putting the into the parent pom. > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435069#comment-16435069 ] Robert Munteanu commented on OAK-7406: -- [~reschke] - inheritance _should_ work. At least you should be able to define the property in the parent pom and then use it in the modules that need it. > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434984#comment-16434984 ] Julian Reschke commented on OAK-7406: - [~chetanm] - i tried to put it into oak-parent, but it doesn't seem to get inherited... > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434978#comment-16434978 ] Chetan Mehrotra commented on OAK-7406: -- Looks fine. Probably it would need to be applied on all subprojects where Guava library is being used. Or we can add it to oak-parent (in [bundle plugin config in pluginManagement|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-parent/pom.xml#L165]) itself given its required at minimum for oak-core > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7406) relax guava version range in Import-Package declarations
[ https://issues.apache.org/jira/browse/OAK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433928#comment-16433928 ] Julian Reschke commented on OAK-7406: - POC for oak-core: https://issues.apache.org/jira/secure/attachment/12918563/OAK-7406.diff This is inspired by the way jclouds is doing it. It seems to require that we apply this change to any subproject using Guava though. Is there a simpler way? cc [~mreutegg], [~chetanm], [~rombert] > relax guava version range in Import-Package declarations > > > Key: OAK-7406 > URL: https://issues.apache.org/jira/browse/OAK-7406 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Major > Attachments: OAK-7406.diff > > > We should relax the Guava version to the range that we test with, that is > 15.0 to 21 excl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
