Andrei Dulceanu created OAK-5590:
------------------------------------
Summary: The check command doesn't do any check when "deep" option
is not provided
Key: OAK-5590
URL: https://issues.apache.org/jira/browse/OAK-5590
Project: Jackrabbit Oak
Issue Type: Bug
Components: run, segment-tar
Reporter: Andrei Dulceanu
Assignee: Andrei Dulceanu
Fix For: 1.8, 1.6.1
When the {{check}} command is used without {{--deep}} option, there is no
check/traversal being done against the repository.
First relevant line in code is [1], where a check is supposed to happen, but
due to a mismatch between argument expected/argument provided, {{null}} is
always returned without checking anything. The method which should do the
actual check [2] expects a set of paths to be traversed, but this set is always
empty. Therefore, relevant code for running the check is never executed [3].
[1]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L120
[2]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L183
[3]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L194
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
