[jira] [Updated] (OAK-4940) Consider collecting grand-parent changes in ChangeSet
[
https://issues.apache.org/jira/browse/OAK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-4940:
-
Attachment: OAK-4940.patch
Attaching [^OAK-4940.patch] which implements the following:
* adds a {{allNodeTypes}} set to the ChangeSet
* fixes {{parentNodeType}} to include before *and* after node types should the
node type ever changed (imv this is more correct than just taking the after).
* adjusted test cases
[~chetanm], can you pls have a quick look if this looks fine for you? I've now
chosen two separate sets (parent and all) as that allows for slightly more
precise filtering (and the set should still be small, so no large overhead
expected) - but if we want to accept the filtering-hit we could also have only
one set there.
> Consider collecting grand-parent changes in ChangeSet
> -
>
> Key: OAK-4940
> URL: https://issues.apache.org/jira/browse/OAK-4940
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.5.12
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: 1.6, 1.5.14
>
> Attachments: OAK-4940.patch
>
>
> At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a
> Validator) during a commit, collects changed property names, as well as node
> name, node type and path of the parent (whereas _parent_ for a property
> change is its node, while for a node change is actually its parent).
> For improvements such as SLING-6163 it might be valuable to collect
> grand-parent changes (node name, node type and perhaps path) too. We could
> extend the ChangeSet with additional, explicit grand-parent sets (ie we
> should not mix them with the parent changes as that would lessen filtering
> rate)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4940) Consider collecting grand-parent changes in ChangeSet
[ https://issues.apache.org/jira/browse/OAK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Saar updated OAK-4940: Fix Version/s: 1.6 > Consider collecting grand-parent changes in ChangeSet > - > > Key: OAK-4940 > URL: https://issues.apache.org/jira/browse/OAK-4940 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Stefan Egli >Assignee: Stefan Egli > Fix For: 1.6, 1.5.14 > > > At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a > Validator) during a commit, collects changed property names, as well as node > name, node type and path of the parent (whereas _parent_ for a property > change is its node, while for a node change is actually its parent). > For improvements such as SLING-6163 it might be valuable to collect > grand-parent changes (node name, node type and perhaps path) too. We could > extend the ChangeSet with additional, explicit grand-parent sets (ie we > should not mix them with the parent changes as that would lessen filtering > rate) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4940) Consider collecting grand-parent changes in ChangeSet
[ https://issues.apache.org/jira/browse/OAK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Saar updated OAK-4940: Fix Version/s: (was: 1.6) 1.5.14 > Consider collecting grand-parent changes in ChangeSet > - > > Key: OAK-4940 > URL: https://issues.apache.org/jira/browse/OAK-4940 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Stefan Egli >Assignee: Stefan Egli > Fix For: 1.5.14 > > > At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a > Validator) during a commit, collects changed property names, as well as node > name, node type and path of the parent (whereas _parent_ for a property > change is its node, while for a node change is actually its parent). > For improvements such as SLING-6163 it might be valuable to collect > grand-parent changes (node name, node type and perhaps path) too. We could > extend the ChangeSet with additional, explicit grand-parent sets (ie we > should not mix them with the parent changes as that would lessen filtering > rate) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4940) Consider collecting grand-parent changes in ChangeSet
[ https://issues.apache.org/jira/browse/OAK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4940: - Description: At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a Validator) during a commit, collects changed property names, as well as node name, node type and path of the parent (whereas _parent_ for a property change is its node, while for a node change is actually its parent). For improvements such as SLING-6163 it might be valuable to collect grand-parent changes (node name, node type and perhaps path) too. We could extend the ChangeSet with additional, explicit grand-parent sets (ie we should not mix them with the parent changes as that would lessen filtering rate) was: At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a Validator) during a commit, collects changed property names, as well as node name, node type and path of the parent (whereas _parent_ for a property change is its node, while for a node change is actually its parent). For improvements such as SLING-6163 it might be valuable to collect grand-parent changes (node name, node type and perhaps path) too. > Consider collecting grand-parent changes in ChangeSet > - > > Key: OAK-4940 > URL: https://issues.apache.org/jira/browse/OAK-4940 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Stefan Egli > Fix For: 1.6 > > > At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a > Validator) during a commit, collects changed property names, as well as node > name, node type and path of the parent (whereas _parent_ for a property > change is its node, while for a node change is actually its parent). > For improvements such as SLING-6163 it might be valuable to collect > grand-parent changes (node name, node type and perhaps path) too. We could > extend the ChangeSet with additional, explicit grand-parent sets (ie we > should not mix them with the parent changes as that would lessen filtering > rate) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
