Re: [Ocfs2-devel] [PATCH] Wakeup down-convert thread just after clearing OCFS2_LOCK_UPCONVERT_FINISHING -v3

2011-09-15 Thread Sunil Mushran
I am fine with the kick in recover from dlm error. Not so in cluster lock. We have to be very very sure before meddling with that function. It is a state machine with many hidden gotchas. So is this patch for a bug encountered or just code audit. Also, what kind testing has been done. On

Re: [Ocfs2-devel] [PATCH] Wakeup down-convert thread just after clearing OCFS2_LOCK_UPCONVERT_FINISHING -v3

2011-09-15 Thread Sunil Mushran
http://people.redhat.com/~teigland/make_panic This test has been useful in exposing dlmglue issues. On 09/15/2011 10:15 AM, Sunil Mushran wrote: I am fine with the kick in recover from dlm error. Not so in cluster lock. We have to be very very sure before meddling with that function. It is a

Re: [Ocfs2-devel] [PATCH] Wakeup down-convert thread just after clearing OCFS2_LOCK_UPCONVERT_FINISHING -v3

2011-09-15 Thread Wengang Wang
Hi Sunil, On 11-09-15 10:21, Sunil Mushran wrote: http://people.redhat.com/~teigland/make_panic This test has been useful in exposing dlmglue issues. On 09/15/2011 10:15 AM, Sunil Mushran wrote: I am fine with the kick in recover from dlm error. Not so in cluster lock. We have to be very

Re: [Ocfs2-devel] [PATCH] Wakeup down-convert thread just after clearing OCFS2_LOCK_UPCONVERT_FINISHING -v3

2011-09-15 Thread Sunil Mushran
On 09/15/2011 05:42 PM, Wengang Wang wrote: Hi Sunil, On 11-09-15 10:21, Sunil Mushran wrote: http://people.redhat.com/~teigland/make_panic This test has been useful in exposing dlmglue issues. On 09/15/2011 10:15 AM, Sunil Mushran wrote: I am fine with the kick in recover from dlm error.

Re: [Ocfs2-devel] [PATCH] Wakeup down-convert thread just after clearing OCFS2_LOCK_UPCONVERT_FINISHING -v3

2011-09-15 Thread Wengang Wang
On 11-09-15 17:53, Sunil Mushran wrote: On 09/15/2011 05:42 PM, Wengang Wang wrote: Hi Sunil, On 11-09-15 10:21, Sunil Mushran wrote: http://people.redhat.com/~teigland/make_panic This test has been useful in exposing dlmglue issues. On 09/15/2011 10:15 AM, Sunil Mushran wrote: I am