Re: [Ocfs2-devel] [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor

2011-11-17 Thread Joel Becker
On Wed, Nov 02, 2011 at 10:05:16AM -0700, Sunil Mushran wrote: I think it got lost in the shuffle. We had decided to use the list_for_each(). The code is simpler to understand than the other proposed fix. Joel, do you want me to send a patch? Please do. On 11/02/2011 12:39 AM, Dan

Re: [Ocfs2-devel] [PATCH 3/4] net: add paged frag destructor support to kernel_sendpage.

2011-11-17 Thread Michał Mirosław
2011/11/9 Ian Campbell ian.campb...@citrix.com: This requires adding a new argument to various sendpage hooks up and down the stack. At the moment this parameter is always NULL. [...] --- a/include/linux/net.h +++ b/include/linux/net.h @@ -203,6 +204,7 @@ struct proto_ops {        ssize_t    

Re: [Ocfs2-devel] [PATCH] vfs: Correctly set the dir i_mutex lockdep class

2011-11-17 Thread Joel Becker
On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote: On 2011-11-10 15:33:19, Jan Kara wrote: On Thu 10-11-11 00:45:00, Tyler Hicks wrote: This patch removes the negation from the conditional so that the i_mutex lockdep class is properly set for directory inodes. Special classes

Re: [Ocfs2-devel] [PATCH] ocfs2: Commit transactions in error cases -v2

2011-11-17 Thread Joel Becker
On Wed, Oct 12, 2011 at 03:22:15PM +0800, Wengang Wang wrote: There are three cases found that in error cases, journal transactions are not committed nor aborted. We should take care of these case by committing the transactions. Otherwise, there would left a journal handle which will lead to ,

Re: [Ocfs2-devel] [PATCH] ocfs2: send correct UUID to cleancache initialization

2011-11-17 Thread Joel Becker
On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote: ocfs2: Fix cleancache initialization call to correctly pass uuid As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221 the ocfs2 volume UUID is incorrectly passed to cleancache. As a result, shared-ephemeral

Re: [Ocfs2-devel] [PATCH] ocfs2: Add a missing journal credit in ocfs2_link_credits() -v2

2011-11-17 Thread Joel Becker
On Wed, Oct 19, 2011 at 09:34:19AM +0800, xiaowei...@oracle.com wrote: From: Xiaowei.Hu xiaowei...@oracle.com With indexed_dir enabled, ocfs2 maintains a list of dirblocks having space. The credit calculation in ocfs2_link_credits() did not correctly account for adding an entry that

[Ocfs2-devel] [PATCH 2/6] ocfs2: Add missing copyright in few files

2011-11-17 Thread Sunil Mushran
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/mmap.h | 18 ++ fs/ocfs2/ocfs2_trace.h | 19 +++ fs/ocfs2/quota.h| 16 ++-- fs/ocfs2/quota_global.c | 20 ++-- fs/ocfs2/quota_local.c | 19

[Ocfs2-devel] [PATCH 4/6] ocfs2/dlm: Use track_lock when manipulating tracking_list

2011-11-17 Thread Sunil Mushran
Commit b0d4f817ba5de8adb875ace594554a96d7737710 introduced dlm-track_lock to protect operations on dlm-tracking_list. But it was still using the older lock (dlm-spin_lock) to add new resources to the list. Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/dlm/dlmmaster.c |4

[Ocfs2-devel] [PATCH 5/6] ocfs2/dlm: Fix list traversal in dlm_process_recovery_data

2011-11-17 Thread Sunil Mushran
This issue, detected via static analysis, was introduced by commit 800deef3 that replaced the existing list_for_each() with list_for_each_entry(). We have no record of it hitting users during runtime. This could be because this lock list is supposed to have only one lock that is owned by that node

[Ocfs2-devel] [PATCH 1/6] ocfs2/cluster: Fix possible null pointer dereference

2011-11-17 Thread Sunil Mushran
Patch fixes some possible null pointer dereferences that were detected by the static code analyser, smatch. Reported-by: Dan Carpenter erro...@gmail.com Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/cluster/tcp.c | 10 +- 1 files changed, 5 insertions(+), 5

[Ocfs2-devel] [PATCH 3/6] ocfs2: Silence message in ocfs2_global_read_info()

2011-11-17 Thread Sunil Mushran
Mainline commit c1e8d35ef5ffb393b94a192034b5e3541e005d75 removed mlog_exit() and replaced it with mlog_errno() in some cases. This change in ocfs2_global_read_info() caused it to spew the following during mount. [ 38.745584] (mount.ocfs2,3315,4):ocfs2_global_read_info:403 ERROR: status = 24

[Ocfs2-devel] [PATCH 6/6] ocfs2: Tighten free bit calculation in the global bitmap

2011-11-17 Thread Sunil Mushran
When clearing bits in the global bitmap, we do not test the current bit value. This patch tightens the code by considering the possiblity that the bit being cleared was already cleared. Now this should not happen. But we are seeing stray instances in which free bit count in the global bitmap

[Ocfs2-devel] [PATCH] ocfs2: Adding d_delete callback function ocfs2_dentry_delete

2011-11-17 Thread Wengang Wang
If d_count will become zero, dput() calls the .d_delete callback function, if it exist, to know if the corresponding file is deleted or to say if we should remove the in memory dentry. If we should remove the dentry, dput() calls dentry_kill to free the dentry(and the parents on last ref).