Re: [Ocfs2-devel] ocfs2-tools repository and documentation

2014-12-15 Thread Germano Percossi
Hi Goldwyn, Thanks for your answer. I will have a look at your code. I just want to be sure that the source code I am looking at is the latest one to avoid fixing things that maybe have been already fixed elsewhere. Same is true for documentation and package repositories. If I could have links

[Ocfs2-devel] ocfs patches for review

2014-12-15 Thread Andrew Morton
Another round of jolly patch reviewing, please. A number of these patches have been stalled for quite a long time. I have the following notes: o2dlm-fix-null-pointer-dereference-in-o2dlm_blocking_ast_wrapper.patch: - Joseph Qi had issues ocfs2-free-inode-when-i_count-becomes-zero.patch:

[Ocfs2-devel] [patch 06/15] ocfs2: reflink: fix slow unlink for refcounted file

2014-12-15 Thread akpm
From: Junxiao Bi junxiao...@oracle.com Subject: ocfs2: reflink: fix slow unlink for refcounted file When running ocfs2 test suite multiple nodes reflink stress test, for a 4 nodes cluster, every unlink() for refcounted file needs about 700s. The slow unlink is caused by the contention of

[Ocfs2-devel] [patch 01/15] o2dlm: fix NULL pointer dereference in o2dlm_blocking_ast_wrapper

2014-12-15 Thread akpm
From: Srinivas Eeda srinivas.e...@oracle.com Subject: o2dlm: fix NULL pointer dereference in o2dlm_blocking_ast_wrapper A tiny race between BAST and unlock message causes the NULL dereference. A node sends an unlock request to master and receives a response. Before processing the response it

[Ocfs2-devel] [patch 07/15] ocfs2: fix journal commit deadlock

2014-12-15 Thread akpm
From: Junxiao Bi junxiao...@oracle.com Subject: ocfs2: fix journal commit deadlock For buffer write, page lock will be got in write_begin and released in write_end, in ocfs2_write_end_nolock(), before it unlock the page in ocfs2_free_write_ctxt(), it calls ocfs2_run_deallocs(), this will ask for

[Ocfs2-devel] [patch 13/15] ocfs2: do not fallback to buffer I/O write if appending

2014-12-15 Thread akpm
From: Weiwei Wang wangww...@huawei.com Subject: ocfs2: do not fallback to buffer I/O write if appending Now we can do direct io and do not fallback to buffered IO any more in case of append O_DIRECT write. Signed-off-by: Weiwei Wang wangww...@huawei.com Signed-off-by: Joseph Qi

[Ocfs2-devel] [patch 10/15] ocfs2: add orphan recovery types in ocfs2_recover_orphans

2014-12-15 Thread akpm
From: Joseph Qi joseph...@huawei.com Subject: ocfs2: add orphan recovery types in ocfs2_recover_orphans Define two orphan recovery types, which indicates if need truncate file or not. Originally, only deleted inode will be add to orphan dir. We use orphan dir to temporary store the file in

[Ocfs2-devel] [patch 15/15] ocfs2: fix leftover orphan entry caused by append O_DIRECT write crash

2014-12-15 Thread akpm
From: Joseph Qi joseph...@huawei.com Subject: ocfs2: fix leftover orphan entry caused by append O_DIRECT write crash If one node has crashed with orphan entry leftover, another node which do append O_DIRECT write to the same file will override the i_dio_orphaned_slot. Then the old entry won't be

[Ocfs2-devel] [patch 02/15] ocfs2: free inode when i_count becomes zero

2014-12-15 Thread akpm
From: Xue jiufei xuejiu...@huawei.com Subject: ocfs2: free inode when i_count becomes zero Disk inode deletion may be heavily delayed when one node unlink a file after the same dentry is freed on another node(say N1) because of memory shrink but inode is left in memory. This inode can only be

[Ocfs2-devel] [patch 08/15] ocfs2: eliminate the static flag of some functions

2014-12-15 Thread akpm
From: Weiwei Wang wangww...@huawei.com Subject: ocfs2: eliminate the static flag of some functions Currently in case of append O_DIRECT write (block not allocated yet), ocfs2 will fall back to buffered I/O. This has some disadvantages. Firstly, it is not the behavior as expected. Secondly, it

[Ocfs2-devel] [patch 05/15] ocfs2/dlm: fix race between dispatched_work and dlm_lockres_grab_inflight_worker

2014-12-15 Thread akpm
From: Joseph Qi joseph...@huawei.com Subject: ocfs2/dlm: fix race between dispatched_work and dlm_lockres_grab_inflight_worker ac4fef4d23ed (ocfs2/dlm: do not purge lockres that is queued for assert master) may have the following possible race case: dlm_dispatch_assert_master dlm_wq

[Ocfs2-devel] [patch 03/15] ocfs2: call ocfs2_journal_access_di() before ocfs2_journal_dirty() in ocfs2_write_end_nolock()

2014-12-15 Thread akpm
From: yangwenfang vicky.yangwenf...@huawei.com Subject: ocfs2: call ocfs2_journal_access_di() before ocfs2_journal_dirty() in ocfs2_write_end_nolock() After we call ocfs2_journal_access_di() in ocfs2_write_begin(), jbd2_journal_restart() may also be called, in this function transaction A's

[Ocfs2-devel] [patch 11/15] ocfs2: implement ocfs2_direct_IO_write

2014-12-15 Thread akpm
From: Weiwei Wang wangww...@huawei.com Subject: ocfs2: implement ocfs2_direct_IO_write Implement ocfs2_direct_IO_write. Add the inode to orphan dir first, and then delete it once append O_DIRECT finished. This is to make sure block allocation and inode size are consistent.

[Ocfs2-devel] [patch 12/15] ocfs2: allocate blocks in ocfs2_direct_IO_get_blocks

2014-12-15 Thread akpm
From: Weiwei Wang wangww...@huawei.com Subject: ocfs2: allocate blocks in ocfs2_direct_IO_get_blocks Allow blocks allocation in ocfs2_direct_IO_get_blocks. Signed-off-by: Weiwei Wang wangww...@huawei.com Signed-off-by: Joseph Qi joseph...@huawei.com Cc: Joel Becker jl...@evilplan.org Cc: Mark

[Ocfs2-devel] [patch 14/15] ocfs2: do not fallback to buffer I/O write if fill holes

2014-12-15 Thread akpm
From: Weiwei Wang wangww...@huawei.com Subject: ocfs2: do not fallback to buffer I/O write if fill holes Now append O_DIRECT write to a hole will try direct io first, then fallback to buffered IO if fails. Signed-off-by: Weiwei Wang wangww...@huawei.com Signed-off-by: Joseph Qi

Re: [Ocfs2-devel] [patch 02/15] ocfs2: free inode when i_count becomes zero

2014-12-15 Thread Xue jiufei
Hi, Andrew, This patch may lead to data loss so please remove it from mm tree please. Here is the situation: When i_count becomes zero but there still exists dirty pages in i_mapping, the dirty pages would be freed without flushing the data. To avoid this problem, we should flush dirty page

Re: [Ocfs2-devel] ocfs2-tools repository and documentation

2014-12-15 Thread Srinivas Eeda
Hi Goldwyn, Germano I have updated ocfs2-tools git repo with latest fixes :) Germano, following documentation is available for OCFS2 http://docs.oracle.com/cd/E37670_01/E37355/html/ol_ocfs2.html http://www.oracle.com/us/technologies/linux/025995.htm