Re: [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit

2014-12-03 Thread Xue jiufei
Hi Goldwyn, On 2014/11/4 23:52, Goldwyn Rodrigues wrote: Filesize is not a good indication that the file needs to be synced. An example where this breaks is: 1. Open the file in O_SYNC|O_RDWR 2. Read a small portion of the file (say 64 bytes) 3. Lseek to starting of the file 4. Write 64

Re: [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit

2014-11-05 Thread Goldwyn Rodrigues
On 11/04/2014 04:45 PM, Andrew Morton wrote: On Tue, 4 Nov 2014 09:52:22 -0600 Goldwyn Rodrigues rgold...@suse.de wrote: Filesize is not a good indication that the file needs to be synced. An example where this breaks is: 1. Open the file in O_SYNC|O_RDWR 2. Read a small portion of the

Re: [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit

2014-11-05 Thread Mark Fasheh
On Tue, Nov 04, 2014 at 09:52:22AM -0600, Goldwyn Rodrigues wrote: Filesize is not a good indication that the file needs to be synced. An example where this breaks is: 1. Open the file in O_SYNC|O_RDWR 2. Read a small portion of the file (say 64 bytes) 3. Lseek to starting of the file 4.

[Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit

2014-11-04 Thread Goldwyn Rodrigues
Filesize is not a good indication that the file needs to be synced. An example where this breaks is: 1. Open the file in O_SYNC|O_RDWR 2. Read a small portion of the file (say 64 bytes) 3. Lseek to starting of the file 4. Write 64 bytes If the node crashes, it is not written out to disk

Re: [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit

2014-11-04 Thread Andrew Morton
On Tue, 4 Nov 2014 09:52:22 -0600 Goldwyn Rodrigues rgold...@suse.de wrote: Filesize is not a good indication that the file needs to be synced. An example where this breaks is: 1. Open the file in O_SYNC|O_RDWR 2. Read a small portion of the file (say 64 bytes) 3. Lseek to starting of the