Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

On 01/21/2016 04:10 PM, Eric Ren wrote: > Hi Junxiao, > > On Thu, Jan 21, 2016 at 03:10:20PM +0800, Junxiao Bi wrote: >> Hi Eric, >> >> This patch should fix your issue. >> "NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock" > > Thanks a lot for bringing up this patch! It

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

Hi Junxiao, On Thu, Jan 21, 2016 at 03:10:20PM +0800, Junxiao Bi wrote: > Hi Eric, > > This patch should fix your issue. > "NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock" Thanks a lot for bringing up this patch! It hasn't been merged into mainline( at least 4.4), right?

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

On Thu, 21 Jan 2016 16:18:38 +0800 Junxiao Bi wrote: > On 01/21/2016 04:10 PM, Eric Ren wrote: > > Hi Junxiao, > > > > On Thu, Jan 21, 2016 at 03:10:20PM +0800, Junxiao Bi wrote: > >> Hi Eric, > >> > >> This patch should fix your issue. > >> "NFS hangs in

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

Hi all, On Thu, Jan 21, 2016 at 03:05:58PM -0800, Andrew Morton wrote: > On Thu, 21 Jan 2016 16:18:38 +0800 Junxiao Bi wrote: > > > On 01/21/2016 04:10 PM, Eric Ren wrote: > > > Hi Junxiao, > > > > > > On Thu, Jan 21, 2016 at 03:10:20PM +0800, Junxiao Bi wrote: > > >>

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

Hi Eric, This patch should fix your issue. "NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock" Thanks, Junxiao. On 01/20/2016 12:46 AM, Eric Ren wrote: > This problem was introduced by commit > a19128260107f951d1b4c421cf98b92f8092b069. > OCFS2_LOCK_UPCONVERT_FINISHING is set

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

Hi, This fix is wrong, becuase it can ensure waking up every waiter, but cannot guarantee every waiter finish trying its "again" patch in __ocfs2_cluster_lock(). Other solutions now on my mind are: 1. Give every waiter an ID. When clearing OCFS2_LOCK_BUSY, we can record those IDs in an array.

Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: fix false deadlock caused by clearing UPCONVERT_FINISHING too early

Hi, Very sorry, this fix is wrong, becuase it can ensure waking up every waiter, but cannot guarantee every waiter finish trying its "again" patch in __ocfs2_cluster_lock(). Other solutions now on my mind are: 1. Give every waiter an ID. When clearing OCFS2_LOCK_BUSY, we can record those IDs