Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-19 Thread alex chen
Hi Changwei, On 2017/12/19 17:44, Changwei Ge wrote: > On 2017/12/19 17:30, Junxiao Bi wrote: >> On 12/19/2017 05:11 PM, Changwei Ge wrote: >>> Hi Junxiao, >>> >>> On 2017/12/19 16:15, Junxiao Bi wrote: Hi Changwei, On 12/19/2017 02:02 PM, Changwei Ge wrote: > On 2017/12/19

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-19 Thread Changwei Ge
On 2017/12/19 17:30, Junxiao Bi wrote: > On 12/19/2017 05:11 PM, Changwei Ge wrote: >> Hi Junxiao, >> >> On 2017/12/19 16:15, Junxiao Bi wrote: >>> Hi Changwei, >>> >>> On 12/19/2017 02:02 PM, Changwei Ge wrote: On 2017/12/19 11:41, piaojun wrote: > Hi Changwei, > > On 2017/12/19

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-19 Thread Junxiao Bi
On 12/19/2017 05:11 PM, Changwei Ge wrote: > Hi Junxiao, > > On 2017/12/19 16:15, Junxiao Bi wrote: >> Hi Changwei, >> >> On 12/19/2017 02:02 PM, Changwei Ge wrote: >>> On 2017/12/19 11:41, piaojun wrote: Hi Changwei, On 2017/12/19 11:05, Changwei Ge wrote: > Hi Jun, >

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-19 Thread Changwei Ge
Hi Junxiao, On 2017/12/19 16:15, Junxiao Bi wrote: > Hi Changwei, > > On 12/19/2017 02:02 PM, Changwei Ge wrote: >> On 2017/12/19 11:41, piaojun wrote: >>> Hi Changwei, >>> >>> On 2017/12/19 11:05, Changwei Ge wrote: Hi Jun, On 2017/12/19 9:48, piaojun wrote: > Hi Changwei,

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-19 Thread Junxiao Bi
Hi Changwei, On 12/19/2017 02:02 PM, Changwei Ge wrote: > On 2017/12/19 11:41, piaojun wrote: >> Hi Changwei, >> >> On 2017/12/19 11:05, Changwei Ge wrote: >>> Hi Jun, >>> >>> On 2017/12/19 9:48, piaojun wrote: Hi Changwei, On 2017/12/18 20:06, Changwei Ge wrote: > Before ocfs2

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 14:28, Gang He wrote: > > > >> On 2017/12/19 10:35, Gang He wrote: >>> Hi Changwei, >>> >>> >> Before ocfs2 supporting allocating clusters while doing append-dio, all >> append dio will fall back to buffer io to allocate clusters firstly. Also, when it

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Gang He
>>> > On 2017/12/19 10:35, Gang He wrote: >> Hi Changwei, >> >> > >>> Before ocfs2 supporting allocating clusters while doing append-dio, all > append >>> dio will fall back to buffer io to allocate clusters firstly. Also, when it >>> steps on a file hole, it will fall back to buffer

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 11:41, piaojun wrote: > Hi Changwei, > > On 2017/12/19 11:05, Changwei Ge wrote: >> Hi Jun, >> >> On 2017/12/19 9:48, piaojun wrote: >>> Hi Changwei, >>> >>> On 2017/12/18 20:06, Changwei Ge wrote: Before ocfs2 supporting allocating clusters while doing append-dio, all

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 10:35, Gang He wrote: > Hi Changwei, > > >> Before ocfs2 supporting allocating clusters while doing append-dio, all >> append >> dio will fall back to buffer io to allocate clusters firstly. Also, when it >> steps on a file hole, it will fall back to buffer io, too. But for

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread piaojun
Hi Changwei, On 2017/12/19 11:05, Changwei Ge wrote: > Hi Jun, > > On 2017/12/19 9:48, piaojun wrote: >> Hi Changwei, >> >> On 2017/12/18 20:06, Changwei Ge wrote: >>> Before ocfs2 supporting allocating clusters while doing append-dio, all >>> append >>> dio will fall back to buffer io to

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
Hi Jun, On 2017/12/19 9:48, piaojun wrote: > Hi Changwei, > > On 2017/12/18 20:06, Changwei Ge wrote: >> Before ocfs2 supporting allocating clusters while doing append-dio, all >> append >> dio will fall back to buffer io to allocate clusters firstly. Also, when it >> steps on a file hole, it

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 9:39, Joseph Qi wrote: > > > On 17/12/19 09:27, Andrew Morton wrote: >> On Tue, 19 Dec 2017 09:24:17 +0800 Joseph Qi wrote: >> --- a/fs/ocfs2/aops.c~ocfs2-fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix +++

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 9:24, Joseph Qi wrote: > > On 17/12/19 05:53, Andrew Morton wrote: >> On Mon, 18 Dec 2017 12:06:21 + Changwei Ge wrote: >> >>> Before ocfs2 supporting allocating clusters while doing append-dio, all >>> append >>> dio will fall back to buffer io to

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Changwei Ge
On 2017/12/19 5:54, Andrew Morton wrote: > On Mon, 18 Dec 2017 12:06:21 + Changwei Ge wrote: > >> Before ocfs2 supporting allocating clusters while doing append-dio, all >> append >> dio will fall back to buffer io to allocate clusters firstly. Also, when it >> steps on

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Gang He
Hi Changwei, >>> > Before ocfs2 supporting allocating clusters while doing append-dio, all append > dio will fall back to buffer io to allocate clusters firstly. Also, when it > steps on a file hole, it will fall back to buffer io, too. But for current > code, writing to file hole will leverage

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Joseph Qi
On 17/12/19 05:53, Andrew Morton wrote: > On Mon, 18 Dec 2017 12:06:21 + Changwei Ge wrote: > >> Before ocfs2 supporting allocating clusters while doing append-dio, all >> append >> dio will fall back to buffer io to allocate clusters firstly. Also, when it >> steps on

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Joseph Qi
On 17/12/19 09:27, Andrew Morton wrote: > On Tue, 19 Dec 2017 09:24:17 +0800 Joseph Qi wrote: > >>> --- >>> a/fs/ocfs2/aops.c~ocfs2-fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix >>> +++ a/fs/ocfs2/aops.c >>> @@ -2469,10 +2469,9 @@ static

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread piaojun
Hi Changwei, On 2017/12/18 20:06, Changwei Ge wrote: > Before ocfs2 supporting allocating clusters while doing append-dio, all append > dio will fall back to buffer io to allocate clusters firstly. Also, when it > steps on a file hole, it will fall back to buffer io, too. But for current > code,

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Andrew Morton
On Tue, 19 Dec 2017 09:24:17 +0800 Joseph Qi wrote: > > --- > > a/fs/ocfs2/aops.c~ocfs2-fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix > > +++ a/fs/ocfs2/aops.c > > @@ -2469,10 +2469,9 @@ static int ocfs2_dio_end_io(struct kiocb > > * Will

Re: [Ocfs2-devel] [PATCH] ocfs2: fall back to buffer IO when append dio is disabled with file hole existing

2017-12-18 Thread Andrew Morton
On Mon, 18 Dec 2017 12:06:21 + Changwei Ge wrote: > Before ocfs2 supporting allocating clusters while doing append-dio, all append > dio will fall back to buffer io to allocate clusters firstly. Also, when it > steps on a file hole, it will fall back to buffer io, too.