Re: [Ocfs2-devel] [PATCH v2] ocfs2: using the OCFS2_XATTR_ROOT_SIZE macro in ocfs2_reflink_xattr_header()

On Mon, 11 Dec 2017 14:24:08 +0800 alex chen wrote: > Using the OCFS2_XATTR_ROOT_SIZE macro improves the readability of the code. > > Signed-off-by: Alex Chen > Reviewed-by: Jun Piao > --- > fs/ocfs2/xattr.c | 2 +- > 1 file

[Ocfs2-devel] [PATCH] ocfs2: clean dead code in suballoc.c

Stack variable fe is no longer used, so trim it to save some cpu cycles and stack space. Signed-off-by: Changwei Ge --- fs/ocfs2/suballoc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index 71f22c8fbffd..a74108d22d47

[Ocfs2-devel] [PATCH] ocfs2/cluster: clean up unused function declaration in heartbeat.h

Signed-off-by: Changwei Ge --- fs/ocfs2/cluster/heartbeat.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.h b/fs/ocfs2/cluster/heartbeat.h index 3ef5137dc362..a9e67efc0004 100644 --- a/fs/ocfs2/cluster/heartbeat.h +++

Re: [Ocfs2-devel] [PATCH] ocfs2: clean dead code in suballoc.c

On 17/12/13 11:04, Changwei Ge wrote: > Stack variable fe is no longer used, so trim it to save some cpu cycles > and stack space. > > Signed-off-by: Changwei Ge > --- > fs/ocfs2/suballoc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ocfs2/suballoc.c

[Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c

Stack variable fe is no longer used, so trim it to save some cpu cycles and stack space. Signed-off-by: Changwei Ge --- fs/ocfs2/suballoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index

Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: clean up unused function declaration in heartbeat.h

These have already been cleaned up in commit 98d6c09ec2899a9a601b16ec7ae31d54e6b100b9. On 17/12/13 11:19, Changwei Ge wrote: > Signed-off-by: Changwei Ge > --- > fs/ocfs2/cluster/heartbeat.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c

On 17/12/13 11:51, Changwei Ge wrote: > Stack variable fe is no longer used, so trim it to save some cpu cycles > and stack space. > > Signed-off-by: Changwei Ge > --- > fs/ocfs2/suballoc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: clean up unused function declaration in heartbeat.h

Yes, Jun has cleaned up those declarations. I will rebase my tree. Thanks, Changwei On 2017/12/13 12:06, Joseph Qi wrote: > These have already been cleaned up in commit > 98d6c09ec2899a9a601b16ec7ae31d54e6b100b9. > > On 17/12/13 11:19, Changwei Ge wrote: >> Signed-off-by: Changwei Ge

[Ocfs2-devel] [PATCH v3] ocfs2: clean dead code in suballoc.c

Stack variable fe is no longer used, so trim it to save some CPU cycles and stack space. Signed-off-by: Changwei Ge --- fs/ocfs2/suballoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index

Re: [Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c

On 2017/12/13 12:03, Joseph Qi wrote: > > > On 17/12/13 11:51, Changwei Ge wrote: >> Stack variable fe is no longer used, so trim it to save some cpu cycles >> and stack space. >> >> -BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, >>

Re: [Ocfs2-devel] [PATCH v3] ocfs2: clean dead code in suballoc.c

On 17/12/13 12:54, Changwei Ge wrote: > Stack variable fe is no longer used, so trim it to save some CPU cycles > and stack space. > > Signed-off-by: Changwei Ge Reviewed-by: Joseph Qi > --- > fs/ocfs2/suballoc.c | 6 +++--- > 1 file changed, 3

Re: [Ocfs2-devel] [PATCH v2] ocfs2: check the metadate alloc before marking extent written

Hi Changwei, On 2017/12/12 9:05, Changwei Ge wrote: > Hi Alex, > > On 2017/12/5 11:31, alex chen wrote: >> We need to check the free number of the records in each loop to mark >> extent written, because the last extent block may be changed through >> many times marking extent written and the

Re: [Ocfs2-devel] [PATCH v2] ocfs2: using the OCFS2_XATTR_ROOT_SIZE macro in ocfs2_reflink_xattr_header()

Hi Andrew, Thanks for your suggestion. On 2017/12/13 6:47, Andrew Morton wrote: > On Mon, 11 Dec 2017 14:24:08 +0800 alex chen wrote: > >> Using the OCFS2_XATTR_ROOT_SIZE macro improves the readability of the code. >> >> Signed-off-by: Alex Chen >>