Re: [Ocfs2-devel] Buffer read will get starvation in case reading/writing the same file from different nodes concurrently

2015-12-08 Thread Joseph Qi
On 2015/12/8 16:26, Eric Ren wrote: > Hi Joseph, > On Tue, Dec 08, 2015 at 02:15:17PM +0800, joseph wrote: >> On 2015/12/8 12:51, Eric Ren wrote: >>> Hi, >>> >>> On Tue, Dec 08, 2015 at 11:55:18AM +0800, joseph wrote: Hi Gang, Eric and I have discussed this case before. Using NONBL

Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-08 Thread Junxiao Bi
Hi Andrew, On 12/09/2015 05:22 AM, Andrew Morton wrote: > On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > >> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, >> SGID of sub dir was not inherited from its parents dir. It is because SGID >> is set into "inode->i_m

[Ocfs2-devel] [PATCH] ocfs2: constify ocfs2_extent_tree_operations structures

2015-12-08 Thread Julia Lawall
The ocfs2_extent_tree_operations structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- fs/ocfs2/alloc.c | 12 ++-- fs/ocfs2/alloc.h |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/ocfs2/

Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-08 Thread Andrew Morton
On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, > SGID of sub dir was not inherited from its parents dir. It is because SGID > is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten > by "mode" w

Re: [Ocfs2-devel] Buffer read will get starvation in case reading/writing the same file from different nodes concurrently

2015-12-08 Thread Eric Ren
Hi Joseph, On Tue, Dec 08, 2015 at 02:15:17PM +0800, joseph wrote: > On 2015/12/8 12:51, Eric Ren wrote: > > Hi, > > > > On Tue, Dec 08, 2015 at 11:55:18AM +0800, joseph wrote: > >> Hi Gang, > >> Eric and I have discussed this case before. > >> Using NONBLOCK here is because there is a lock inve