Re: [Ocfs2-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

2016-01-06 Thread Martin K. Petersen
> "Mike" == mchristi writes: +enum req_op { + REQ_OP_READ, + REQ_OP_WRITE= REQ_WRITE, + REQ_OP_DISCARD = REQ_DISCARD, + REQ_OP_WRITE_SAME = REQ_WRITE_SAME, +}; + I have been irked by the REQ_ prefix in bios since the

Re: [Ocfs2-devel] [PATCH 00/35 v2] separate operations from flags in the bio/request structs

2016-01-06 Thread Martin K. Petersen
> "Mike" == mchristi writes: Mike> The following patches begin to cleanup the request->cmd_flags and bio-> bi_rw mess. We currently use cmd_flags to specify the operation, Mike> attributes and state of the request. For bi_rw we use it for Mike> similar info and also the

Re: [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang

2016-01-06 Thread Tariq Saeed
On 01/05/2016 08:41 PM, Junxiao Bi wrote: > This fixed part of the deadlock. There is another part. > ocfs2_mknod()->posix_acl_create()->ocfs2_iop_get_acl() Right. It used to be: ocfs2_mknod -> ocfs2_init_acl -> ocfs2_get_acl_nolock. Thanks -Tariq

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: ignore cleaning the migration mle that is inuse

2016-01-06 Thread Junxiao Bi
On 01/06/2016 08:57 AM, xuejiufei wrote: > Hi Junxiao, > Function dlm_clean_migration_mle() will not be called after the first > patch applied. So the issue that the owner of lockres will be set to > a down node is not exist. Right. Thank you for the explanation. Thanks, Junxiao. > > Thanks, >

Re: [Ocfs2-devel] [PATCH] ocfs2: Do not lock/unlock() inode DLM lock

2016-01-06 Thread Eric Ren
Hi, On Tue, Dec 29, 2015 at 07:31:16PM -0700, He Gang wrote: > Hello Goldwyn, > > When read path can't get the DLM lock immediately (NONBLOCK way), next get > the lock with BLOCK way, this behavior will cost some time (several msecs). > It looks make sense to delete that two line code. > But

Re: [Ocfs2-devel] [PATCH 00/35 v2] separate operations from flags in the bio/request structs

2016-01-06 Thread Dave Chinner
On Wed, Jan 06, 2016 at 08:40:09PM -0500, Martin K. Petersen wrote: > > "Mike" == mchristi writes: > > Mike> The following patches begin to cleanup the request->cmd_flags and > bio-> bi_rw mess. We currently use cmd_flags to specify the operation, > Mike> attributes and

Re: [Ocfs2-devel] [PATCH 13/35] xfs: set bi_op to REQ_OP

2016-01-06 Thread Dave Chinner
On Tue, Jan 05, 2016 at 02:53:16PM -0600, mchri...@redhat.com wrote: > From: Mike Christie > > This patch has xfs set the bio bi_op to a REQ_OP, and > rq_flag_bits to bi_rw. > > Note: > I have run xfs tests on these btrfs patches. There were some failures > with and without

Re: [Ocfs2-devel] [PATCH 25/35] target: set bi_op to REQ_OP

2016-01-06 Thread Nicholas A. Bellinger
Hi Mike, On Tue, 2016-01-05 at 14:53 -0600, mchri...@redhat.com wrote: > From: Mike Christie > > This patch has the target modules set the bio bi_op to a REQ_OP, and > rq_flag_bits to bi_rw. > > This patch is compile tested only. > > Signed-off-by: Mike Christie