looks good, thanks.
Reviewed-by: Gang He
>>>
> From: Guozhonghua
>
> When doing append direct io cleanup, if deleting inode fails, it goes
> out without unlocking inode, which will cause the inode deadlock.
> This issue was introduced by commit cf1776a9e834("ocfs2: fix a tiny
> race when tru
Hi Junxiao,
On 02/24/2016 09:48 AM, Junxiao Bi wrote:
> Hi Eric,
>
> On 02/19/2016 11:01 AM, Eric Ren wrote:
>> Hi Junxiao,
>>
>> On Wed, Feb 17, 2016 at 10:15:56AM +0800, Junxiao Bi wrote:
>>> Hi Eric,
>>>
>>> I remember i described it before, please search it on ocfs2-devel. For
>>> ocfs2 env se
From: Guozhonghua
When doing append direct io cleanup, if deleting inode fails, it goes
out without unlocking inode, which will cause the inode deadlock.
This issue was introduced by commit cf1776a9e834("ocfs2: fix a tiny
race when truncate dio orohaned entry").
Signed-off-by: Guozhonghua
Signe
Hi Guozhonghua,
Thanks for pointing this out.
But you should follow the way described in
Documentation/SubmittingPatches to submit your patch.
I'll re-arrange and resend it.
Thanks,
Joseph
On 2016/2/24 9:11, Guozhonghua wrote:
>
> aops.c, in the function ocfs2_direct_IO_write.
>
> *
Hi Eric,
On 02/19/2016 11:01 AM, Eric Ren wrote:
> Hi Junxiao,
>
> On Wed, Feb 17, 2016 at 10:15:56AM +0800, Junxiao Bi wrote:
>> Hi Eric,
>>
>> I remember i described it before, please search it on ocfs2-devel. For
>> ocfs2 env setup, please refer to README in ocfs2-test.
>
> Yes, you did. Act
aops.c, in the function ocfs2_direct_IO_write.
*** clean_orphan:
*** 948,961
--- 947,963
tmp_ret = ocfs2_inode_lock(inode, &di_bh, 1);
if (tmp_ret < 0) {
ret = tmp_ret;
mlog_errno(ret);