Re: [Ocfs2-devel] [PATCH] ocfs2: fix improper handling of return errno

2016-05-22 Thread Gang He
>>> > On 2016/5/23 10:30, Eric Ren wrote: >> Previously, if bad inode was found in ocfs2_iget(), -ESTALE was >> returned back to the caller anyway. Since commit d2b9d71a2da7 >> ("ocfs2: check/fix inode block for online file check") can handle >> with return value from ocfs2_read_locked_inode()

Re: [Ocfs2-devel] [PATCH] ocfs2: fix a redundant re-initialization

2016-05-22 Thread Gang He
>>> > On 2016/5/23 10:30, Eric Ren wrote: >> Obviously, memset() has zeroed the whole struct locking_max_version. >> So, it's no need to zero its two fields individually. >> >> Signed-off-by: Eric Ren > Looks good, thanks. > Reviewed-by: Joseph Qi Reviewed-by: Gang He > >> --- >> fs/ocfs

Re: [Ocfs2-devel] [PATCH] ocfs2: fix improper handling of return errno

2016-05-22 Thread Joseph Qi
On 2016/5/23 10:30, Eric Ren wrote: > Previously, if bad inode was found in ocfs2_iget(), -ESTALE was > returned back to the caller anyway. Since commit d2b9d71a2da7 > ("ocfs2: check/fix inode block for online file check") can handle > with return value from ocfs2_read_locked_inode() now, we know t

Re: [Ocfs2-devel] [PATCH] ocfs2: fix a redundant re-initialization

2016-05-22 Thread Joseph Qi
On 2016/5/23 10:30, Eric Ren wrote: > Obviously, memset() has zeroed the whole struct locking_max_version. > So, it's no need to zero its two fields individually. > > Signed-off-by: Eric Ren Looks good, thanks. Reviewed-by: Joseph Qi > --- > fs/ocfs2/stackglue.c | 2 -- > 1 file changed, 2 del

[Ocfs2-devel] [PATCH] ocfs2: fix improper handling of return errno

2016-05-22 Thread Eric Ren
Previously, if bad inode was found in ocfs2_iget(), -ESTALE was returned back to the caller anyway. Since commit d2b9d71a2da7 ("ocfs2: check/fix inode block for online file check") can handle with return value from ocfs2_read_locked_inode() now, we know the exact errno returned for us. Signed-off-

[Ocfs2-devel] [PATCH] ocfs2: fix a redundant re-initialization

2016-05-22 Thread Eric Ren
Obviously, memset() has zeroed the whole struct locking_max_version. So, it's no need to zero its two fields individually. Signed-off-by: Eric Ren --- fs/ocfs2/stackglue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 5d965e8..855fb44 1006