Re: [Ocfs2-devel] [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Dave Chinner
to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> > --- .... XFS bits look fine. Acked-by: Dave Chinner <dchin..

Re: [Ocfs2-devel] [PATCH 2/3] xfs: don't use ioends for direct write completions

2016-02-07 Thread Dave Chinner
ith the API change and merge issues? I'm happy to take the DIO API change through the XFS tree, if that's the fastest/easiest way to get the necessary DIO subsystem fixes into the mainline tree for XFS. As such, the for-next tree that I'm building right now will include the DIO API

Re: [Ocfs2-devel] [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota

2016-02-07 Thread Dave Chinner
On Fri, Feb 05, 2016 at 12:05:19PM +1100, Dave Chinner wrote: > On Thu, Feb 04, 2016 at 03:28:05PM +0100, Jan Kara wrote: > > Add infrastructure for supporting get_nextdqblk() callback for VFS > > quotas. Translate the operation into a callback to appropriate > > filesy

Re: [Ocfs2-devel] [PATCH 2/3] xfs: don't use ioends for direct write completions

2016-02-07 Thread Dave Chinner
On Mon, Feb 08, 2016 at 12:00:26PM +1100, Dave Chinner wrote: > On Wed, Feb 03, 2016 at 07:40:15PM +0100, Christoph Hellwig wrote: > > We only need to communicate two bits of information to the direct I/O > > completion handler: > > > > (1) do we need to co

Re: [Ocfs2-devel] [PATCH 2/3] xfs: don't use ioends for direct write completions

2016-02-05 Thread Dave Chinner
return error; > > + } > > + error = xfs_setfilesize(ip, tp, offset, size); > > Don't we need a xfs_trans_commit() here? No, xfs_setfilesize() does that. Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota

2016-02-04 Thread Dave Chinner
ather than one of us having to pull in a whole tree of changes just to get the one commit we need... Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 00/35 v2] separate operations from flags in the bio/request structs

2016-01-06 Thread Dave Chinner
rward? Set a "speak now or forever hold your peace" > review deadline? I say just ask Linus to pull it immediately after the next merge window closes Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 13/35] xfs: set bi_op to REQ_OP

2016-01-06 Thread Dave Chinner
iles changed, 17 insertions(+), 13 deletions(-) Not sure which patches your note is refering to here. The XFS change here looks fine. Acked-by: Dave Chinner <dchin...@redhat.com> -Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing

Re: [Ocfs2-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces

2015-01-21 Thread Dave Chinner
On Wed, Jan 21, 2015 at 11:23:20PM +0100, Jan Kara wrote: On Thu 22-01-15 08:38:26, Dave Chinner wrote: On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote: Hello, this is another iteration of patches to unify VFS and XFS quota interfaces so that XFS quotactls work

Re: [Ocfs2-devel] [PATCH 03/12] xfs: Set allowed quota types

2014-10-06 Thread Dave Chinner
On Wed, Oct 01, 2014 at 09:31:25PM +0200, Jan Kara wrote: We support user, group, and project quotas. Tell VFS about it. CC: x...@oss.sgi.com CC: Dave Chinner da...@fromorbit.com Signed-off-by: Jan Kara j...@suse.cz --- fs/xfs/xfs_super.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Ocfs2-devel] [PATCH] fs/super.c: do not shrink fs slab during direct memory reclaim

2014-09-02 Thread Dave Chinner
On Tue, Sep 02, 2014 at 05:03:27PM +0800, Xue jiufei wrote: Hi, Dave On 2014/9/2 7:51, Dave Chinner wrote: On Fri, Aug 29, 2014 at 05:57:22PM +0800, Xue jiufei wrote: The patch trys to solve one deadlock problem caused by cluster fs, like ocfs2. And the problem may happen at least

Re: [Ocfs2-devel] [PATCH] fs/super.c: do not shrink fs slab during direct memory reclaim

2014-09-02 Thread Dave Chinner
On Wed, Sep 03, 2014 at 09:38:31AM +0800, Junxiao Bi wrote: Hi Jiufei, On 09/02/2014 05:03 PM, Xue jiufei wrote: Hi, Dave On 2014/9/2 7:51, Dave Chinner wrote: On Fri, Aug 29, 2014 at 05:57:22PM +0800, Xue jiufei wrote: The patch trys to solve one deadlock problem caused by cluster

Re: [Ocfs2-devel] [PATCH] fs/super.c: do not shrink fs slab during direct memory reclaim

2014-09-02 Thread Dave Chinner
On Wed, Sep 03, 2014 at 12:21:24PM +0800, Junxiao Bi wrote: On 09/03/2014 11:10 AM, Dave Chinner wrote: On Wed, Sep 03, 2014 at 09:38:31AM +0800, Junxiao Bi wrote: Hi Jiufei, On 09/02/2014 05:03 PM, Xue jiufei wrote: Hi, Dave On 2014/9/2 7:51, Dave Chinner wrote: On Fri, Aug 29

Re: [Ocfs2-devel] [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Dave Chinner
to be independent of the physical filesystem time encoding Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

2014-03-28 Thread Dave Chinner
On Thu, Dec 12, 2013 at 05:02:57PM -0700, Andreas Dilger wrote: On Dec 12, 2013, at 4:24 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Dec 12, 2013 at 04:25:59PM +0100, David Sterba wrote: This flag was not accepted when fiemap was proposed [2] due to lack of in-kernel users. Btrfs

Re: [Ocfs2-devel] [XFS on bad superblock] BUG: unable to handle kernel NULL pointer dereference at 00000003

2014-03-28 Thread Dave Chinner
as the cause of the problems because the XFS code paths on scsi, sata, brd and virtio block device don't cause any problems Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com

Re: [Ocfs2-devel] [XFS on bad superblock] BUG: unable to handle kernel NULL pointer dereference at 00000003

2014-03-28 Thread Dave Chinner
reiserfs gfs2 isofs ocfs2 which means that no XFS filesystem was mounted in the original bug report, and hence that further indicates that XFS is not responsible for the problem and that perhaps the original bisect was not reliable... Cheers, Dave. -- Dave Chinner da

Re: [Ocfs2-devel] [XFS on bad superblock] BUG: unable to handle kernel NULL pointer dereference at 00000003

2014-03-28 Thread Dave Chinner
On Thu, Oct 10, 2013 at 02:03:34PM +0800, Fengguang Wu wrote: On Thu, Oct 10, 2013 at 03:28:20PM +1100, Dave Chinner wrote: On Thu, Oct 10, 2013 at 11:38:34AM +0800, Fengguang Wu wrote: On Thu, Oct 10, 2013 at 11:33:00AM +0800, Fengguang Wu wrote: On Thu, Oct 10, 2013 at 11:26:37AM +0800

Re: [Ocfs2-devel] [PATCH 0/8] Set bi_rw when alloc bio before call bio_add_page.

2012-08-15 Thread Dave Chinner
data telling me it is worthwhile, and it's a lot of code to churn for no benefit Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 00/19 v5] Fix filesystem freezing deadlocks

2012-04-17 Thread Dave Chinner
handle this problem, but perhaps pushing this check down into filesystem specific code or adding a superblock feature flag might be a way to allow filesystems to handle this case in the way they think is best... Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge ( 16 TiB) volumes to mount

2010-07-13 Thread Dave Chinner
systemsi (i.e. page cache address limits). IOWs, you can't just remove the above 16TB check unless you (i.e. OCFS2) handle 16TB block devices on 32 bit systems correctly... Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list

Re: [Ocfs2-devel] [PATCH] Revert writeback: limit write_cache_pages integrity scanning to current EOF

2010-06-29 Thread Dave Chinner
On Mon, Jun 28, 2010 at 07:04:20PM -0700, Joel Becker wrote: On Tue, Jun 29, 2010 at 11:56:15AM +1000, Dave Chinner wrote: Regarding XFS, how do you handle catching the tail of an allocation with an lseek(2)'d write? That is, your current allocation has a few blocks outside of i_size

Re: [Ocfs2-devel] [PATCH] Revert writeback: limit write_cache_pages integrity scanning to current EOF

2010-06-29 Thread Dave Chinner
with this. Cheers, Dave. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] Revert writeback: limit write_cache_pages integrity scanning to current EOF

2010-06-29 Thread Dave Chinner
On Mon, Jun 28, 2010 at 05:54:04PM -0700, Joel Becker wrote: On Tue, Jun 29, 2010 at 10:24:21AM +1000, Dave Chinner wrote: On Mon, Jun 28, 2010 at 10:35:29AM -0700, Joel Becker wrote: This reverts commit d87815cb2090e07b0b0b2d73dc9740706e92c80c. Hi Joel, I have no problems

Re: [Ocfs2-devel] [PATCH] Revert writeback: limit write_cache_pages integrity scanning to current EOF

2010-06-28 Thread Dave Chinner
. -- Dave Chinner da...@fromorbit.com ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel