Re: [Ocfs2-devel] [PATCH 1/6] ocfs2: convert inode refcount test to a helper

2016-11-10 Thread Darrick J. Wong
On Thu, Nov 10, 2016 at 10:14:48AM +0800, Eric Ren wrote: > On 11/10/2016 06:51 AM, Darrick J. Wong wrote: > >Replace the open-coded inode refcount flag test with a helper function > >to reduce the potential for bugs. > Thanks for this series;-) Some comments inline below: > > > >Signed-off-by: Dar

Re: [Ocfs2-devel] [PATCH 1/6] ocfs2: convert inode refcount test to a helper

2016-11-09 Thread Eric Ren
On 11/10/2016 06:51 AM, Darrick J. Wong wrote: > Replace the open-coded inode refcount flag test with a helper function > to reduce the potential for bugs. Thanks for this series;-) Some comments inline below: > > Signed-off-by: Darrick J. Wong > --- > fs/ocfs2/refcounttree.c | 28

[Ocfs2-devel] [PATCH 1/6] ocfs2: convert inode refcount test to a helper

2016-11-09 Thread Darrick J. Wong
Replace the open-coded inode refcount flag test with a helper function to reduce the potential for bugs. Signed-off-by: Darrick J. Wong --- fs/ocfs2/refcounttree.c | 28 +++- fs/ocfs2/refcounttree.h |2 ++ 2 files changed, 17 insertions(+), 13 deletions(-) diff --