sistent between get_block-vs-truncate race by other means, So
ip_alloc_sem in ocfs2 direct io is needed.
Date: Fri, 11 Sep 2015 16:19:18 +0800
From: Ryan Ding <ryan.d...@oracle.com>
Subject: [Ocfs2-devel] [PATCH 7/8] ocfs2: fix sparse file & data
orderingissue in direc
Hi Guanghui,
Please sort out your mail more orderly. It looks really messy! So, rework your
mail by asking
question yourself like:
- What is the problem you are facing?
Looks like a BUG_ON() is triggered. but which BUG_ON()? the backtrace? How
this can be
reroduced?
- What help or answer do
Hi,
On 11/16/2016 06:45 PM, Dan Carpenter wrote:
> On Wed, Nov 16, 2016 at 10:33:49AM +0800, Eric Ren wrote:
> That silences the warning, of course, but I feel like the code is buggy.
> How do we know that we don't hit that exit path?
Sorry, I missed your point. Do you mean the below?
"1817 goto
On Wed, Nov 16, 2016 at 10:33:49AM +0800, Eric Ren wrote:
> >>>fs/ocfs2/aops.c
> >>> 2235
> >>> 2236 ret = ocfs2_write_begin_nolock(inode->i_mapping, pos, len,
> >>> 2237 OCFS2_WRITE_DIRECT, NULL,
> >>> 2238
Hi Dan,
On 11/15/2016 06:36 PM, Dan Carpenter wrote:
> Ryan's email is dead. But this is buggy. Someone please fix it.
>
> regards,
> dan carpenter
>
> On Tue, Nov 15, 2016 at 01:33:30PM +0300, Dan Carpenter wrote:
>> I never got a response on this. I was looking at it today and it still
>>
Ryan's email is dead. But this is buggy. Someone please fix it.
regards,
dan carpenter
On Tue, Nov 15, 2016 at 01:33:30PM +0300, Dan Carpenter wrote:
> I never got a response on this. I was looking at it today and it still
> looks buggy to me.
>
> regards,
> dan carpenter
>
> On Wed, Mar
I never got a response on this. I was looking at it today and it still
looks buggy to me.
regards,
dan carpenter
On Wed, Mar 09, 2016 at 01:25:05PM +0300, Dan Carpenter wrote:
> Hello Ryan Ding,
>
> The patch fbe25fb91af5: "ocfs2: fix sparse file & data ordering issue
> in direct io" from Feb
Hello Ryan Ding,
The patch fbe25fb91af5: "ocfs2: fix sparse file & data ordering issue
in direct io" from Feb 25, 2016, leads to the following static
checker warning:
fs/ocfs2/aops.c:2242 ocfs2_dio_get_block()
error: potentially dereferencing uninitialized 'wc'.
fs/ocfs2/aops.c
