Re: [Ocfs2-devel] [PATCH v2] ocfs2: try to reuse extent block in dealloc without meta_alloc

2018-01-02 Thread Junxiao Bi
On 12/27/2017 08:21 PM, Changwei Ge wrote: > Hi Junxiao, > > On 2017/12/27 18:02, Junxiao Bi wrote: >> Hi Changwei, >> >> >> On 12/26/2017 03:55 PM, Changwei Ge wrote: >>> A crash issue was reported by John. >>> The call trace follows: >>> ocfs2_split_extent+0x1ad3/0x1b40 [ocfs2] >>>

[Ocfs2-devel] [PATCH] ocfs: fix fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix

2018-01-02 Thread Arnd Bergmann
The 'ret' variable is used to store the integer return value of ocfs2_get_clusters(), as shown by this warning from modern compilers: fs/ocfs2/aops.c: In function 'ocfs2_range_has_holes': fs/ocfs2/aops.c:2437:11: error: comparison of constant '0' with boolean expression is always false

Re: [Ocfs2-devel] [PATCH] ocfs: fix fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix

2018-01-02 Thread alex chen
Hi Arnd, On 2018/1/2 18:34, Arnd Bergmann wrote: > Fixes: mmotm > ("ocfs2-fall-back-to-buffer-io-when-append-dio-is-disabled-with-file-hole-existing-fix") I think this patch is not fit for mainline and will not be apply to mainline in the future. Andrew can remove it from mm-tree. Thanks, Alex

Re: [Ocfs2-devel] [PATCH v3 2/3] ocfs2: add ocfs2_overwrite_io function

2018-01-02 Thread alex chen
Hi Gang, On 2017/12/28 18:07, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 45

Re: [Ocfs2-devel] [PATCH v3 2/3] ocfs2: add ocfs2_overwrite_io function

2018-01-02 Thread Gang He
Hi Alex, >>> > Hi Gang, > > On 2017/12/28 18:07, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> >> Signed-off-by: Gang He >> --- >>

Re: [Ocfs2-devel] [PATCH v2] ocfs2: try to reuse extent block in dealloc without meta_alloc

2018-01-02 Thread Changwei Ge
Hi Junxiao, On 2018/1/2 16:18, Junxiao Bi wrote: > On 12/27/2017 08:21 PM, Changwei Ge wrote: >> Hi Junxiao, >> >> On 2017/12/27 18:02, Junxiao Bi wrote: >>> Hi Changwei, >>> >>> >>> On 12/26/2017 03:55 PM, Changwei Ge wrote: A crash issue was reported by John. The call trace follows: