Hello Mark,
>>>
> On Fri, Dec 25, 2015 at 03:16:17PM +0800, Gang He wrote:
>> Implement online file check sysfile interfaces, e.g.
>> how to create the related sysfile according to device name,
>> how to display/handle file check request from the sysfile.
Hello Mark,
>>>
> On Fri, Dec 25, 2015 at 03:16:19PM +0800, Gang He wrote:
>> Implement online check or fix inode block during
>> reading a inode block to memory.
>>
>> Signed-off-by: Gang He
>> ---
>> fs/ocfs2/inode.c | 200
> +
Hello guy,
First, OCFS2 is a shared disk cluster file system, not a distibuted file system
(like Ceph), we only share the same data/metadata copy on this shared disk,
please make sure this shared disk are always integrated.
Second, if file system encounters any error, the behavior is specified b
Hi Junxiao,
Thank for your fix.
Just one quick question, this fix only effects OCFS2 O2CB case, right?
If the user selects pacemaker as cluster stack? OCFS2 file system will
encounter the same problem?
Thanks
Gang
>>>
> Hi,
>
> This serial of patches is to fix the issue that when storage do
t a multiple copy distributed file
system.
option "errors=continue" can let the file system continue when encountering a
local inode meta-data corruption problem.
Thanks
Gang
>
>
> Thanks,
>
> Guy
>
> On Wed, Jan 20, 2016 at 4:21 AM, Gang He wrote:
>
&g
Cool, thank for sharing.
Thanks
Gang
>>>
> This means the following patches have passed ocfs2-test. The first three
> ones are merged by me to avoid that recursive deadlock issue.
>
> =
>
> -inode deadlock in ocfs2_mknode due to using posix_acl_create
> -posix_acl_
Hello Mark,
Thanks for your comments.
-Gang
>>>
> On Fri, Feb 05, 2016 at 06:35:07AM -0700, Gang He wrote:
>> Hi Mark,
>>
>>
>> >>>
>> > On Sun, Jan 24, 2016 at 11:11:33PM -0700, Gang He wrote:
>> >> >> Also,
looks good, thanks.
Reviewed-by: Gang He
>>>
> From: Guozhonghua
>
> When doing append direct io cleanup, if deleting inode fails, it goes
> out without unlocking inode, which will cause the inode deadlock.
> This issue was introduced by commit cf1776a9e834("
file's inode number is reported in the kernel
log. The user can try to check/fix this file via online filecheck feature.
Signed-off-by: Gang He
Reviewed-by: Mark Fasheh
---
.../filesystems/ocfs2-online-filecheck.txt | 94 ++
1 file changed, 94 insertions(+)
create
Create online file check sysfile when ocfs2 mount,
remove the related sysfile when ocfs2 umount.
Signed-off-by: Gang He
Reviewed-by: Mark Fasheh
---
fs/ocfs2/super.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 2de4c8a..5ef88b8 100644
--- a
Implement online file check sysfile interfaces, e.g.
how to create the related sysfile according to device name,
how to display/handle file check request from the sysfile.
Signed-off-by: Gang He
---
fs/ocfs2/Makefile| 3 +-
fs/ocfs2/filecheck.c | 606
Export ocfs2_kset object from ocfs2_stackglue kernel module,
then online file check code will create the related sysfiles
under ocfs2_kset object.
Signed-off-by: Gang He
Reviewed-by: Mark Fasheh
---
fs/ocfs2/stackglue.c | 3 ++-
fs/ocfs2/stackglue.h | 2 ++
2 files changed, 4 insertions(+), 1
Implement online check or fix inode block during
reading a inode block to memory.
Signed-off-by: Gang He
---
fs/ocfs2/inode.c | 225 +++--
fs/ocfs2/ocfs2_trace.h | 2 +
2 files changed, 218 insertions(+), 9 deletions(-)
diff --git a/fs/ocfs2
with first version, I use strncasecmp instead of double strncmp
functions. Second, update the source file contribution vendor.
Gang He (5):
ocfs2: export ocfs2_kset for online file check
ocfs2: sysfile interfaces for online file check
ocfs2: create/remove sysfile for online file check
ocfs2: check/
Hello Changkuo,
Maybe you can use debugfs.ocfs2 to search and dump the inode block, then try to
see if the extent tree is destroyed, or not?
Thanks
Gang
>>>
> Hi Junxiao,
> Thanks for you reply.
> Unfortunately, the file was removed few days ago, and I cann't find the
> extents tree
Hi Changkuo,
From your description, the concern looks to make sense.
Could you reproduce this issue? if yes, I think we should adjust this logic
more quickly.
Thanks
Gang
>>>
> Hi all,
> When NodeA want to unlock lock-res1, and it send message to NodeB, but
> in NodeB any lock queues (gr
Good idea.
We need a IRC channel indeed.
Thanks
Gang
>>>
>
>> Hello Mark,
>>
>> Could you help to add these accounts in ocfs2-tools project on github?
>>
>> Gang He - SUSE: ganghe
>> Junxiao - Oracle:biger410
>> Joseph Qi -
1 Mar 2016 15:57:23 -0700 Mark Fasheh wrote:
>> >
>> > > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
>> > > > Implement online file check sysfile interfaces, e.g.
>> > > > how to create the related sysfile according t
Hi Christoph,
The feature sounds good. OCFS2 has file clone feature (so far, we only support
clone the whole file),
what efforts will be involved if we add this feature support?
Thanks
Gang
>>>
> We made the btrfs clone support generic to add NFS support, and support
> the future XFS refli
Hello Joseph and Jiufei,
I got a customer issue, ocfs2: filesystem goes read-only after node restart.
The symptom is very similar with this bug, when the ocfs2 file system called
ocfs2_recover_orphans() during mounting period,
Then, encountered this issue, the stack likes,
Mar 10 17:45:11 mipkhp
Hi Jeseph and Jiufei,
>>>
> Hi Gang，
>
> On 2016/3/23 17:46, Gang He wrote:
>> Hello Joseph and Jiufei,
>>
>> I got a customer issue, ocfs2: filesystem goes read-only after node restart.
>> The symptom is very similar with this bug, when the ocfs2 f
Hello Guys,
I got a bug, which reported a kernel BUG in function ocfs2_truncate_file,
Base on my initial analysis, this bug looks like a race condition problem.
Unfortunately, there was no kernel crash dump caught, just got some kernel log
as below,
kernel BUG at /usr/src/packages/BUILD/ocfs2-1.
Hello Joseph and Junxiao,
Did you encounter this issue in the past? I doubt this is possible a race
condition bug (rather than data inconsistency).
Thanks
Gang
>>>
> Hello Guys,
>
> I got a bug, which reported a kernel BUG in function ocfs2_truncate_file,
> Base on my initial analysis, this
;t found any related information about this BUG.
> Which kernel version are you using? It seems inode size mismatch between
> disk and memory, so any further log about these?
>
> Thanks,
> Joseph
>
> On 2016/3/31 10:56, Gang He wrote:
>> Hello Joseph and Junxiao,
>
Thanks Eric for this efforts.
Hope everyone can come in for some discussion when you are idle.
Thanks
Gang
>>>
> Hello Mark and all,
>
> Last week, I proposed to have an IRC channel for OCFS2 in tools maillist
> [1]. I'm afraid most people probably didn't even notice it.
>
> So, I bring up h
Hello Changwei,
You can take a look at dlm_lock related code, dlm_lock callback functions will
handle how to make other nodes' certain inode page cache invalidate. Or, force
the writing page cache to disk before read the data from other nodes.
Thanks
Gang
>>>
> Hi OCFS2 experts,
>
> Accord
Yes, "!eb || !eb.h_next_leaf_blk" looks more readable.
Thanks
Gang
>>>
> Hello there,
>
> linux-4.6-rc2/fs/ocfs2/refcounttree.c:987]: (style) Redundant condition: eb.
> '!eb || (eb && !eb.h_next_leaf_blk)' is equivalent to '!eb ||
> !eb.h_next_leaf_blk'
>
> Source code is
>
> if (
s
Gang
>>>
> On 03/31/2016 10:56 AM, Gang He wrote:
>> Hello Joseph and Junxiao,
>>
>> Did you encounter this issue in the past? I doubt this is possible a race
> condition bug (rather than data inconsistency).
> Never saw this. fsck report any corruption?
>
> Joseph
>
> On 2016/4/21 15:59, Gang He wrote:
>> Hello Guys,
>>
>> Sorry for delayed reply, the fsck log was reported from the customer.
>> OCFS2 volumes to check are:
>> /dev/dm-11 83886080 44540260 39345820 54% /sapmnt
>&g
>>>
> Hi Gang,
>
> On 2016/4/21 17:50, Gang He wrote:
>>
>>
>>
>>>>>
>>> Hi Gang,
>>> May be. If so, it seems that it has relations with locks.
>>> Can we know which data is newer?
>> Hi Joseph, I do n
Hello Goldwyn,
Thank for your efforts on improving online file check.
I was being engaged by some bugs in the past days.
Thanks
Gang
>>>
> From: Goldwyn Rodrigues
>
> This adds /sys/fs/ocfs2/ to the sys filesystem. All other
> files are added in this directory. This is done by:
> 1. Adding k
Hello Guys,
Here is a inconsistent LVB_LEN size problem when create a new lockspace from
user-space tool (e.g. fsck.ocfs2) and kernel module (e.g. ocfs2/stack_user.c).
>From the userspace tool, the LVB size is DLM_USER_LVB_LEN (32 bytes, defined
>in /include/linux/dlm_device.h)
>From the kernel
should give the user a obvious error message,
then, the user can let that user space tool exit before mounting the file
system again.
Signed-off-by: Gang He
---
fs/ocfs2/stack_user.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2
dlm_new_lockspace() function, to make
sure the lockspace is created by kernel module itself, and this change will
not affect the backward compatibility.
Second, the obvious error message is reported in the kernel log, let the user
be more easy to find the root cause.
Gang He (1):
ocfs2: insure dlm lockspace
Hello Joseph, Junxiao and All,
I got some benchmark related questions, but due to hardware limitation in our
local lab, we have not enough information to answer the questions.
Could you help to look at the questions, if you ever did the related testings
in your sites.
1) How many nodes can OCFS
>>>
> On 2016/5/23 10:30, Eric Ren wrote:
>> Obviously, memset() has zeroed the whole struct locking_max_version.
>> So, it's no need to zero its two fields individually.
>>
>> Signed-off-by: Eric Ren
> Looks good, thanks.
> Reviewed-by: Jos
with return value from ocfs2_read_locked_inode() now, we know the
>> exact errno returned for us.
>>
>> Signed-off-by: Eric Ren
> Looks good to me, thanks.
> Reviewed-by: Joseph Qi
Reviewed-by: Gang He
>
>> ---
>> fs/ocfs2/inode.c | 7 +--
>> 1 f
Hello Goldwyn,
Thanks for your code, my comments are inline.
>>>
> From: Goldwyn Rodrigues
>
> This adds /sys/fs/ocfs2/ to the sys filesystem. This
Gang: My suggestion is to create a sysfs directory device_name under
/sys/fs/ocfs2 per each file system,
The file system generic attributes shou
Hello Goldwyn,
Please see my comments inline.
I just suggest to re-use the existing code as most as possible, since the code
was tested by us.
Thanks
Gang
>>>
> From: Goldwyn Rodrigues
>
> This reduces the code base and removes unnecessary data structures
> for filecheck information since a
Looks good for me.
Thanks
Gang
>>>
> From: Goldwyn Rodrigues
>
> Signed-off-by: Goldwyn Rodrigues
> ---
> fs/ocfs2/inode.c | 13 +
> fs/ocfs2/sysfs.c | 17 +
> fs/ocfs2/sysfs.h | 2 ++
> 3 files changed, 32 insertions(+)
>
> diff --git a/fs/ocfs2/inode.c b/fs/o
Looks good to me.
Thanks
Gang
>>>
> From: Goldwyn Rodrigues
>
> Signed-off-by: Goldwyn Rodrigues
> ---
> fs/ocfs2/filecheck.c | 26 +-
> 1 file changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2/filecheck.c
> index 0b41967..00
Hello Goldwyn,
Please see my comments inline.
Thanks
Gang
>>>
> From: Goldwyn Rodrigues
>
> Check that the entriy exists and has been filed for check.
> Also perform some code cleanup
>
> Signed-off-by: Goldwyn Rodrigues
> ---
> fs/ocfs2/filecheck.c | 41 +
Hello Goldwyn,
>>>
>
> On 05/30/2016 04:45 AM, Gang He wrote:
>> Hello Goldwyn,
>>
>> Please see my comments inline.
>>
>>
>> Thanks
>> Gang
>>
>>
>>>>>
>>> From: Goldwyn Rodrigues
>>
>>>
>
> On 05/30/2016 02:53 AM, Gang He wrote:
>> Hello Goldwyn,
>>
>> Thanks for your code, my comments are inline.
>>
>>
>>>>>
>>> From: Goldwyn Rodrigues
>>>
>>> This adds /sys/fs/ocfs2/ to the sys f
>>>
>
> On 05/30/2016 04:23 AM, Gang He wrote:
>> Hello Goldwyn,
>>
>> Please see my comments inline.
>> I just suggest to re-use the existing code as most as possible, since the
> code was tested by us.
>>
>> Thanks
>> Gang
>&
>>>
>
> On 05/31/2016 09:05 PM, Gang He wrote:
>> Hello Goldwyn,
>>
>>
>>>>>
>>
>>>
>>> On 05/30/2016 04:45 AM, Gang He wrote:
>>>> Hello Goldwyn,
>>>>
>>>> Please see my comments inl
>>>
>
> On 05/31/2016 10:16 PM, Gang He wrote:
>>
>>
>>
>>>>>
>>
>>>
>>> On 05/30/2016 04:23 AM, Gang He wrote:
>>>> Hello Goldwyn,
>>>>
>>>> Please see my comments inli
>>>
>
> On 06/01/2016 10:06 PM, Gang He wrote:
>>
>>
>>
>>>>>
>>
>>>
>>> On 05/31/2016 09:05 PM, Gang He wrote:
>>>> Hello Goldwyn,
>>>>
>>>>
>>>>>&
>>>
>
> On 06/01/2016 11:26 PM, Gang He wrote:
>>
>>
>>
>>>>>
>>
>>>
>>> On 06/01/2016 10:06 PM, Gang He wrote:
>>>>
>>>>
>>>>
>>>>>>>
>>>>
>>&g
Hi Goldwyn,
I have no more comments, let's discuss when your update code is finished.
Thanks
Gang
>>>
>
> On 06/02/2016 11:45 PM, Gang He wrote:
>>
>>
>>>>>>>>>>> int ocfs2_filecheck_add_inode(struct ocfs2_super *osb,
&
Hello Junxiao,
I think this change will bring a performance improvement, but from the function
comments
/*
* JBD Might read a cached version of another nodes journal file. We
* don't want this as this file changes often and we get no
* notification on those changes. The only way to be sure tha
Hello Guys,
Here is a BUG() assert in ocfs2_read_blocks_sync() function in buffer_head_io.c,
101 int ocfs2_read_blocks_sync(struct ocfs2_super *osb, u64 block,
102unsigned int nr, struct buffer_head *bhs[])
103 {
...
140 lock_buffer(bh);
141
CATCH_BH_JBD_RACES to wrap BUG() in
the ocfs2_read_blocks_sync function like before.
2) disable the macro CATCH_BH_JBD_RACES in Makefile by default.
Signed-off-by: Gang He
---
fs/ocfs2/Makefile | 2 --
fs/ocfs2/buffer_head_io.c | 5 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a
Hello Guys,
The code change is here,
https://oss.oracle.com/pipermail/ocfs2-devel/2016-June/012291.html
Please help to review, it is not a serious problem, but it is time to address
it.
Since our customer (EMC) is encountering this panic during a high-load
(SPECsfs2014) stress testing.
Than
Reviewed-by: Gang He
Thanks
Gang
>>>
> The testcase "mmaptruncate" in ocfs2 test suite always fails with
> ENOSPC error on small volume (say less than 10G). This testcase
> creates 2 threads T1/T2 which race to "truncate"/"extend" a same
> f
Hello Mark,
>>>
> On Thu, Jul 28, 2016 at 02:05:56PM -0700, Andrew Morton wrote:
>> From: Gang He
>> Subject: ocfs2: ensure that dlm lockspace is created by kernel module
>>
>> We encountered a bug from the customer, the user did a fsck.ocfs2 on the
>
Hello Guys,
Our customer is asking one question, how to detect a ocfs2 file system
fragmentation status.
Current, I can think of ways for detecting fragmentation as below,
1) o2info --freefrag N /dev/vdb3
this command can give some information for how many free chunks (based on size)
are here,
b
ation
> ratio.
> We have encountered a problem that once volume usage exceeds 95%, create
> a new big file will consume much longer time, which is because of each
> gd in chains has little contiguous clusters.
>
> Thanks,
> Joseph
>
>
> On 2016/8/11 14:03, Gang He
Reviewed-by: Gang He
Thanks
Gang
>>>
> The testcase "mmaptruncate" of ocfs2-test deadlocked occasionally.
>
> In this testcase, we create a 2*CLUSTER_SIZE file and mmap() on it;
> there are 2 process repeatedly performing the following operations
>
Hello Guys,
If you use debugfs.ocfs2 to list system files for a ocfs2 file system, you can
find these two system files.
sles12sp1-node1:/ # debugfs.ocfs2 /dev/sdb1
debugfs.ocfs2 1.8.2
debugfs: ls //
6 16 12 .
6 16 22 ..
7 24 10 1 bad
Hello Junxiao and Joseph,
Thank for your confirm.
-Gang
>>>
> Hi Gang,
> GLOBAL_INODE_ALLOC_SYSTEM_INODE is used for system file inodes
> allocation, you can refer mkfs.c for details.
>
> Thanks,
> Joseph
>
> On 2016/10/9 16:47, Gang He wrote:
>> Hell
Hi Zhen,
This should be file system consistency issue between inode in memory and inode
in disk,
You should look at the code that modify the file size in memory, and then
whether the code also sync the change to the disk.
Thanks
Gang
>>>
> Hi all,
>
> Any one ever see this BUG_ON() asse
Hi Eric,
Looks good for me.
Just one suggestion,
please monitor if the LVB sharing mechanism in the cluster still works well in
the normal scenario,
to avoid any performance decrease regression problem.
Reviewed-by: Gang He
Thanks
Gang
>>>
> The crash happens rather often w
move some data structure definitions to the header file;
2) tune mlog message level from ERROR to NOTICE;
3) add file check duplicative ino number check;
4) the other miscellaneous.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 360 ---
fs/
Embed kobject in ocfs2_super structure, then we can use container_of
method to get our own data pointor via kobject pointer. Second, I adjust
the related code in create/remove online file check sysfs entry.
Signed-off-by: Gang He
---
fs/ocfs2/ocfs2.h | 8
fs/ocfs2/super.c | 27
fixes during this code refactoring. Second, the code change does not affect
the underlying file check code.
Thank Goldwyn very much.
Gang He (2):
ocfs2: add kobject for online file check
ocfs2: embed kobject in ocfs2_super structure
fs/ocfs2/filecheck.c
the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gang-He/ocfs2-add-kobject-for-online-file-check/20161219-181858
config: x86_64-randconfig-x000-201651 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reprodu
Hi Fengguang and all,
I will reconstruct my patch set, to make sure each patch can follow this rule.
Thanks
Gang
>>> Fengguang Wu 2016-12-20 上午 9:47 >>>
Hi Gang,
On Mon, Dec 19, 2016 at 06:43:48PM -0700, Gang He wrote:
>Hello Kbuild,
>Could you build my whole patch set
Use embedded kobject mechanism for online file check feature,
this will avoid to use a global list to save/search per-device
online file check related data. The changed code is based on
Goldwyn Rodrigues's patches and ext4 fs code.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c
First, move setting fe_done = 1 in spin lock, avoid bring
any potential race condition. Second, tune mlog message level
from ERROR to NOTICE, since the message should not belong to
error message.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 8
1 file changed, 4 insertions(+), 4
small fixes during
this code refactoring. Second, the code change does not affect
the underlying file check code.
Thank Goldwyn very much.
Compare with first version, split the code change into four
patches, make sure each patch will not bring ocfs2 kernel
modules compiling errors.
Gang He (4):
Add duplicative ino number check, to avoid adding a file into the
file check list when this file is being checked.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2
Move some definitions to header file, which will be referenced
by other source files when kobject mechanism is introduced.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 27 ---
fs/ocfs2/filecheck.h | 27 +++
2 files changed, 27 insertions
>>>
> Hi Gang, one small comment below:
>
> On Wed, Dec 21, 2016 at 2:20 AM, Gang He wrote:
>> First, move setting fe_done = 1 in spin lock, avoid bring
>> any potential race condition. Second, tune mlog message level
>> from ERROR to NOTICE, since the m
Hi Changwei,
Did you get this kernel crash file?
Could you paste longer syslog before crash (e.g. 100 ~ 200 lines) via crash
tool?
e.g.
crash vmlinux-4.4.21-69-default.gz vmcore
crash> log
Thanks
Gang
>>>
> Hi,
>
> We encountered a crash issue days ago.
>
> The call trace follows as bel
fix this dismatch problem.
Second, also move printing ocfs2_fill_super() errno to the front
of ocfs2_dismount_volume() function, since ocfs2_dismount_volume()
will also print it's own message.
Signed-off-by: Gang He
---
fs/ocfs2/super.c | 8 ++--
1 file changed, 6 insertions(+), 2 dele
Hello Russell,
I just went through the bug description from the link below,
Could you always meet this issue in your testing environment? since it looks
like a simple direct write.
Second, could you describe the whole reproduce steps in details or provide a
testing script which can make this bu
he failure cause if there is a error printing.
Also, I think there is not possible to add this errorno in o2cb path during
ocfs2_dlm_init, since o2cb code has been stable for
a long time.
Thanks
Gang
>
> Thanks,
> Joseph
>
> On 17/5/18 14:35, Gang He wrote:
>> This pa
er we can tell the user the reason is there is a cluster name
dismatch between on disk and on the running cluster environment.
Thanks
Gang
>
> Thanks,
> Joseph
>
> On 17/5/18 18:43, Gang He wrote:
>> Hi Joseph,
>>
>>
>>>>>
>>> Hi Gang,
stack, the user will not
meet this error.
Signed-off-by: Gang He
---
fs/ocfs2/super.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index ca1646f..fc25d4a 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1208,14 +12
Hello Dan,
Thank for your reporting.
I will send the patch for fixing this warning.
Thanks
Gang
>>>
> Hello Gang He,
>
> The patch d56a8f32e4c6: "ocfs2: check/fix inode block for online file
> check" from Mar 22, 2016, leads to the following static checker
This patch will fix a static checker warning, this warning was
caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after
apply this patch, the error return value will not be NULL(zero).
Signed-off-by: Gang He
---
fs/ocfs2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
of stackglue, we need to get ocfs2_stack_lock lock
before using ocfs2_stack related data structures, and that
active_stack pointer can be NULL in case mount failure.
Signed-off-by: Gang He
---
fs/ocfs2/dlmglue.c | 2 +-
fs/ocfs2/stackglue.c | 6 --
fs/ocfs2/stackglue.h | 3 ---
3 files changed
Hi Dan,
What static checker tool did you use? could you paste the detailed warning
message to the list too?
Since I need to write this information into the patch comments due to Andrew
Morton's suggestion.
Thanks a lot.
Gang
>>>
> Hello Gang He,
>
> The patch d56a
e error return value will not be NULL(zero).
Signed-off-by: Gang He
---
fs/ocfs2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 382401d..1a1e007 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -136,7 +136,7 @@ struct
strict consistent with before the commit
d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check"), although
it is very difficult to meet this problem in the real environment.
Thanks
Gang
>>>
> On Tue, 23 May 2017 13:17:14 +0800 Gang He wrote:
>
>&g
Move some definitions to header file, which will be referenced
by other source files when kobject mechanism is introduced.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 27 ---
fs/ocfs2/filecheck.h | 27 +++
2 files changed, 27 insertions
hange into four
patches, make sure each patch will not bring ocfs2 kernel
modules compiling errors.
Gang He (4):
ocfs2: move some definitions to header file
ocfs2: fix some small problems
ocfs2: add kobject for online file check
ocfs2: add duplicative ino number check
fs/ocfs2/filech
case.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2/filecheck.c
index cc7b595..4347727 100644
--- a/fs/ocfs2/filecheck.c
+++ b/fs/ocfs2/filecheck.c
@@ -288,7 +288,7 @@ int
code.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 301 +++
fs/ocfs2/filecheck.h | 20 ++--
fs/ocfs2/ocfs2.h | 8 ++
fs/ocfs2/super.c | 27 -
4 files changed, 152 insertions(+), 204 deletions(-)
diff --git a/fs/ocfs2/filecheck.c
Add duplicative ino number check, to avoid adding a file into the
file check list when this file is being checked.
Signed-off-by: Gang He
---
fs/ocfs2/filecheck.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2
Hello Jim,
>>>
> I am interested in using a DLM for my user mode application and have been
> examining the ocfs2 DLM. I have been experimenting with the o2dlm_test code
> and have noticed an issue with the trylock command. When I start the o2dlm
> code with no options, it is operating in clas
Base on your description, this case should be a corner case, NOT a fatal error.
Should we use mlog(ML_NOTICE, ...) to print these logs?
Thanks
Gang
>>>
> Hi,
>
> In current code, while flushing AST, we don't handle an exception that
> sending AST or BAST is failed.
> But it is indeed possible
>>>
>
> On 17/8/23 10:23, Junxiao Bi wrote:
>> On 08/10/2017 06:49 PM, Changwei Ge wrote:
>>> Hi Joseph,
>>>
>>>
>>> On 2017/8/10 17:53, Joseph Qi wrote:
Hi Changwei,
On 17/8/9 23:24, ge changwei wrote:
> Hi
>
>
> On 2017/8/9 下午7:32, Joseph Qi wrote:
>> Hi,
Hello Guys,
This is a little tricky problem.
When the user modifies a character in a meta-block, the hamming code can repair
this block when reading this block in fsck tool,
so fsck tool can not detect this disk block inconsistent problem.
But debugfs tool reads meta blocks without using meta-ec
Hello Yang,
Thanks for code submit.
But, could you follow the Linux kernel patch format rule?
How to submit a kernel patch, you can refer the doc
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ozlabs.org_-7Eakpm_stuff_tpp.txt&d=DwIFAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=f4oh
>>>
> Hi,
>
> We'd better not add a white space at the tail of a line, so trim it!
>
> Thanks,
> Changwei
>
> Signed-off-by: Changwei Ge
> ---
> fs/ocfs2/cluster/tcp.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 fs/ocfs2/cluster/tcp.c
>
>
** PRIVATE **
Hello guys,
As you know, some Linux distributions(e.g. SUSE Enterprise Linux 15) will
introduce Python3 as the default,
our Python scripts in ocfs2-test still use Python2, we will have to do proper
modifications to migration to Python3 (Larry Chen has worked on this
investigati
>>>
> Hi,
>
>> As you know, some Linux distributions(e.g. SUSE Enterprise Linux 15) will
> introduce Python3 as the default,
>> our Python scripts in ocfs2-test still use Python2, we will have to do
> proper modifications to migration to Python3 (Larry Chen has worked on this
> investigatio
Hello list,
We got a o2cb DLM problem from the customer, which is using o2cb stack for
OCFS2 file system on SLES12SP1(3.12.49-11-default).
The problem description is as below,
Customer has three node oracle rack cluster
gal7gblr2084
gal7gblr2085
gal7gblr2086
On each node they have configured tw
1 - 100 of 257 matches
Mail list logo
