On Wed 05-03-08 10:41:34, Sunil Mushran wrote:
> Jan Kara wrote:
>> Actually, it's non-trivial to measure (differently than by profiling).
>> You cannot use standard time functions because they have too low
>> resolution
>> - we are speaking about microsecond
es mean hash chains of
average length 61 on x86_64. It is not ideal but I guess it should be
sufficient.
Honza
> Jan Kara wrote:
>> Hello,
>>
>> because SLES10 SP2 is closer than I thought, I've writte
es. Four for
> the price of one!
>
> Could you try this out confirm this fixes the problem for you?
> (Currently it only passes the "It builds, ship it!" test, but it's
> pretty straightforward; and I'm on an airplane at the moment. :-)
The
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index f38a5af..ff5b789 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1018,8 +1018,7 @@ stat
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
include/linux/quotaops.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h
index f7dcc30..94f00ec 100644
--- a/include/linux/quotaops.h
+++ b/include/linux/quot
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext4/super.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 566344b..4a0a693 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1185,8 +1185,7 @@ stat
Some filesystems would like to keep private information together with each
dquot. Add callbacks alloc_dquot and destroy_dquot allowing filesystem to
allocate larger dquots from their private slab in a similar fashion we
currently allocate inodes.
Signed-off-by: Jan Kara <[EMAIL PROTEC
Hello,
in the following emails will come implementation of quota support for OCFS2.
First 17 patches are actually necessary changes to generic VFS quota, next 10
patches implement support for OCFS2.
I'm sending the patches just for review and comments. Any comments, bug reports,
fixes welcome :).
going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 222 ---
-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c| 45 ++---
fs/quota.c|3 +++
include/linux/quota.h |7 +++
3 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index b
filesystems if they decide to use VFS quotas.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 36
include/linux/quotaops.h |3 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index c
On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
Thus checks for !handle are wrong. Fix them to use IS_ERR().
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/file.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --gi
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/journal.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index d318c7e..6bf9de4 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8
track of a state which has been suspended.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 10 ++
include/linux/quotaops.h |6 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index e95ad55..aea7bf9 100644
--
ables.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c|6 --
include/linux/quota.h |3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 904bd67..f4258fe 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -845,7 +845,
OCFS2 needs to peek whether quota structure is already in memory so
that it can avoid expensive cluster locking in that case. Similarly
when freeing dquots, it checks whether it is the last quota structure
user or not.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/d
We forgot to set i_nlink to 0 when returning due to error from
ocfs2_mknod_locked()
and thus inode was not properly released via ocfs2_delete_inode() (e.g. claimed
space was not released). Fix it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/namei.c |4 +++-
1 files chan
new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
checking of the return value.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/namei.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index d
dquot->dq_flags which entries have been set by SETQUOTA
and quota format can clear these flags when it properly propagated
the changes.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c| 12 ++--
include/linux/quota.h | 26 --
2 file
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h
configurable so
that the code can be shared.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/Kconfig |5 +
fs/Makefile |1 +
fs/quota_tree.c | 642 +++
fs/quota_tree.h | 25 ++
fs/qu
Checks like <= 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c
Add quota calls for allocation and freeing of inodes and space, also update
estimates on number of needed credits for a transaction. Move out inode
allocation from ocfs2_mknod_locked() because vfs_dq_init() must be called
outside of a transaction.
Signed-off-by: Jan Kara <[EMAIL PROTEC
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 50 ++-
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/inode.c|2 ++
fs/ocfs2/ocfs2_fs.h | 23 ---
fs/ocfs2/super.c| 17 +
3 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 7
Mark system files as not subject to quota accounting. This prevents
possible recursions into quota code and thus deadlocks.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/inode.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs
This patch implements functions and timer setup which handles periodic
syncing of locally cached quota information to global quota file.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/quota.h|3 ++
fs/ocfs2/quota_global.c
ff-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v2.c| 49 ++
include/linux/dqblk_v1.h |4 ---
include/linux/dqblk_v2.h |4 ---
include/linux/quota.h|5 +---
4 files changed, 33 insertions(+), 29 deletions(-)
diff
On Tue 21-10-08 10:29:57, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:36PM +0200, Jan Kara wrote:
> > Checks like <= 0 for an unsigned type do not make much sence. The value
> > could be only 0 and that does not happen often enough for the check
> > to be worth it.
On Tue 21-10-08 13:26:18, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:51PM +0200, Jan Kara wrote:
> > On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
> > Thus checks for !handle are wrong. Fix them to use IS_ERR().
> >
> > Signed-off-by:
On Tue 21-10-08 13:32:10, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:52PM +0200, Jan Kara wrote:
> > OCFS2 can easily support nested transactions. We just have to
> > take care and not spoil statistics acquire semaphore unnecessarily.
>
> I'm guessing this
On Tue 21-10-08 13:43:18, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:55PM +0200, Jan Kara wrote:
> > Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
>
> This patch actually looks fine except for one thing:
>
> > diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs
On Tue 21-10-08 13:35:03, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:53PM +0200, Jan Kara wrote:
> > new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
> > checking of the return value.
> >
> > Signed-off-by: Jan Kara <[EMAIL PRO
On Tue 21-10-08 13:22:16, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:49PM +0200, Jan Kara wrote:
> > OCFS2 needs to peek whether quota structure is already in memory so
> > that it can avoid expensive cluster locking in that case. Similarly
> > when freeing dquots, it
On Tue 21-10-08 16:51:55, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:59PM +0200, Jan Kara wrote:
> > Enable quota usage tracking on mount and disable it on umount. Also
> > add support for quota on and quota off quotactls and usrquota and
> > grpquota mount options.
&
On Tue 21-10-08 16:10:46, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:57PM +0200, Jan Kara wrote:
> > Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
>
> The commit message could maybe use a little discussion of what
> quota bits go in the local file and what
On Tue 21-10-08 16:34:46, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:58PM +0200, Jan Kara wrote:
> > Add quota calls for allocation and freeing of inodes and space, also update
> > estimates on number of needed credits for a transaction. Move out inode
>
s and
probably won't get to it so I'm just reporting them.
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SUSE Labs, CR
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
ht
Hello,
the following patch series implements quotas for OCFS2. The patch
series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next
I've adressed Joel's comments, also node recovery is now fully working
and I've fixed a few issues I found during my testing. So
Oops, and now really the patch series... Sorry for the bad post.
Honza
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Some filesystems would like to keep private information together with each
dquot. Add callbacks alloc_dquot and destroy_dquot allowing filesystem to
allocate larger dquots from their private slab in a similar fashion we
currently allocate inodes.
Signed-off-by: Jan Kara <[EMAIL PROTEC
track of a state which has been suspended.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 10 ++
include/linux/quotaops.h |6 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 9eda830..46d46df 100644
--
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 50 ++-
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index d318c7e..6bf9de4 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext4/super.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index dea8f13..ab8b8a1 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1206,8 +1206,7 @@ stat
ables.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c|6 --
include/linux/quota.h |3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 5b82722..9d2a1f0 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -845,7 +845,
going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 222 ---
Checks like <= 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
include/linux/quotaops.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h
index f7dcc30..94f00ec 100644
--- a/include/linux/quotaops.h
+++ b/include/linux/quot
dquot->dq_flags which entries have been set by SETQUOTA
and quota format can clear these flags when it properly propagated
the changes.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c| 12 ++--
include/linux/quota.h | 26 --
2 file
-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c| 45 ++---
fs/quota.c|3 +++
include/linux/quota.h |7 +++
3 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 9
quota type when recovering quota file after crash.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 38 --
include/linux/quotaops.h |4
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
checking of the return value.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/namei.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 4
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/journal.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/inode.c|2 ++
fs/ocfs2/ocfs2_fs.h | 23 ---
fs/ocfs2/super.c| 17 +
3 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 4
On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
Thus checks for !handle are wrong. Fix them to use IS_ERR().
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/file.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --gi
We forgot to set i_nlink to 0 when returning due to error from
ocfs2_mknod_locked()
and thus inode was not properly released via ocfs2_delete_inode() (e.g. claimed
space was not released). Fix it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/namei.c |4 +++-
1 files chan
This patch implements functions and timer setup which handles periodic
syncing of locally cached quota information to global quota file.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/quota.h|3 ++
fs/ocfs2/quota_global.c
Add quota calls for allocation and freeing of inodes and space, also update
estimates on number of needed credits for a transaction. Move out inode
allocation from ocfs2_mknod_locked() because vfs_dq_init() must be called
outside of a transaction.
Signed-off-by: Jan Kara <[EMAIL PROTEC
Hello,
attached is a patch which implements necessary support for
mkfs so that quota files can be created.
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SUSE Labs, CR
>From c5de88cee9136605dc64f943aa31d2ebdd9bd8c7 Mon Sep 17 00:00:00
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 399a96a..12c2e22 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1018,8 +1018,7 @@ stat
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/journal.c | 20 -
fs/ocfs2/ocfs2.h |3 +
fs/ocfs2/super.c
ff-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v2.c| 53 +
include/linux/dqblk_v1.h |4 ---
include/linux/dqblk_v2.h |4 ---
include/linux/quota.h|5 +---
4 files changed, 35 insertions(+), 31 deletions(-)
diff --git a/
OCSF2 will need to queue up work for periodic syncing of quotas
among nodes in the cluster. pdflush() is good thread for this so
export it's controlling function so that OCFS2 can use it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
mm/pdflush.c |1 +
1 files changed, 1 inser
Mark system files as not subject to quota accounting. This prevents
possible recursions into quota code and thus deadlocks.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/inode.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs
Implement functions for recovery after a crash. Functions just
read local quota file and sync info to global quota file.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/journal.c | 105 +---
fs/ocfs2/journal.h |1 +
fs/ocfs2/ocfs2.h|4 +-
fs
filesystems if they decide to use VFS quotas.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 36
include/linux/quotaops.h |3 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index f
block (needed for
checksumming) and structures contained in them configurable
so that the code can be shared.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/Kconfig |5 +
fs/Makefile |1 +
fs/quota_tree.c
On Wed 22-10-08 10:31:49, Joel Becker wrote:
> On Wed, Oct 22, 2008 at 04:49:00PM +0200, Jan Kara wrote:
> > On Tue 21-10-08 16:34:46, Joel Becker wrote:
> > > On Mon, Oct 20, 2008 at 07:23:58PM +0200, Jan Kara wrote:
> > > > Add quota calls for allocation and fre
On Fri 24-10-08 15:40:25, Joel Becker wrote:
> On Fri, Oct 24, 2008 at 11:57:02PM +0200, Jan Kara wrote:
> > while playing with quota support I found two bugs in OCFS2 mount/umount
> > code. The first problem is, that if mount fails, we call
> > ocfs2_dismount_volume(). T
On Sat 25-10-08 00:10:22, Jan Kara wrote:
> Hello,
>
> attached is a patch which implements necessary support for
> mkfs so that quota files can be created.
As Mark pointed to me, the patch missed the libocfs2/quota.c
file. So a fixed patch
On Mon 27-10-08 17:08:54, tristan.ye wrote:
> On Sat, 2008-10-25 at 00:05 +0200, Jan Kara wrote:
> > Hello,
> >
> > the following patch series implements quotas for OCFS2. The patch
> > series is based on:
> > git://git.kernel.org/pub/scm/linux/kernel/git/mfas
On Tue 28-10-08 12:36:52, Joel Becker wrote:
> On Sat, Oct 25, 2008 at 12:08:18AM +0200, Jan Kara wrote:
> > For each quota type each node has local quota file. In this file it stores
> > changes users have made to disk usage via this node. Once in a while this
> > informatio
On Tue 28-10-08 12:11:03, Joel Becker wrote:
> On Sat, Oct 25, 2008 at 12:08:22AM +0200, Jan Kara wrote:
> > Enable quota usage tracking on mount and disable it on umount. Also
> > add support for quota on and quota off quotactls and usrquota and
> > grpquota mount options.
&
On Tue 28-10-08 15:16:06, Joel Becker wrote:
> On Sat, Oct 25, 2008 at 12:08:16AM +0200, Jan Kara wrote:
> > diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
> > index f24ce3d..dd17137 100644
> > --- a/fs/ocfs2/ocfs2_fs.h
> > +++ b/fs/ocfs2/oc
s quota limit grace files quota limit
> grace
> /dev/sdc5 1056* 10242048 6days 2 100
> 200
>
> is that strange?
Yup, I see the bug. Thanks for report. I'll fix it.
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SUSE Labs, CR
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
On Wed 29-10-08 15:58:32, Mark Fasheh wrote:
> On Sat, Oct 25, 2008 at 12:05:04AM +0200, Jan Kara wrote:
> > Hello,
> >
> > the following patch series implements quotas for OCFS2. The patch
> > series is based on:
> > git://git.kernel.org/pub/scm/linux/kernel
On Wed 29-10-08 16:09:34, Mark Fasheh wrote:
> On Sat, Oct 25, 2008 at 12:08:03AM +0200, Jan Kara wrote:
> > If filesystem can handle quota files as system files hidden from users, we
> > can
> > skip a lot of cache invalidation, syncing, inode flags setting etc. when
>
On Wed 29-10-08 03:51:39, Joel Becker wrote:
> On Wed, Oct 29, 2008 at 03:29:02AM +0100, Jan Kara wrote:
> > > > +/* Structure with global user / group information. We reserve some
> > > > space
> > > > + * for future use. */
> > > > +struct ocfs
On Thu 30-10-08 13:31:21, Joel Becker wrote:
> On Thu, Oct 30, 2008 at 08:33:39AM +0100, Jan Kara wrote:
> > On Wed 29-10-08 03:51:39, Joel Becker wrote:
> > > On Wed, Oct 29, 2008 at 03:29:02AM +0100, Jan Kara wrote:
> > > > What I did is, that in the end of ea
On Thu 30-10-08 16:52:34, Mark Fasheh wrote:
> On Sat, Oct 25, 2008 at 12:08:15AM +0200, Jan Kara wrote:
> > We forgot to set i_nlink to 0 when returning due to error from
> > ocfs2_mknod_locked()
> > and thus inode was not properly released via ocfs2_delete_inode() (e.g.
Some filesystems would like to keep private information together with each
dquot. Add callbacks alloc_dquot and destroy_dquot allowing filesystem to
allocate larger dquots from their private slab in a similar fashion we
currently allocate inodes.
Signed-off-by: Jan Kara <[EMAIL PROTEC
Checks like <= 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -
track of a state which has been suspended.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 10 ++
include/linux/quotaops.h |6 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 735e2c3..1f9f1f1 100644
--
Hi,
in this thread comes the third version of the patches implementing quotas for
OCFS2 (sorry for spamming ocfs2-devel so often with such a big pile of patches
;). I've now addressed all Joel's comments (feature bits added among supported
bits in the last patch, hopefully fixed an oops when enabl
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 18eaa78..6078bd3 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1031,8 +1031,7 @@ stat
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 50 ++-
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ext4/super.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index bdddea1..be34b66 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1139,8 +1139,7 @@ stat
-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c| 45 ++---
fs/quota.c|3 +++
include/linux/quota.h |7 +++
3 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index a
ables.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c|6 --
include/linux/quota.h |3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index f4d6f7e..cf0dac7 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -847,7 +847,
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h
going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/dquot.c | 222 ---
ff-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/quota_v2.c| 53 +
include/linux/dqblk_v1.h |4 ---
include/linux/dqblk_v2.h |4 ---
include/linux/quota.h|5 +---
4 files changed, 35 insertions(+), 31 deletions(-)
diff --git a/
Increase reported version number of quota support since quota core has changed
significantly. Also remove __DQUOT_NUM_VERSION__ since nobody uses it.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
include/linux/quota.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff -
block (needed for
checksumming) and structures contained in them configurable
so that the code can be shared.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/Kconfig |5 +
fs/Makefile |1 +
fs/quota_tree.c
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/ocfs2/journal.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs
Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 663a91f..a9b393a 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8
1 - 100 of 712 matches
Mail list logo
