Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a potential deadlock in dlm_reset_mleres_owner()

2017-12-21 Thread alex chen
Hi Joseph and Changwei, On 2017/12/22 11:17, Joseph Qi wrote: > > > On 17/12/22 10:34, Changwei Ge wrote: >> On 2017/12/21 14:36, alex chen wrote: >>> Hi Joseph, >>> >>> On 2017/12/21 9:30, Joseph Qi wrote: Hi Alex, On 17/12/21 08:55, alex chen wrote: > In

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a potential deadlock in dlm_reset_mleres_owner()

2017-12-21 Thread Joseph Qi
On 17/12/22 10:34, Changwei Ge wrote: > On 2017/12/21 14:36, alex chen wrote: >> Hi Joseph, >> >> On 2017/12/21 9:30, Joseph Qi wrote: >>> Hi Alex, >>> >>> On 17/12/21 08:55, alex chen wrote: In dlm_reset_mleres_owner(), we will lock dlm_lock_resource->spinlock after locking

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a potential deadlock in dlm_reset_mleres_owner()

2017-12-21 Thread Changwei Ge
On 2017/12/21 14:36, alex chen wrote: > Hi Joseph, > > On 2017/12/21 9:30, Joseph Qi wrote: >> Hi Alex, >> >> On 17/12/21 08:55, alex chen wrote: >>> In dlm_reset_mleres_owner(), we will lock >>> dlm_lock_resource->spinlock after locking dlm_ctxt->master_lock, >>> which breaks the spinlock lock

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a potential deadlock in dlm_reset_mleres_owner()

2017-12-20 Thread alex chen
Hi Joseph, On 2017/12/21 9:30, Joseph Qi wrote: > Hi Alex, > > On 17/12/21 08:55, alex chen wrote: >> In dlm_reset_mleres_owner(), we will lock >> dlm_lock_resource->spinlock after locking dlm_ctxt->master_lock, >> which breaks the spinlock lock ordering: >> dlm_domain_lock >> struct

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a potential deadlock in dlm_reset_mleres_owner()

2017-12-20 Thread Joseph Qi
Hi Alex, On 17/12/21 08:55, alex chen wrote: > In dlm_reset_mleres_owner(), we will lock > dlm_lock_resource->spinlock after locking dlm_ctxt->master_lock, > which breaks the spinlock lock ordering: > dlm_domain_lock > struct dlm_ctxt->spinlock > struct dlm_lock_resource->spinlock > struct