Re: [OctDev] Impulse invariance transform implementation

2011-10-14 Thread Carnë Draug
2011/10/12 Rudy Eschauzier : > Hi Carnë, > > Looking into it some more, I found that even setting small values in the > output polynomials to zero is an error. We need to remove lines like this: > > b_out(abs(b_out) a_out(abs(a_out) > The reason is that the tolerance applies to the positions of the

Re: [OctDev] Impulse invariance transform implementation

2011-10-12 Thread Rudy Eschauzier
Hi Carnë, Looking into it some more, I found that even setting small values in the output polynomials to zero is an error. We need to remove lines like this: b_out(abs(b_out) [b a]=impinvar([1], [1, 2, 1], 100) b =    0   0 a =    1.0  -1.98010   0.98020 Note how the coefficients of b a

Re: [OctDev] Impulse invariance transform implementation

2011-10-11 Thread Rudy Eschauzier
Eschauzier Cc: Juan Manuel Parrilla Gutiérrez ; "octave-dev@lists.sourceforge.net" Sent: Tuesday, October 11, 2011 2:59 PM Subject: Re: [OctDev] Impulse invariance transform implementation Ok. I had just followed the examples on this page http://www.uccs.edu/~cfelton/ece5655/chp8_matl

Re: [OctDev] Impulse invariance transform implementation

2011-10-11 Thread Carnë Draug
2011/10/11 Rudy Eschauzier : > Hi Carnë, > Yes, I am very sure. In fact, removing zero and near-zero elements > introduces a bug. Note how both a_out and b_out are polynomials. Taking an > element out, will shift the polynomial weights to the next power, messing up > the entire polynomial. The resu

Re: [OctDev] Impulse invariance transform implementation

2011-10-11 Thread Rudy Eschauzier
. From: Carnë Draug To: Rudy Eschauzier Cc: Juan Manuel Parrilla Gutiérrez ; "octave-dev@lists.sourceforge.net" Sent: Tuesday, October 11, 2011 1:14 PM Subject: Re: [OctDev] Impulse invariance transform implementation 2011/10/10 Rudy Eschauzier : > Attached are updated

Re: [OctDev] Impulse invariance transform implementation

2011-10-11 Thread Carnë Draug
2011/10/10 Rudy Eschauzier : > Attached are updated files for the impulse invariance transform and its > inverse. I have also attached a diff file against the current svn revision. > > These are the changes: > -impinvar and invimpinvar now include test cases. > -bug fixes > -code optimization (vect

Re: [OctDev] Impulse invariance transform implementation

2011-10-10 Thread Rudy Eschauzier
Attached are updated files for the impulse invariance transform and its inverse. I have also attached a diff file against the current svn revision. These are the changes: -impinvar and invimpinvar now include test cases. -bug fixes -code optimization (vectorization) Please let me know if you hav

Re: [OctDev] Impulse invariance transform implementation

2011-10-01 Thread Carnë Draug
2011/10/1 Rudy Eschauzier : >> Plus, h1_deriv takes ts as argument but doesn't do anything with it. >> Is something missing one the code? > > This is probably a leftover from earlier experimentation and can be removed. > > As additional background information, I tracked down the paper I used to > w

Re: [OctDev] Impulse invariance transform implementation

2011-10-01 Thread Rudy Eschauzier
> Plus, h1_deriv takes ts as argument but doesn't do anything with it. > Is something missing one the code? This is probably a leftover from earlier experimentation and can be removed. As additional background information, I tracked down the paper I used to write the code: http://www.ingelec.un

Re: [OctDev] Impulse invariance transform implementation

2011-09-30 Thread Carnë Draug
2011/9/30 Rudy Eschauzier : > Why not use invimpinvar, or iimpinvar? > Rudy. It's commited and I named it invimpinvar. I also added notes about being the inverse on the help text. With a big help from Juan Carbajal, I changed the API to take Sampling frequencies instead of sampling time (so it's

Re: [OctDev] Impulse invariance transform implementation

2011-09-30 Thread dastew
Date: Fri, 30 Sep 2011 02:59:49 -0700 From: reschauz...@yahoo.com To: carandraug+...@gmail.com; joanma...@gmail.com CC: octave-dev@lists.sourceforge.net Subject: Re: [OctDev] Impulse invariance transform implementation Why not use invimpinvar, or iimpinvar? Rudy. Inverse is usually used to

Re: [OctDev] Impulse invariance transform implementation

2011-09-30 Thread Rudy Eschauzier
Why not use invimpinvar, or iimpinvar? Rudy. > I'll wait 3 days or until someone suggests a name for c2d_imp before > making the commit. > > Carnë-- All of the data generated in your IT infrastructure is seriously valuab

Re: [OctDev] Impulse invariance transform implementation

2011-09-29 Thread Carnë Draug
2011/9/29 Juan Manuel Parrilla Gutiérrez : > Hi, > thank you for your answer. I hope the new function will be in octave asap :) > also, I guess you would keep matlab's name? If anything, it will be in the octave-forge (not in octave) signal package. I guess we can make a new release of the package

Re: [OctDev] Impulse invariance transform implementation

2011-09-29 Thread Juan Manuel Parrilla Gutiérrez
; > To: Rudy Eschauzier > > Cc: Juan Manuel Parrilla Gutiérrez ; > > "octave-dev@lists.sourceforge.net" > > Sent: Thursday, September 29, 2011 4:10 PM > > Subject: Re: [OctDev] Impulse invariance transform implementation > > > > > > we can i

Re: [OctDev] Impulse invariance transform implementation

2011-09-29 Thread Carnë Draug
2011/9/29 Rudy Eschauzier : > > From: Carnë Draug > To: Rudy Eschauzier > Cc: Juan Manuel Parrilla Gutiérrez ; > "octave-dev@lists.sourceforge.net" > Sent: Thursday, September 29, 2011 4:10 PM > Subject: Re: [OctDev] Impulse inva

Re: [OctDev] Impulse invariance transform implementation

2011-09-29 Thread Rudy Eschauzier
From: Carnë Draug To: Rudy Eschauzier Cc: Juan Manuel Parrilla Gutiérrez ; "octave-dev@lists.sourceforge.net" Sent: Thursday, September 29, 2011 4:10 PM Subject: Re: [OctDev] Impulse invariance transform implementation we can implement this on

Re: [OctDev] Impulse invariance transform implementation

2011-09-29 Thread Rudy Eschauzier
Hi Juan, See attached file. Please note that although I feel the algorithms used for the transform are sound, the implementation in Octave isn't the most efficient. The intention was to write a reference implementation that proves the concept and can serve as a basis for improvements. Regards

[OctDev] Impulse invariance transform implementation

2011-09-28 Thread Juan Manuel Parrilla Gutiérrez
Hi Ron, I read here https://mailman.cae.wisc.edu/pipermail/help-octave/2006-May/021065.html that you implemented impinvar among other functions. You wanted to add them to octave but 5 years later it seems that functions are not in. I'd like to use your function impinvar and maybe the octave commun

[OctDev] Impulse invariance transform implementation

2011-09-28 Thread Juan Manuel Parrilla Gutiérrez
Hi Rudy, I see here: http://comments.gmane.org/gmane.comp.gnu.octave.sources/116 that you implemented "impulse invariance transform" for octave. I'd like to use your implementation with octave. Also the octave community would be interested in adding your code. Please, reply as "reply all" in this