Re: [OctDev] Problem with commit 7538 in dilate

2011-04-29 Thread Thomas Weber
On Mon, Apr 25, 2011 at 09:06:36PM +0100, Carnë Draug wrote: > Hi > > since no one seems to know the "right answer" to the following > calculation "dilate(eye(3),[1,0,0,0])", and the one on the test was > clearly wrong, I simply commented it out. There should be no failing > tests now. Thanks for

Re: [OctDev] Problem with commit 7538 in dilate

2011-04-25 Thread Carnë Draug
Hi since no one seems to know the "right answer" to the following calculation "dilate(eye(3),[1,0,0,0])", and the one on the test was clearly wrong, I simply commented it out. There should be no failing tests now. Carnë

Re: [OctDev] Problem with commit 7538 in dilate

2011-04-17 Thread Carnë Draug
Hi I got someone to test this in MatLab for comparison. Those assertions also fail there and the new version of our image package does calculates the dilation like MatLab (except when using odd sized Structuring Elements). With a SE, 4 pixels wide MatLab considers pixel #2 the center while our ima

Re: [OctDev] Problem with commit 7538 in dilate

2011-04-13 Thread Carnë Draug
Hey, just fixed that. The assert was wrong. The dilation of eye(3) by [ 1 0 0] is [ 0 0 0 ; 1 0 0 ; 0 1 0 ] and not [ 0 1 0 ; 0 0 1 ; 0 0 0 ] as was given to assert as the right answer. But for the last assert (which seems to also fail in the new version) I don't know the right answer. It uses an