Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Johan Hedberg
Hi Denis, On Sun, Jan 17, 2010, Denis Kenzior wrote: having it as a MediaEndpoint I guess it is probably a good idea to have a similar design as we will have in endpoints, so the registration actually happen in adapter path rather than device path, which probably should avoid the having

Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Johan Hedberg
Hi Luiz, On Tue, Jan 19, 2010, Luiz Augusto von Dentz wrote: Also the problem with this being in the device path is that ofono may not be registered as an agent on connect (both ways) which will cause the connection to drop and the round trips to resolve device path only makes it worse, if

Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Luiz Augusto von Dentz
Hi Denis, On Mon, Jan 18, 2010 at 12:37 AM, Denis Kenzior denk...@gmail.com wrote: Hi Luiz, having it as a MediaEndpoint I guess it is probably a good idea to have a similar design as we will have in endpoints, so the registration actually happen in adapter path rather than device path,

Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Luiz Augusto von Dentz
Hi Johan, On Tue, Jan 19, 2010 at 12:33 PM, Johan Hedberg johan.hedb...@gmail.com wrote: Hi Luiz, On Tue, Jan 19, 2010, Luiz Augusto von Dentz wrote: Also the problem with this being in the device path is that ofono may not be registered as an agent on connect (both ways) which will cause

[RFC v2 3/7] STE-plugin: STE modem driver definition

2010-01-19 Thread sjur . brandeland
Updates after review: Removed overriding of functions. --- drivers/stemodem/stemodem.c | 53 +++ drivers/stemodem/stemodem.h | 29 +++ 2 files changed, 82 insertions(+), 0 deletions(-) create mode 100644 drivers/stemodem/stemodem.c

[RFC v2 5/7] STE-plugin: Voice-call driver.

2010-01-19 Thread sjur . brandeland
Updates after review: Use at_util_call_compare. So far, we have only done the trivial changes to voice call driver. We agree on moving more of the state logic to core, but this is complex and we need more time to discuss and look into this, particularly regarding call release. ---

[RFC v2 6/7] STE-plugin: Add CAIF header files in gcaif.

2010-01-19 Thread sjur . brandeland
Adding CAIF header files. These should be removed when CAIF is included Linux kernel. --- gcaif/caif_socket.h | 171 +++ gcaif/if_caif.h | 70 + 2 files changed, 241 insertions(+), 0 deletions(-) create mode 100644

Re: [RFC v2 0/7] STE-plugin: Second RFC on STE patch-set

2010-01-19 Thread Marcel Holtmann
Hi Sjur, This is the second RFC on the STE driver.Most review comments should be included, except for using glib for XML parsing and changes to voice-call termination. We'll have to get back to this later. we are getting to closer to something that can be merged as a first draft and then

Re: [RFC v2 3/7] STE-plugin: STE modem driver definition

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Removed overriding of functions. --- snip + +#ifdef HAVE_CONFIG_H +#include config.h +#endif + +#include glib.h +#include gatchat.h What are these two includes for? +#define OFONO_API_SUBJECT_TO_CHANGE +#include ofono/plugin.h +#include ofono/types.h

Re: [RFC v2 4/7] STE-plugin: Add STE plugin

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Added check on return value of socket() and connect() calls. Use gsm_permissive syntax all the time. Added ATE0 in initialization. snip +#ifdef HAVE_CONFIG_H +#include config.h +#endif + +#include errno.h +#include stdlib.h + +#include glib.h +#include gatchat.h +#include

Re: [RFC v2 5/7] STE-plugin: Voice-call driver.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Use at_util_call_compare. So far, we have only done the trivial changes to voice call driver. We agree on moving more of the state logic to core, but this is complex and we need more time to discuss and look into this, particularly regarding call release.

Re: [RFC v2 6/7] STE-plugin: Add CAIF header files in gcaif.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Adding CAIF header files. These should be removed when CAIF is included Linux kernel. please put them into drivers/stemodem/ instead as I explained in the other email. And make sure they are before its actual usage in the patch series. Regards Marcel

Re: [RFC v2 7/7] STE-plugin: GPRS driver.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Removed setting of IP-address, netmask etc. when creating the IP interface. Split caif_if_create_remove() into , caif_if_create() and caif_if_remove(). Declared interface as array in conn_info struct, and removed memory allocation. Removed switching of syntax