Re: [PATCH 1/1] Install default.xml file to /usr/share/phonesim

2010-03-14 Thread Marcel Holtmann
Hi Martin, > --- > Makefile.am |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) patch has been applied. Now we need phonesim to read that default.xml if no other file is specified on the command line. Regards Marcel ___ ofono mailin

[PATCH 1/1] Install default.xml file to /usr/share/phonesim

2010-03-14 Thread Martin Xu
--- Makefile.am |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index fcee5e6..34198a5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,9 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src CLEANFILES = src/control.moc $(nodist_sr

Re: [patch 5/6] IP support for PPP

2010-03-14 Thread Marcel Holtmann
Hi Kristen, > Implement IPCP support. Creates a tun interface to pass IP traffic. this is not a proper review of the patch, just some general comments I found by looking through the whole series. > === > --- ofono.orig/gatchat/gatp

Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

2010-03-14 Thread Marcel Holtmann
Hi Kristen, > Add option to use PPP to gsmdial. > > Index: ofono/gatchat/gsmdial.c > === > --- ofono.orig/gatchat/gsmdial.c 2010-03-10 16:58:09.773080389 -0800 > +++ ofono/gatchat/gsmdial.c 2010-03-10 17:06:45.071975512 -0800