Re: [PATCH] ppp: implement Max-Failure counter

2010-04-02 Thread Kristen Carlson Accardi
On Fri, 2 Apr 2010 22:27:00 -0700 Kristen Carlson Accardi wrote: > put a cap on the number of Configure-Nak packets we send. Denis - did you have a modem that just went off into a flurry of sending Configure-Naks? If so, would you mind testing this patch on it to see if this helps it accept de

[PATCH] ppp: implement Max-Failure counter

2010-04-02 Thread Kristen Carlson Accardi
put a cap on the number of Configure-Nak packets we send. --- gatchat/ppp_cp.c | 22 ++ gatchat/ppp_cp.h |1 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index cf2f5fa..5e854da 100644 --- a/gatchat/ppp_cp.c +++ b/ga

Re: [PATCH] ppp: implement net close

2010-04-02 Thread Denis Kenzior
Hi Kristen, > --- > gatchat/ppp.h |1 + > gatchat/ppp_net.c | 11 ++- > 2 files changed, 7 insertions(+), 5 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/li

[PATCH] ppp: implement net close

2010-04-02 Thread Kristen Carlson Accardi
--- gatchat/ppp.h |1 + gatchat/ppp_net.c | 11 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/gatchat/ppp.h b/gatchat/ppp.h index fa3749c..7b09fa9 100644 --- a/gatchat/ppp.h +++ b/gatchat/ppp.h @@ -105,6 +105,7 @@ struct ppp_net_data { GAtPPP *ppp;

Re: PPP LCP configuration issue

2010-04-02 Thread Kristen Carlson Accardi
On Fri, 02 Apr 2010 14:01:58 -0700 Marcel Holtmann wrote: > Hi Kristen, > > > > so I added some debug code to actually print the options during the > > > configuration stage. And something seems to be wrong here. > > > > > > lcp: pppcp_open_event: current state 0:INITIAL > > > lcp: pppcp_up_eve

Re: PPP LCP configuration issue

2010-04-02 Thread Marcel Holtmann
Hi Kristen, > > so I added some debug code to actually print the options during the > > configuration stage. And something seems to be wrong here. > > > > lcp: pppcp_open_event: current state 0:INITIAL > > lcp: pppcp_up_event: current state 1:STARTING > > lcp: pppcp_initialize_restart_count: curr

Re: PPP LCP configuration issue

2010-04-02 Thread Kristen Carlson Accardi
On Thu, 01 Apr 2010 00:25:45 -0700 Marcel Holtmann wrote: > Hi Kristen, > > so I added some debug code to actually print the options during the > configuration stage. And something seems to be wrong here. > > lcp: pppcp_open_event: current state 0:INITIAL > lcp: pppcp_up_event: current state 1:

Re: [PATCH] ppp: fix missing breaks in switchs

2010-04-02 Thread Marcel Holtmann
Hi Kristen, > --- > gatchat/ppp_cp.c |9 - > 1 files changed, 4 insertions(+), 5 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] ppp: fix missing breaks in switchs

2010-04-02 Thread Kristen Carlson Accardi
--- gatchat/ppp_cp.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index d5f7c92..cf2f5fa 100644 --- a/gatchat/ppp_cp.c +++ b/gatchat/ppp_cp.c @@ -591,7 +591,7 @@ static void pppcp_down_event(struct pppcp_data *data, guint8 *p

Re: [PATCH] ppp: use queue to transmit

2010-04-02 Thread Denis Kenzior
Hi Kristen, > Since we are using non buffered I/O, use a queue to transmit when we will > not block. This patch has been applied. Please limit your commit messages to 72 characters or less per line. Regards, -Denis ___ ofono mailing list ofono@ofono

Re: [PATCH] ppp: fix event generation on close

2010-04-02 Thread Denis Kenzior
Hi Kristen, > Prevents too early transition to PPP_DEAD > --- > gatchat/gatppp.c |4 +--- > gatchat/ppp.h |1 - > gatchat/ppp_lcp.c | 17 - > 3 files changed, 5 insertions(+), 17 deletions(-) This patch has been applied, thanks. Regards, -Denis ___

[PATCH] ppp: use queue to transmit

2010-04-02 Thread Kristen Carlson Accardi
Since we are using non buffered I/O, use a queue to transmit when we will not block. --- gatchat/gatppp.c | 133 - gatchat/ppp.h|4 +- gatchat/ppp_cp.c |1 + 3 files changed, 94 insertions(+), 44 deletions(-) diff --git a/gatchat/ga

[PATCH] ppp: fix event generation on close

2010-04-02 Thread Kristen Carlson Accardi
Prevents too early transition to PPP_DEAD --- gatchat/gatppp.c |4 +--- gatchat/ppp.h |1 - gatchat/ppp_lcp.c | 17 - 3 files changed, 5 insertions(+), 17 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 2b853f0..6d4950d 100644 --- a/gatchat/gatpp

Re: [PATCH 01/15] Add parser for card reader status objects

2010-04-02 Thread Denis Kenzior
Hi Yang, > --- > src/stkutil.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) All 15 patches have been applied with some minor fixes afterwards. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/lis