Re: [SMS D-Bus 03/23] smutil.h: add missing header file dependencies

Hi Inaky, > src/smsutil.h |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/src/smsutil.h b/src/smsutil.h > index 66ef6f8..baa3eca 100644 > --- a/src/smsutil.h > +++ b/src/smsutil.h > @@ -18,6 +18,14 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Bos

Re: [SMS D-Bus 02/23] util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking

Hi Inaky, > These have been stolen from the Linux kernel source; come pretty handy > to make build-time consistency checks and thus avoid run-time > surprises. > --- > src/util.h | 28 > 1 files changed, 28 insertions(+), 0 deletions(-) I still think that using inc

RE: Monitor current technology

> So my current thinking is to drop any Tech reporting in gprs atom for now. > > At least until we actually find a usecase for EPSB/CPSB style reporting. What about the CGREG style tech reporting? Cheers, Waldo ___ ofono mailing list ofono@ofono.org

[SMS D-Bus 22/23] SMS: set the SRR bit in outgoing PDUs if WFA is requested

From: Inaky Perez-Gonzalez When calling sms_text_prepare(), pass a new argument (srr) that denotes if the TP-SRR bit in the PDU should be set to request an Status Report from the Service Center. --- src/sms.c | 13 ++--- src/smsutil.h |2 ++ 2 files changed, 12 insertions(+), 3

[SMS D-Bus 23/23] sms_text_prepare: document @use_delivery_reports

From: Inaky Perez-Gonzalez --- src/smsutil.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index cdf28f9..54278ad 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2831,6 +2831,9 @@ static inline GSList *sms_list_append(GSList *l, const

[SMS D-Bus 21/23] SMS: make D-Bus SendMessage and Cancel fully synchronous

From: Inaky Perez-Gonzalez Up until now, SMSManager::SendMessage() and SMSMessage::Cancel() where D-Bus asynchronous. They would perform the D-Bus method return reply inside the callbacks, as they needed to wait for the operation to complete. Relying on previous commits that make the SMS message

[SMS D-Bus 20/23] SMS: send D-Bus SMS-MSG::ProperyChanged signals when message changes status

From: Inaky Perez-Gonzalez This hooks __sms_msg_state_change_dbus_signal() into __ofono_sms_tx_state_set(), so that a D-Bus signal will be emitted whenever an SMS Message transitions state. This allows a client to track, if desired, what is going on with the SMS Message it cares about. With this

[SMS D-Bus 18/23] SMS: rename tx_queue_entry->msg to ->dbus_msg for clarity

From: Inaky Perez-Gonzalez 'msg' gets too confusing: is it the SMS message, a D-Bus message? --- src/sms.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/sms.c b/src/sms.c index faaacbe..4ad9e61 100644 --- a/src/sms.c +++ b/src/sms.c @@ -13

[SMS D-Bus 19/23] SMS: Implement D-Bus SMS-MSG::GetProperties

From: Inaky Perez-Gonzalez Currently this only returns the state of the SMS message. --- src/sms.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 4ad9e61..77904ad 100644 --- a/src/sms.c +++ b/src/sms

[SMS D-Bus 17/23] SMS: introduce sms_msg_cancel and its D-Bus wrapper

From: Inaky Perez-Gonzalez This introduces the ability to cancel a pending SMS message, accessible via an internal API and over a D-Bus wrapper. Sending a note to the network to cancel an in-transit message is not yet implemented. --- src/sms.c | 57 +++

[SMS D-Bus 16/23] SMS: introduce wait-for-ack state and infrastructure

From: Inaky Perez-Gonzalez This introduces basic infrastructure to support wait-for-ack in SMS messages. It consists of a state definition in the state transtition machine, a wait-for-ack queue (ofono_sms->wfaq) and a flag setting in which a message is tagged as 'requests wait for ack'. This doe

[SMS D-Bus 15/23] SMS: split sms_send_message() into a D-Bus front end and an internal API

From: Inaky Perez-Gonzalez sms_send_message() is unfolded into: - sms_msg_send(), a full C interface for SMS sending - dbus_SendMessage(), which adapts sms_msg_send() to be a D-Bus call This is done to allow plugins to use the same infrastructure as D-Bus clients to send SMS messages. --- src

[SMS D-Bus 14/23] SMS: export outgoing messages over D-Bus (skeleton)

From: Inaky Perez-Gonzalez This creates two frunctions, sms_msg_[un]register() which will add/remove a D-Bus object for each SMS message when in transit. Future changes make sms_msg_register() need information that is not available at the time create_tx_queue_entry() is called, thus why registra

[SMS D-Bus 13/23] SMS: introduce bare state machine and transitions

From: Inaky Perez-Gonzalez This adds state to outgoing/in-transit SMS messages. This will be used later on for persistence / D-Bus, when the SMS life cycle is expanded. The state is a variable in the 'struct tx_queue_entry' which gets updated as messages go through the hoops. --- src/sms.c | 1

[SMS D-Bus 12/23] SMS: produce a unique, persistent name for in-transit messages

From: Inaky Perez-Gonzalez This name will be used for persistence and D-Bus object naming. It is not very humanly readable, but most dependable to avoid collisions. --- src/sms.c | 12 src/smsutil.h |6 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a

[SMS D-Bus 11/23] struct tx_queue_entry: add fields and destructor

From: Inaky Perez-Gonzalez Add a name field that will be used to contain a permanent name for each SMS message in-transit, to be used for persistent storage and for D-Bus object naming. The persist name will be used to denote if persistence has to be implemented in this in-transit SMS or not. I

[SMS D-Bus 10/23] sms: add doc about the extensions D-Bus API (not yet implemented)

From: Inaky Perez-Gonzalez --- doc/sms-api.txt | 94 +++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a/doc/sms-api.txt b/doc/sms-api.txt index baa4aa1..a23486a 100644 --- a/doc/sms-api.txt +++ b/doc/sms-api.txt @@ -46,3 +46,

[SMS D-Bus 09/23] SMS: implement SHA256-based message IDs [incomplete]

From: Inaky Perez-Gonzalez This patch removes the sequential SMS message identification gig and replaces it with a 16-bit hash cookie based off message contents. FIXME: [incomplete] need to figure out how to do so that identical messages sent to the same number also have a different ID. Note th

[SMS D-Bus 08/23] export sms_assembly_encode_address

From: Inaky Perez-Gonzalez For generating unique message naming (for persistence and D-Bus object naming), we'll be using the address. Instead of repeating the functions, we reuse the same infrastructure used by the SMS assembly code. --- src/smsutil.c |4 ++-- src/smsutil.h |2 ++ 2 fil

[SMS D-Bus 06/23] SMS: introduce message ID API

From: Inaky Perez-Gonzalez This adds a simple API to use for generating unique IDs for SMS messages. --- Makefile.am|5 +- src/smsutil.c | 191 +++ src/smsutil.h | 82 +++ unit/test-sms-msg-id.c | 212 +

[SMS D-Bus 07/23] introduce DECLARE_SMS_ADDR_STR()

From: Inaky Perez-Gonzalez Introduce DECLARE_SMS_ADDR_STR(), which declares a string variable of the right size for passing to sms_assembly_decode_address(). This way we detach each client having to have the knowledge of what the right size is, leaving that decission to the infrastructure provide

[SMS D-Bus 05/23] doc: explain debugging options to -d, add a pointer in -h to manpage

From: Inaky Perez-Gonzalez Modified HACKING and man page to have more formation on what are the debugging options and how to enable them. --- HACKING | 10 ++ doc/ofonod.8 |5 - src/main.c |4 +++- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/HACKI

[SMS D-Bus 01/23] documentation: add note about referencing standards

From: Inaky Perez-Gonzalez --- doc/standards.txt |8 1 files changed, 8 insertions(+), 0 deletions(-) create mode 100644 doc/standards.txt diff --git a/doc/standards.txt b/doc/standards.txt new file mode 100644 index 000..c4b68eb --- /dev/null +++ b/doc/standards.txt @@ -0,0 +

[SMS D-Bus 04/23] write_file: make transaction-safe

From: Inaky Perez-Gonzalez write_file(), as written wasn't transaction-safe; a crash bewtween a file being open and the buffer being written before a safe close would leave the file with a set of undetermined contents. Modified to the file is written to a temporary file name; once completed, it

[SMS D-Bus 03/23] smutil.h: add missing header file dependencies

From: Inaky Perez-Gonzalez --- src/smsutil.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/smsutil.h b/src/smsutil.h index 66ef6f8..baa3eca 100644 --- a/src/smsutil.h +++ b/src/smsutil.h @@ -18,6 +18,14 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor,

[SMS D-Bus 02/23] util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking

From: Inaky Perez-Gonzalez These have been stolen from the Linux kernel source; come pretty handy to make build-time consistency checks and thus avoid run-time surprises. --- src/util.h | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/src/util.

[SMS D-Bus 00/23] Exports SMS over D-Bus and mis cleanups

From: Inaky Perez-Gonzalez Hi All This patchset is the current state of my tree that changes the D-Bus interface for SMS: - adds object based management of SMS messages - adds a cancelation operation for in-transit / pending messages - holds messages waiting for acknoledgement (delivery re

Re: [PATCH 1/2] stkutil: display text attributes as html

Hi Kristen, > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include Minor nitpick, but this include is not needed. > > #include > Regards, -Denis ___ ofono mailing list ofono@ofono.org ht

Re: Monitor current technology

Hi Daniel, > This series adds a new property to DCM to export the > current technology used. > So I've been reviewing your patches and also thinking about solving this technology problem nicely. First a bit of background on the state of hardware today: 27.007 (The Standard): - +CREG - Report

Re: Required suggestion to use third part code in oFono

Hi Satya, > I have a third part OEM layer. > According to the oFono architecture and standards can any one suggest > the good approach to use the third part OEM layer @ oFono. oFono is licensed under GPL v2 and as long as your OEM layer is compatible with GPL v2 you can use it. Regards Marcel

Required suggestion to use third part code in oFono

Hi all, I have a third part OEM layer. According to the oFono architecture and standards can any one *suggest* the good *approach* to use the third part OEM layer @ oFono. Regards, Satya. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/li