RE: [PATCH] Fix common misspellings

Hi > >Yes, I use a script I made based on the format of misspelling >corrections available at wikipedia. I've uploaded the 3 files I used >to http://people.profusion.mobi/~lucas/playground/ > >First, and most important: fix-typos.sh. It reads from stdin the words >to fix in the following format:

Re: [PATCH] Fix common misspellings

Hi, On Tue, Sep 14, 2010 at 12:21 AM, Gu, Yang wrote: > This is an interesting patch. I guess you must have some tool/script to help > you find all the misspellings against this list. Could you please share the > tool/script? After all, we can check the code in the future as this kind of > mis

[PATCH] phonesim: simulate language notification in sim app

--- src/qsimcommand.cpp| 11 src/simapplication.cpp | 68 src/simapplication.h |2 + 3 files changed, 81 insertions(+), 0 deletions(-) diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp index 9a9a169..9746592 100644 --- a

[PATCH 3/4] stk: Handling of Send USSD proactive command

--- src/stk.c | 173 - 1 files changed, 172 insertions(+), 1 deletions(-) diff --git a/src/stk.c b/src/stk.c index 04bfc65..f94643f 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1590,6 +1590,174 @@ static gboolean handle_command_set_up_cal

[PATCH 2/4] Add __ofono_ussd_initiate internal api for Sending USSD

--- src/ofono.h |8 + src/ussd.c | 101 --- 2 files changed, 104 insertions(+), 5 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index f1c0973..f64f149 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -258,6 +258,9 @@ typedef gbo

Re: [online-impl-v2 PATCH 00/10] implement Online property

Hi Pekka, > > STE version needs testing by the STE guys, but I did run into some SIM > > not ready issues with MBM when switching online/offline a few times. So > > that needs to be looked into. > > Please have a peek in your AT log and see if there are some spurious > +GCAP: lines? My Dell 5530

Re: [online-impl-v2 PATCH 00/10] implement Online property

Hi Sjur, > > STE version needs testing by the STE guys, but I did run into some SIM > > not ready issues with MBM when switching online/offline a few times. So > > that needs to be looked into. > > OK, I'll put in on our list. > Perhaps you could send me thelogs if you still have them around? do

[PATCH 1/4] Internal and Driver API changes for Send USSD

--- drivers/atmodem/ussd.c | 115 --- drivers/isimodem/ussd.c | 42 +++-- include/ussd.h |8 ++- src/ussd.c | 39 +--- 4 files changed, 115 insertions(+), 89 deletions(-) diff --git a/drivers/atmod

Re: [online-impl-v2 PATCH 00/10] implement Online property

[Marcel] > STE version needs testing by the STE guys, but I did run into some SIM > not ready issues with MBM when switching online/offline a few times. So > that needs to be looked into. OK, I'll put in on our list. Perhaps you could send me thelogs if you still have them around? Regards Sjur __

Re: [online-impl-v2 PATCH 00/10] implement Online property

Hi, 2010/9/9 Marcel Holtmann : >> Here are 2nd stab at implementing Online property with various modem >> drivers. > > so I pushed most of them, but not all of them. Ok. Cool. > STE version needs testing by the STE guys, but I did run into some SIM > not ready issues with MBM when switching onli

Re: [PATCH 6/8] Add __ofono_ussd_initiate internal api for Sending USSD

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > src/ofono.h |7 + > src/ussd.c | 86 > ++- > 2 files changed, 92 insertions(+), 1 deletions(-) > > diff --git a/src/ofono.h b/src/ofono.h > index f1c0973..8ab6

[RFC PATCH 1/2] smsutil: national to international conversion in status report

--- src/smsutil.c | 70 1 files changed, 55 insertions(+), 15 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 26c7951..2d47289 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2826,14 +2826,18 @@ gboolean status_report_ass

[RFC PATCH 2/2] unit: national to international conversion

--- unit/test-sms.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/unit/test-sms.c b/unit/test-sms.c index 0ff9cd5..96b9b50 100644 --- a/unit/test-sms.c +++ b/unit/test-sms.c @@ -1316,6 +1316,23 @@ static void test_sr_assembly() g_assert(id == 4

Re: [PATCH 5/8] Internal and Driver API changes for Send USSD

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > drivers/atmodem/ussd.c | 112 > +++ > drivers/isimodem/ussd.c | 42 +++-- > include/ussd.h |8 ++- > src/ussd.c | 61 +-

Re: [PATCH 4/8] USSD atom driver changes to read current character setting

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > drivers/atmodem/ussd.c | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@

Re: [PATCH 3/8] test-util: Add function for validating UCS2 to GSM bit conversion

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > unit/test-util.c | 80 > ++ > 1 files changed, 80 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis __

Re: [PATCH 2/8] util: Add UCS2 to GSM 7bit converion function

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > src/util.c | 108 > > src/util.h | 10 + > 2 files changed, 118 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis __

Re: [PATCH 1/8] smsutil: Add USSD encoding function

Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: > --- > src/smsutil.c | 29 + > src/smsutil.h |1 + > 2 files changed, 30 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH] phonesim: Fix multiple proactive command ind issue

Hi Jeevaka, On 09/14/2010 11:22 AM, Jeevaka Badrappan wrote: > --- > src/phonesim.cpp | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

phonesim fix for multiple proactive command ind

Hi, This patch fixes the multiple answering of AT+CSIM command and multiple notification of the new proactive command. Regards, jeevaka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] phonesim: Fix multiple proactive command ind issue

--- src/phonesim.cpp | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/phonesim.cpp b/src/phonesim.cpp index 8210f51..89089b2 100644 --- a/src/phonesim.cpp +++ b/src/phonesim.cpp @@ -1013,11 +1013,13 @@ bool SimRules::simCommand( const QString& cmd ) QS

[PATCH V2 0/5] Add DUN server for oFono

Hi, I updated the DUN server patches according to the comments, mainly patch 4/5 and 5/5. It's quite similar with history/nettime plugins, which to probe the plugin when modem state changes to 'online'. Please review them. Thanks. Regards, Zhenhua ___

[PATCH V2 2/5] bluetooth: Add Btio library for DUN

Btio library is the low level socket API for BT RFCOMM connection. We share the same library among BlueZ, Obex and oFono. So make sure you synchronize to other two projects when you make changes to btio.[ch]. --- Makefile.am |8 +- btio/btio.c | 1299 +

[PATCH V2 5/5] dun_gw: Add DUN server plugin for oFono

DUN server is probed when modem state changes to online. It registers DUN record to Bluetooth adapter and wait for incoming DUN connection. --- Makefile.am |3 + plugins/dun_gw.c | 113 ++ 2 files changed, 116 insertions(+), 0 deletions

[PATCH V2 4/5] emulator: Add emulator atom in oFono

Create emulator atom when modem state changes to online. The emulator driver probes each driver to create specific emulator like DUN, HFP AG, etc. Once get client connection request, create GAtServer to talk AT commands with client side. --- Makefile.am|4 +- include/emulator.h | 54

[PATCH V2 3/5] bluetooth: Add bluetooth server support for DUN

It watches Bluetooth adapter property changes and addes DUN record to listen DUN client connection request. --- plugins/bluetooth.c | 379 +++ plugins/bluetooth.h | 14 ++ 2 files changed, 393 insertions(+), 0 deletions(-) diff --git a/plugins/bl

[PATCH V2 1/5] bluetooth: Add reference count for bluetooth utils

Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 62 +-- 1 files changed, 45 insertions(+), 17 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 5a85eaa..10cc49d

Re: [PATCH] TODO: Add Support for Language Notification proactive command

Hi Jeevaka, On 09/14/2010 01:56 AM, Jeevaka Badrappan wrote: > --- > TODO |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) Patch has been applied, but I reworded the commit. Please keep the commit header length to 50 characters or less. Regards, -Denis

Re: [PATCH] Check if ussd is busy when doing ss

Hi Yang, 2010/9/14 Gu, Yang : >>> It's still not clear how ss and ussd interfere with each other. Current >>> decision is each ss (call-barring, call-forwarding, etc.) has >>> interference with ussd, but there is no interference within these ss. >>> That is, call-barring has interference with ussd

RE: [PATCH] Check if ussd is busy when doing ss

Hi, >-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >Pekka Pessi >Sent: Monday, September 13, 2010 9:19 PM >To: ofono@ofono.org >Subject: Re: [PATCH] Check if ussd is busy when doing ss > >Hi Yang, > >2010/9/6 Yang Gu : >> It's still not c

Re: [PATCH 2/6] Fix common misspellings in drivers

Hi Aki, > >> - * Copyright (C) 2010 Nokia Corporation and/or its subsidary(-ies). > >> + * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). > > > > for these kind of changes, I prefer if you have buy in from the Nokia > > guys. Some companies have strict rules on the copyright h