RE: [PATCH] doc: Add Location Services API

2010-11-19 Thread Bastian, Waldo
[Resend without the bottom quote - Damn you Outlook] Conformance testing per 3GPP 34.109s5.4.1.3 requires that RESET UE POSITIONING STORED INFO is handled. Similar for 3GPP RESET MS POSITIONING STORED INFO per 3GPP 44.014s12. As far as I can see there is no provision for that in commands / XML de

RE: [PATCH] doc: Add Location Services API

2010-11-19 Thread Bastian, Waldo
Conformance testing per 3GPP 34.109s5.4.1.3 requires that RESET UE POSITIONING STORED INFO is handled. Similar for 3GPP RESET MS POSITIONING STORED INFO per 3GPP 44.014s12. As far as I can see there is no provision for that in commands / XML defined by 27.007. Would it make sense to add a ResetSt

Re: [PATCH 1/3] Add TTY (hearing impaired) support

2010-11-19 Thread Lucas De Marchi
Hi, Gustavo On Fri, Nov 19, 2010 at 8:18 PM, Gustavo F. Padovan wrote: >> +Properties   boolean Powered [readwrite] > > From what I remember in the discussion in the IRC, this should be > Enabled and not Powered. > Dennis told me to send the patch with "Powered", so we can agree here what is the

[PATCH] Add test script for the Lockdown property

2010-11-19 Thread Gustavo F. Padovan
--- test/lockdown-modem | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/lockdown-modem diff --git a/test/lockdown-modem b/test/lockdown-modem new file mode 100755 index 000..73f2199 --- /dev/null +++ b/test/lockdown-modem @@ -0,0 +1

Re: [PATCH 1/3] Add TTY (hearing impaired) support

2010-11-19 Thread Gustavo F. Padovan
Hi Lucas, * Lucas De Marchi [2010-11-18 09:26:54 -0200]: > --- > Makefile.am|5 +- > doc/text-telephony-api.txt | 38 + > include/dbus.h |1 + > include/text-telephony.h | 71 ++ > src/modem.c|1 + > src/ofono.h

[PATCH 3/3] Add Lockdown property to Modem interface

2010-11-19 Thread Gustavo F. Padovan
Setting Lockdown to TRUE means power down the modem and hold a lock that only permits the lock's owner power up the modem back. When released it restores the last state of the modem before holding the lock. --- doc/modem-api.txt | 10 + src/modem.c | 114 ++

[PATCH 2/3] Add __ofono_error_access_denied()

2010-11-19 Thread Gustavo F. Padovan
--- src/dbus.c |6 ++ src/ofono.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index 8a685aa..d7ad564 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -342,6 +342,12 @@ DBusMessage *__ofono_error_canceled(DBusMessage *msg)

[PATCH 1/3] TODO: Add owner to implement the Lockdown property

2010-11-19 Thread Gustavo F. Padovan
--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index dec43fd..36afaeb 100644 --- a/TODO +++ b/TODO @@ -475,6 +475,7 @@ Miscellaneous Priority: Medium Complexity: C2 + Owner: Gustavo F Padovan - TTY (hearing impaired) support. Add a new o

[PATCH -v3 3/3] modem: add support to restore state when resetting the modem

2010-11-19 Thread Gustavo F. Padovan
--- src/modem.c | 74 -- 1 files changed, 41 insertions(+), 33 deletions(-) diff --git a/src/modem.c b/src/modem.c index e57f8fc..704de29 100644 --- a/src/modem.c +++ b/src/modem.c @@ -61,6 +61,7 @@ enum modem_state { struct ofono_modem {

[PATCH -v3 2/3] phonesim: Add modem reset trigger

2010-11-19 Thread Gustavo F. Padovan
--- plugins/phonesim.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..7426da6 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -237,6 +237,13 @@ static void cfun_set_on_cb(gboolean ok, GAtResult *

[PATCH -v3 1/3] Add ofono_modem_reset()

2010-11-19 Thread Gustavo F. Padovan
Some modems can screw up everything and then we will need to do a silent reset of the modem. This patch take the modem back to the OFFLINE state. --- include/modem.h |2 ++ src/modem.c | 44 +++- 2 files changed, 45 insertions(+), 1 deletions(-) d

[PATCH] TODO: add owner to Frequency Band Selection task

2010-11-19 Thread Lucas De Marchi
--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index bf2305b..2247e46 100644 --- a/TODO +++ b/TODO @@ -437,6 +437,7 @@ Miscellaneous - Frequency Band Selection. Add frequency band selection capability to the RadioSettings atom. + Owner: Lucas

[PATCH] src: coding style fixes - rule M6

2010-11-19 Thread Jeevaka Badrappan
--- src/audio-settings.c |4 ++-- src/call-barring.c|4 ++-- src/call-forwarding.c |4 ++-- src/call-meter.c |4 ++-- src/call-settings.c |4 ++-- src/cbs.c | 10 +- src/dbus.c|4 ++-- src/gprs.c|4 ++-- src/hist

Re: [PATCH] build: Update glib version in configure.ac

2010-11-19 Thread George Matveev
Hi Marcel, you are right. I've just corrected that and resubmitted the patch, please review. Best regards, George --- Ursprungligt brev Ärende: Re: [PATCH] build: Update glib version in configure.ac Från: "Marcel Holtmann" Datum: Fr, 2

[PATCH] build: Update glib version in configure.ac

2010-11-19 Thread George Matveev
function g_mkstemp_full in src/storage.c requires glib version 2.22 or higher --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 6aeab7c..c0f4217 100644 --- a/configure.ac +++ b/configure.ac @@ -67,8 +67,8 @@ AC_CHECK_LIB(