Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Rémi, On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: More than one second delay over D-Bus is not unheard of, especially on mobile devices. I don't see the point of sending _both_ the reception timestamp and the original NITZ value, but I do see the point in sending a

[PATCH 1/4] gisi: Changes to prepare for isimodem2.5

This set of patches introduces the isimodem2.5. WG2.5 (isimodem2.5) Supported features list: General: Online / Offline mode (RF on/off) Voice call: MO/MT call Multiparty call (max 7 calls) Transfer call Swap calls Hold calls Hang up all Hang up specific call Disconnect reason

[PATCH 2/4]simutil: Changes to prepare for isimodem2.5

updates in src/simutil.h Adding some sim file id and sim dir id mostly related to phonebook usim/sim. Regards, Jessica Nilsson --- src/simutil.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 92b2e0f..bc53255

[PATCH 4/4] scripts: Added init.rc script

Updates in Makefile.am and the adding of an init file. Regards, Jessica Nilsson --- Makefile.am| 10 +++ scripts/ofonod | 79 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 scripts/ofonod diff --git

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Aki, where is this timed running? I prefer the plugin just send a D-Bus message to the timed directly instead of a Get/Changed API kind of thing. AFAIK, timed is in system bus. However, I fail to see how you can make this any simpler. In the end, one of the two entities has to

Re: [PATCH 0/5] Call Counters (2nd)

Hi Aki, Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters are updated periodically when there is an

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Marcel, 2010/12/8 Marcel Holtmann mar...@holtmann.org: is timed actually open source and I can have a look at it? so what about this? Where is the timed respository? I really wanna have a look at it and see what it is doing. Knock yourself out:

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Jessica, Updates in Makefile.am - adding of isimodem2.5 Adding of drivers/isimodem2.5/ files to fully listed functionality. Regards, Jessica Nilsson --- Makefile.am| 36 +- drivers/isimodem2.5/call-barring.c | 503 ++

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

Hi Jessica, This set of patches introduces the isimodem2.5. WG2.5 (isimodem2.5) Supported features list: General: Online / Offline mode (RF on/off) Voice call: MO/MT call Multiparty call (max 7 calls) Transfer call Swap calls Hold calls Hang up all Hang up specific call

Re: [PATCH 0/5] Call Counters (2nd)

Hi Marcel, 2010/12/8 Marcel Holtmann mar...@holtmann.org: so Denis and I talked about this a little bit and I am not fine with this at all. Next time, can you invite me to join your little talk? Lets take this one step and please explain to me what your requirements and objectives are. I

Re: [PATCH 1/3] sms: store pending tx pdus on disk

On 12/07/2010 04:57 PM, Kristen Carlson Accardi wrote: On Mon, 06 Dec 2010 20:38:58 -0600 Denis Kenzior denk...@gmail.com wrote: snip + /* +* file name is: imsi/order in tx_queue-uuid/order of pdus +*/ + if (write_file(buf, len, SMS_BACKUP_MODE, +

RE: ofono Digest, Vol 20, Issue 28

Hello, This is regarding driving ST-Ericsson Modem (which user CAIF protocol) using OFono framework. Host: LinuxTarget : ST-Ericsson GSM ModemCommunication: RS232 cableDrivers: VCP (virtual comport drivers from FTDI ftdi-elan.ko, ftdi_sio.ko) We implemented CAIF protocol and able to drive

CAIF Protocol : oFono

Hello, This is regarding driving ST-Ericsson Modem (which user CAIF protocol) using OFono framework.-Host: LinuxTarget : ST-Ericsson GSM ModemCommunication: RS232 cableDrivers: VCP (virtual comport drivers from FTDI

[PATCH] stk: fix issue to avoid null pointer for alpha_id

From: Guillaume Lucas guillaumex.lu...@intel.com If a SET UP CALL proactive command with no alpha identifier occurs, the alpha_id pointer will be set to NULL. This will generate a crash in the stkagent with dbus function. To avoid this we use an empty string if the alpha identifier is not present

Re: [PATCH 0/5] Call Counters (2nd)

Hi Aki, so Denis and I talked about this a little bit and I am not fine with this at all. Next time, can you invite me to join your little talk? because you are not sitting next to me right now ;) Lets take this one step and please explain to me what your requirements and objectives

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Marcel, thanks for your input. this is not gonna work this way. No one can review such a massive patch. Actually Evolution even refused to format this for me. :-) Right you are, it's huge So please split this into one patch per atom driver. We are starting to look at this split

RE: [PATCH 0/5] Call Counters (2nd)

Hi, Because if your battery runs out in the middle of a 4 hour conference call, your timers are not updated and become worthless. Obviously, this is a compromise between how reliable the counters are and how many wakeups and IO we can bear. I think this is not a good idea to have

Re: [PATCH] Simulate provide local info command in sim app

Hi Yang, On 12/08/2010 01:18 AM, Yang Gu wrote: --- src/simapplication.cpp | 68 src/simapplication.h |2 + 2 files changed, 70 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 2/3] Make timezone an optional field

Hi Yang, On 11/30/2010 04:44 AM, Yang Gu wrote: --- src/smsutil.c | 11 ++- src/smsutil.h |1 + src/stkutil.c | 13 ++--- 3 files changed, 13 insertions(+), 12 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 3/3] stk: Handle provide local info proactive command

Hi Yang, On 11/30/2010 04:44 AM, Yang Gu wrote: --- src/stk.c | 77 + 1 files changed, 77 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono

RE: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi, In addition, I don't a point in a filename. So isimodem25 or isimodem2 or something like that please. I am open for proposals. Let's go for isimodem25 Quite a bit of the code is practically a copy-paste from the isimodem driver. Have you looked into the possibility of

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Jessica, So please split this into one patch per atom driver. We are starting to look at this split up. Do you have any other suggestions? I really want one patch per atom driver. In addition, I don't a point in a filename. So isimodem25 or isimodem2 or something like that

Re: [PATCH 2/4]simutil: Changes to prepare for isimodem2.5

Hi Jessica, updates in src/simutil.h Adding some sim file id and sim dir id mostly related to phonebook usim/sim. please write a proper commit message here. The subject is not acceptable since it misleads what this patch is doing. Also updates in src/... comments are not really useful. We

Re: [PATCH 7/9] gdbus: explicitly compare pointers to NULL

Hi Lucas, This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c |

Re: [PATCH 0/5] Call Counters (2nd)

Hi Andras, Lets take this one step and please explain to me what your requirements and objectives are. I also wanna see a top to bottom from UI down to the modem usage of this API. We need a UI showing total MO and MT call times. They also need to be able to be reset, if the

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

Hi Lucas, On 11/30/2010 12:41 PM, Lucas De Marchi wrote: --- Makefile.am |3 +- drivers/huaweimodem/huaweimodem.c|2 + drivers/huaweimodem/huaweimodem.h|3 + drivers/huaweimodem/radio-settings.c | 212 ++ 4

Re: [PATCH] SMS character set unit tests.

Hi Oleg, On 12/01/2010 06:27 AM, Oleg Zhurakivskyy wrote: --- unit/test-sms.c | 244 +++ 1 files changed, 244 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH] TODO: Mark Language Notification task as done

Hi Jeevaka, On 12/01/2010 01:47 PM, Jeevaka Badrappan wrote: --- TODO |6 -- doc/features.txt |4 2 files changed, 4 insertions(+), 6 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

On Wednesday 08 December 2010 10:13:45 ext Aki Niemi, you wrote: Hi Rémi, On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: More than one second delay over D-Bus is not unheard of, especially on mobile devices. I don't see the point of sending _both_ the reception

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

On Wed, Dec 8, 2010 at 2:17 PM, Denis Kenzior denk...@gmail.com wrote: Hi Lucas, On 11/30/2010 12:41 PM, Lucas De Marchi wrote: ---  Makefile.am                          |    3 +-  drivers/huaweimodem/huaweimodem.c    |    2 +  drivers/huaweimodem/huaweimodem.h    |    3 +  

Re: [PATCH 0/5] Call Counters (2nd)

Hi Marcel, On 12/08/2010 06:12 PM, ext Marcel Holtmann wrote: Hi Andras, Lets take this one step and please explain to me what your requirements and objectives are. I also wanna see a top to bottom from UI down to the modem usage of this API. We need a UI showing total MO

Re: [PATCH v2 1/3] radio-settings: add frequency band selection methods

Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: --- include/radio-settings.h | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH v2 2/3] radio-settings: add frequency band selection properties

Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: --- src/radio-settings.c | 250 +- 1 files changed, 248 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH v2 3/3] doc: document frequency band selection

Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: --- doc/radio-settings-api.txt | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH] TODO: Add onwer to 'GPS power control atom' task

Hi Rafael, On 12/02/2010 01:22 PM, Rafael Ignacio Zurita wrote: --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a421a99..a365d38 100644 --- a/TODO +++ b/TODO @@ -488,6 +488,7 @@ Miscellaneous Priority: Low Complexity: C4

RE: [PATCH 0/5] Call Counters (2nd)

Hi, On 08 Dec 2010, Marcel Holtmann wrote: So I am actually thinking that doing that inside PulseAudio is a lot more efficient solution. The idea is that PA already runs in the user session and has to monitor the uplink/downlink state (and additionally could monitor call states as well if

[PATCH] smsutil: do not hardcode TP-ValidityPeriod

From: Pekka Pessi pekka.pe...@nokia.com --- src/smsutil.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index f4eee24..59faaf7 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -3162,11 +3162,10 @@ GSList *sms_datagram_prepare(const

Re: [PATCH 0/5] Call Counters (2nd)

Hi Andras, The call counters are shown to the user when he or she opens up an application/applet whatever UI component that is meant for showing this information. do we have a clear use case requirement from an UI point of view on how this is expected to be working.

RE: [PATCH 0/5] Call Counters (2nd)

Hi Kai, So I am actually thinking that doing that inside PulseAudio is a lot more efficient solution. The idea is that PA already runs in the user session and has to monitor the uplink/downlink state (and additionally could monitor call states as well if needed). So it knows when a

[PATCH] TODO: CDMA SMS and CDMA CMAS

--- TODO | 122 ++--- 1 files changed, 94 insertions(+), 28 deletions(-) diff --git a/TODO b/TODO index 6cf7202..0760216 100644 --- a/TODO +++ b/TODO @@ -49,33 +49,6 @@ SMS Complexity: C1 Owner: Kristen Carlson Accardi

[PATCH 0/5] Add CDMA SMS Support

This set of patches introduces the foundation for CDMA SMS support in oFono. The pathes cover support of receiving simple CDMA SMS WMT DELIVER message. Currently, only few CDMA SMS parameters and subparameters have been supported. Support of additional features will come in future patches.

[PATCH 1/5] cdma-sms: Add CDMA SMS Support

--- Makefile.am|2 +- include/cdma-sms.h | 69 include/dbus.h |4 +++ src/ofono.h|2 + 4 files changed, 76 insertions(+), 1 deletions(-) create mode 100644 include/cdma-sms.h diff --git a/Makefile.am

[PATCH 3/5] cdma-atmodem: Add CDMA SMS Support

--- Makefile.am|7 ++ configure.ac |5 ++ drivers/cdma-atmodem/atmodem.c | 47 drivers/cdma-atmodem/atmodem.h | 23 ++ drivers/cdma-atmodem/atutil.c | 45 drivers/cdma-atmodem/atutil.h | 64 +

[PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

--- Makefile.am |9 ++ configure.ac |6 + plugins/cdmaphonesim.c| 344 + plugins/cdmaphonesim.conf | 14 ++ 4 files changed, 373 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmaphonesim.c create

[PATCH 5/5] test: Add CDMA SMS unit test code

--- Makefile.am |6 ++- unit/test-cdmasms.c | 134 +++ 2 files changed, 139 insertions(+), 1 deletions(-) create mode 100644 unit/test-cdmasms.c diff --git a/Makefile.am b/Makefile.am index 44a6395..4a91993 100644 --- a/Makefile.am

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Jessica, 2010/12/8 Jessica Nilsson jessica.j.nils...@stericsson.com: +static void reset_buf(char *buf, char *buf_2, int buf_len) +{ +       memset(buf, '\0', buf_len); +       memset(buf_2, '\0', buf_len); +} + +static int get_topics_len(const char *topics) +{ +       int i = 0; +    

Re: [PATCH] TODO: Add task for NITZ name support in netreg

Hi Denis, 2010/12/3 Denis Kenzior denk...@gmail.com: Out of curiosity, how do you plan to support this on AT modems?  I have yet to see any AT modem report the NITZ network name via a proprietary command. Are you sure? In my experience, the NITZ name may be received moments after

[PATCH] Fix test-sms build failure

Fix for http://bugs.meego.com/show_bug.cgi?id=11081 --- unit/test-sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/unit/test-sms.c b/unit/test-sms.c index 94b9dbf..239cd4a 100644 --- a/unit/test-sms.c +++ b/unit/test-sms.c @@ -636,7 +636,7 @@ static void