Re: [PATCH 0/5] Call Counters (2nd)

Hi, On 12/10/2010 12:53 AM, ext Marcel Holtmann wrote: Hi Kai, I share the concern for the IO/CPU cost, but I don't think it matters much in which daemon this is done. Especially if some slack is allowed for the timers (which should be the case), ofonod will be scheduled when the CPU is

Re: [PATCH] TODO: Add task for NITZ name support in netreg

Hi Aki, Hence the reason for my pointed questions. I'm a big proponent of moving the PLMN database to the core, however this needs to work for both ISI and AT modems. Right, so you agree to this TODO item? I agree in principle, I'm just worried about the feasibility. Ideally I'd like us

RE: [PATCH 0/3] Attach GPRS on demand

Hi Marcel, I somehow missed your other comments on this mail. More responses below. Even if you can come up with an algorithm, testing it is very very challenging. There are plenty of differences in operator networks and it is very difficult to cover all cases. Making sure that the

[PATCH] ifx: adding Infineon modem self test

Hi, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. Thanks, -- r. --- plugins/ifx.c | 98 +--- 1 files changed, 92

Re: [PATCH] ifx: adding Infineon modem self test

Hi Robertino, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the modem

Re: [RFC PATCH] stk: add support of next action for menu

Hi Guillaume, On 12/09/2010 07:00 AM, Lucas, GuillaumeX wrote: From: Guillaume Lucas guillaumex.lu...@intel.com According to the 3GPP 31.124 the support of next action in SIM toolkit menus is mandatory. --- doc/stk-api.txt|5 +++-- src/stk.c |6 ++

Re: [PATCH] stk: fix issue to avoid null pointer for alpha_id

Hi Guillaume, On 12/08/2010 06:33 AM, Lucas, GuillaumeX wrote: From: Guillaume Lucas guillaumex.lu...@intel.com If a SET UP CALL proactive command with no alpha identifier occurs, the alpha_id pointer will be set to NULL. This will generate a crash in the stkagent with dbus function. To

Re: [PATCH 0/5] Call Counters (2nd)

On Friday 10 December 2010 00:53:19 ext Marcel Holtmann, you wrote: this is not really true. We can not wakeup ofonod every single second. You might wanna start running powertop. Yes we can. PulseAudio is going to be waking up the CPU 10 times per seconds or more. uhm, but I'm not

[PATCH 1/2] set huawei em770 modem device to 01 to free up 00

From: M. Dietrich m...@emdete.de device 00 is ppp capable while 01 is not. 01 does everything else fine so ofono works with it flawlessly. --- plugins/ofono.rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules

[PATCH 2/2] fake a sim-inserted status

From: M. Dietrich m...@emdete.de while the sim detection does not work this patch at least allows to use those modems. until someone has the time to work out a correct solution this is a usefull workaround. --- plugins/huawei.c |1 + 1 files changed, 1 insertions(+),

Re: [PATCH 0/5] Call Counters (2nd)

Hi Remi, Personally I think the every-10sec interval is too short. It's also highly system specific when wakeups start to get too costly, so picking up one value seems difficult. My take here is that a granularity of 1 minute is enough. There are definitely call fares with

Read/Write EFcfis/EFcphs-cff files-v4

Hi, This patch reads and writes the call forwarding unconditional status from and to the SIM depending on the SIM file availability. New property needs to be added due to the fact that number won't be available from the cphs-cff file. Incase of SIM, EFcphs-cff file holds call forwarding status

[PATCH 2/7] ifx: Move call forwarding to post sim

--- plugins/ifx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 2f4c65b..48c985c 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -703,6 +703,7 @@ static void ifx_post_sim(struct ofono_modem *modem) ofono_stk_create(modem,

[PATCH 3/7] isigen: Move call forwarding to post sim

--- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 028f1b2..b7b7ab5 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -402,6 +402,7 @@ static void isigen_post_sim(struct ofono_modem *modem)

[PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

--- src/call-forwarding.c | 246 - 1 files changed, 245 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index bb8aa37..69427a8 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -34,6 +34,7

[PATCH 4/7] plugins/n900: Move call forwarding to post sim

--- plugins/n900.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/n900.c b/plugins/n900.c index 7619821..9b16f4d 100644 --- a/plugins/n900.c +++ b/plugins/n900.c @@ -491,6 +491,7 @@ static void n900_post_sim(struct ofono_modem *modem) DBG();

[PATCH 5/7] phonesim: Move call forwarding to post sim

--- plugins/phonesim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index c7ef0d7..b4795f2 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -635,6 +635,8 @@ static void phonesim_post_sim(struct ofono_modem *modem)

[PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done

--- TODO |9 - doc/features.txt |5 + 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 8d771d6..45c3577 100644 --- a/TODO +++ b/TODO @@ -92,15 +92,6 @@ SMS SIM / SIM File system = -- Read / Write EFcfis. Call

Re: [PATCH 01/14] test: fix bug in test-ss-control-cs

Hi Gustavo, On 12/06/2010 02:12 PM, Gustavo F. Padovan wrote: --- test/test-ss-control-cs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 03/14] atmodem: cleanup DBG messages

Hi Gustavo, On 12/06/2010 02:12 PM, Gustavo F. Padovan wrote: --- drivers/atmodem/call-settings.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 02/14] atmodem: use macros for CLIP validity

Hi Gustavo, On 12/06/2010 02:12 PM, Gustavo F. Padovan wrote: --- drivers/atmodem/voicecall.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 04/14] TODO: Add onwer to CNAP task

Hi Gustavo, On 12/06/2010 02:12 PM, Gustavo F. Padovan wrote: --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Patch seems to be no longer necessary. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] TODO: Add CDMA Voicecall Support Tasks

Hi Denis On Thu, 2010-12-09 at 09:04 +0100, ext Denis Kenzior wrote: Patch looks good to me, however it does not apply: fatal: cannot convert from unknown-8bit to UTF-8 Thank you. We are currently investigating this format issue and will submit a new version once resolved. Cheers Dara

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Denis Thank you for reviewing this series of patches. We shall submit new versions according to your comments. Please find any other clarifying points inline. On Thu, 2010-12-09 at 09:36 +0100, ext Denis Kenzior wrote: + +static void voicecall_set_call_status(struct

[PATCH v2] TODO: Add CDMA Voicecall Support Tasks

--- TODO | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 8d771d6..cbcdac5 100644 --- a/TODO +++ b/TODO @@ -484,3 +484,61 @@ Miscellaneous Priority: Medium Complexity: C2 Owner: Sjur

Re: [PATCH 0/5] Call Counters (2nd)

On Friday 10 December 2010 20:34:47 ext Marcel Holtmann, you wrote: Hi Remi, Personally I think the every-10sec interval is too short. It's also highly system specific when wakeups start to get too costly, so picking up one value seems difficult. My take here is that a

[PATCH 1/3 v2] sms: store pending tx pdus on disk

--- src/sms.c | 15 +++ src/smsutil.c | 26 ++ src/smsutil.h |3 +++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 163eab0..e5e06db 100644 --- a/src/sms.c +++ b/src/sms.c @@ -77,6 +77,7 @@ struct

[PATCH 2/3 v2] sms: delete sent sms messages from backup

--- src/sms.c |7 +++ src/smsutil.c | 45 + src/smsutil.h |5 + 3 files changed, 57 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index e5e06db..dd4d27c 100644 --- a/src/sms.c +++ b/src/sms.c @@ -766,6 +766,10

[PATCH 3/3 v2] sms: restore pending tx messages from backup

--- src/ofono.h |1 + src/sms.c | 75 ++ src/smsutil.c | 143 + src/smsutil.h |8 +++ 4 files changed, 227 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index

[PATCH 2/5][RfC] Add SIM filesystem watch api.

This allows code that reads files from the SIM card to also watch for changes in these files signalled in a Refresh command by the SIM. --- include/sim.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..aab981c 100644

[PATCH 1/5] simfs: Cache flushing functions.

--- src/simfs.c | 35 +++ src/simfs.h |2 ++ 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/src/simfs.c b/src/simfs.c index 8e52f7b..2f58d9b 100644 --- a/src/simfs.c +++ b/src/simfs.c @@ -903,17 +903,39 @@ void sim_fs_check_version(struct

[PATCH 3/5][RfC] sim: Implement file watching and basic refresh.

--- src/ofono.h |4 ++ src/sim.c | 175 +++ 2 files changed, 179 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 792134b..6c660b6 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -296,6 +296,10 @@ ofono_bool_t

[PATCH 4/5][RfC] sim: Watch files we keep in memory.

These are dummy watches on files who's state is kept in memory, just to ensure that on a refresh affecting any of those files ofono re-reads them from SIM. The flow of the code in sim.c has become a little complicated, maybe watches should be automatically set for files that are being read and