Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Aki Niemi
Hi Rémi, 2011/1/19 Rémi Denis-Courmont remi.denis-courm...@nokia.com: ---  doc/connman-api.txt |   10 ++  1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22e02e5..13f622c 100644 --- a/doc/connman-api.txt +++

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

2011-01-20 Thread Rémi Denis-Courmont
On Wednesday 19 January 2011 16:36:08 ext Marcel Holtmann, you wrote: Hi Remi, diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@

Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Rémi Denis-Courmont
On Thursday 20 January 2011 10:06:50 ext Aki Niemi, you wrote: Hi Rémi, 2011/1/19 Rémi Denis-Courmont remi.denis-courm...@nokia.com: --- doc/connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt

[PATCH 0/6] Packet bearers (version 6)

2011-01-20 Thread Rémi Denis-Courmont
This series adds support for current packet switched bearers in the connection manager. doc/connman-api.txt| 10 ++ drivers/atmodem/gprs.c | 33 + include/gprs.h |1 + src/common.c | 27 +--

[PATCH 2/6] Define packet switched bearers

2011-01-20 Thread Rémi Denis-Courmont
--- src/common.c | 23 +++ src/common.h | 13 + 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/common.c b/src/common.c index d4e567b..2dd0da0 100644 --- a/src/common.c +++ b/src/common.c @@ -714,6 +714,29 @@ const char

[PATCH 3/6] Declaration for packet switched bearer notifications

2011-01-20 Thread Rémi Denis-Courmont
--- include/gprs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/gprs.h b/include/gprs.h index ad7925c..157a6f9 100644 --- a/include/gprs.h +++ b/include/gprs.h @@ -59,6 +59,7 @@ void ofono_gprs_status_notify(struct ofono_gprs *gprs, int status); void

[PATCH 1/6] Distinguish HSUPA and HSDPA

2011-01-20 Thread Rémi Denis-Courmont
--- src/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common.c b/src/common.c index 4d93488..d4e567b 100644 --- a/src/common.c +++ b/src/common.c @@ -702,9 +702,9 @@ const char *registration_tech_to_string(int tech) case

[PATCH 4/6] Core support for packet switched bearer reporting

2011-01-20 Thread Rémi Denis-Courmont
--- src/gprs.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 0e86bdf..7ef81d5 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -67,6 +67,7 @@ struct ofono_gprs { ofono_bool_t suspended; int status;

[PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Rémi Denis-Courmont
--- doc/connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22e02e5..22c59dc 100644 --- a/doc/connman-api.txt +++ b/doc/connman-api.txt @@ -77,6 +77,16 @@ Properties boolean Attached [readonly]

[PATCH 6/6] atmodem: packet switch bearer support

2011-01-20 Thread Rémi Denis-Courmont
--- drivers/atmodem/gprs.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index defb154..daa3933 100644 --- a/drivers/atmodem/gprs.c +++ b/drivers/atmodem/gprs.c @@ -200,6 +200,37 @@ static

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

2011-01-20 Thread Marcel Holtmann
Hi Remi, diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@ DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles +if !BLUETOOTH

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

2011-01-20 Thread Rémi Denis-Courmont
On Thursday 20 January 2011 11:31:32 ext Marcel Holtmann, you wrote: Hi Remi, diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@

Re: DUN client questions

2011-01-20 Thread Kalle Valo
Hi Rolf, Rolf Offermanns rofferma...@sysgo.com writes: Here is what I did to get the DUN connection up: 1. Connect the mobile using the bluetooth applet in MeeGo - The modem was recognized as DUN capable and shows up in the list-modems output from ofonos test script as /dun/xxx_yyy

Re: [PATCH v3] bluetooth: Add reference count for bluetooth utils

2011-01-20 Thread Marcel Holtmann
Hi Fred, diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 602c6da..8202381 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -40,6 +40,7 @@ static DBusConnection *connection; static GHashTable *uuid_hash = NULL; static GHashTable *adapter_address_hash = NULL;

[RFC] TODO: Move signal strength property to separate Agent API.

2011-01-20 Thread Sjur Brændeland
From: Sjur Brændeland sjur.brandel...@stericsson.com --- I think we should consider changing the way we handle signal strength in oFono. In the past I have seen very frequent signal strength reports from the modem under certain network conditions. I think we can improve the power consumption by

Re: [RFC] TODO: Move signal strength property to separate Agent API.

2011-01-20 Thread Marcel Holtmann
Hi Sjur, I think we should consider changing the way we handle signal strength in oFono. In the past I have seen very frequent signal strength reports from the modem under certain network conditions. I think we can improve the power consumption by changing the design here. I know other

[PATCH] Fix IFX large file Downlink data transer

2011-01-20 Thread Pargada, Carlos
--- gatchat/gatio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gatchat/gatio.c b/gatchat/gatio.c index 9cfc998..9d44a78 100644 --- a/gatchat/gatio.c +++ b/gatchat/gatio.c @@ -197,7 +197,7 @@ static GAtIO *create_io(GIOChannel *channel, GIOFlags flags)

Re: [PATCH] Fix IFX large file Downlink data transer

2011-01-20 Thread Marcel Holtmann
Hi Carlos, please prefix the patch with gatchat: short description And while you are fixing a IFX issue, that should be only mentioned in the body here. Along with a more detailed explanation what and why. This is especially important for things like buffer sizes etc., but in a few weeks nobody

Re: [RFC] TODO: Move signal strength property to separate Agent API.

2011-01-20 Thread Aki Niemi
Hi Marcel, 2011/1/20 Marcel Holtmann mar...@holtmann.org: I don't think is needed. You do not get woken up until you tell D-Bus to wake you up on that PropertyChanged signal. You can even match the first parameter of that signal if you desire. I think this is still a worthy optimization,

Re: DUN client questions

2011-01-20 Thread Rolf Offermanns
On 01/20/2011 11:08 AM, Kalle Valo wrote: Hi Rolf, Rolf Offermanns roffermanns-usboeamduekavxtiumw...@public.gmane.org writes: Here is what I did to get the DUN connection up: 1. Connect the mobile using the bluetooth applet in MeeGo - The modem was recognized as DUN capable and shows

[PATCH] core: Always return success to a no-op

2011-01-20 Thread Aki Niemi
A SetProperty that doesn't actually change the Online property's state when no change to that state is pending, should not fail. It should always succeed regardless of the current modem state. --- src/modem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC] TODO: Move signal strength property to separate Agent API.

2011-01-20 Thread Marcel Holtmann
Hi Aki, I don't think is needed. You do not get woken up until you tell D-Bus to wake you up on that PropertyChanged signal. You can even match the first parameter of that signal if you desire. I think this is still a worthy optimization, because this way not even oFono will wake up

[PATCH v4] bluetooth: Add reference count for bluetooth utils

2011-01-20 Thread Frédéric Danis
Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 51 --- 1 files changed, 32 insertions(+), 19 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index

Re: [PATCH 2/6] Define packet switched bearers

2011-01-20 Thread Marcel Holtmann
Hi Remi, src/common.c | 23 +++ src/common.h | 13 + 2 files changed, 36 insertions(+), 0 deletions(-) patch has been applied, but I would prefer if you actually prefix the subject with common:. Regards Marcel

Re: [PATCH 3/6] Declaration for packet switched bearer notifications

2011-01-20 Thread Marcel Holtmann
Hi Remi, include/gprs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) patch has been applied, but the subject should have had a gprs: prefix. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 4/6] Core support for packet switched bearer reporting

2011-01-20 Thread Marcel Holtmann
Hi Remi, src/gprs.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) patch has been applied and I also added a gprs: prefix here. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Marcel Holtmann
Hi Remi, doc/connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) patch has been applied and in this case I would have preferred to have a doc: prefix. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 6/6] atmodem: packet switch bearer support

2011-01-20 Thread Marcel Holtmann
Hi Remi, drivers/atmodem/gprs.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) I did apply this patch, but I fixed it up later ... diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index defb154..daa3933 100644 ---

Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

2011-01-20 Thread Marcel Holtmann
Hi Aki, please don't implement org.ofono interface in timed. Just implement a timed specific (com.nokia.time) interface and punch the whole for that in the timed D-Bus policy. I think there is some disconnect here. The intention is to implement a similar agent interface as

Re: [PATCH v4] bluetooth: Add reference count for bluetooth utils

2011-01-20 Thread Marcel Holtmann
Hi Fred, Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 51 --- 1 files changed, 32 insertions(+), 19 deletions(-) patch has been applied. Thanks. Regards Marcel

Re: [PATCH] core: Always return success to a no-op

2011-01-20 Thread Marcel Holtmann
Hi Aki, A SetProperty that doesn't actually change the Online property's state when no change to that state is pending, should not fail. It should always succeed regardless of the current modem state. --- src/modem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) patch

[PATCH]] gatchat: improve large file Downlink data transfer

2011-01-20 Thread Pargada, Carlos
Fix large file Downlink data transfer on IFX modem. Increase buffer size of ring buffer to support close received Packets from the Modem Set highest priority for write data on tun device --- gatchat/gatio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH]] gatchat: improve large file Downlink data transfer

2011-01-20 Thread Marcel Holtmann
Hi Carlos, please don't use our Exchange servers. They do make me mad :( The email From: field should be first name first. Problem with Exchange is that it ends like this: Pargada, Carlos carlos.parg...@intel.com Have a proper .gitconfig and use linux.intel.com as SMTP server and really all

[PATCH] gprs: mark context driver as not used when removing active context

2011-01-20 Thread Tomasz Gregorek
From: Tomasz Gregorek tomasz.grego...@stericsson.com --- src/gprs.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 7ef81d5..0661f74 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -1679,6 +1679,8 @@ static void gprs_deactivate_for_remove(const

Re: [PATCH] gprs: mark context driver as not used when removing active context

2011-01-20 Thread Marcel Holtmann
Hi Tomasz, src/gprs.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH v2 2/2] stk: Handle Launch Browser proactive command

2011-01-20 Thread Jeevaka Badrappan
--- src/stk.c | 79 src/stkagent.c | 68 src/stkagent.h |7 + 3 files changed, 154 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index f151fc1..80edc25

[PATCH v2 1/2] stkutil: add check for qualifier and browser id

2011-01-20 Thread Jeevaka Badrappan
Checks the valid qualifier and browser id values applicable for launch browser proactive command --- src/stkutil.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index b7f03e2..abd1c99 100644 --- a/src/stkutil.c +++ b/src/stkutil.c

[PATCH v2 0/2] LaunchBrowser Proactive command Support

2011-01-20 Thread Jeevaka Badrappan
Hi, Following set of patches adds the basic support for LaunchBrowser proactive command to ofono. When a LaunchBrowser proactive command is received, oFono will inform the agent to LaunchBrowser with the specified URL. If confirmed by user, agent should launch the browser with the specified

[gprs-provision PATCHv5 0/6] Plugin API for provisioning of GPRS context setting

2011-01-20 Thread Jukka Saunamaki
Hello And again, here is a new patchset about implementing automatic provisioning of GPRS context settings. Since last time, driver API should be cleaner now. Some whitespace issues fixed, and probably some new ones introduced :) Example driver patch requires ofono_sim_get_mcc/mnc in SIM atom

[PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Jukka Saunamaki
--- Makefile.am |2 +- include/gprs-provision.h | 74 ++ 2 files changed, 75 insertions(+), 1 deletions(-) create mode 100644 include/gprs-provision.h diff --git a/Makefile.am b/Makefile.am index c1c34ca..7a03f08 100644 ---

[PATCH 2/6] ofono.h: add new atom type for gprs-provision

2011-01-20 Thread Jukka Saunamaki
--- src/ofono.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 77567c2..43a703f 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -127,6 +127,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_NETTIME = 21, OFONO_ATOM_TYPE_CTM

[PATCH 5/6] gprs: add gprs context provisioning

2011-01-20 Thread Jukka Saunamaki
--- src/gprs.c | 147 ++-- 1 files changed, 133 insertions(+), 14 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 7ef81d5..06f6555 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -43,6 +43,7 @@ #include common.h #include storage.h

[PATCH 6/6] gprs-provision: add example context provisioning driver

2011-01-20 Thread Jukka Saunamaki
--- Makefile.am |3 + examples/provision.c | 221 ++ 2 files changed, 224 insertions(+), 0 deletions(-) create mode 100644 examples/provision.c diff --git a/Makefile.am b/Makefile.am index 97480d5..7a87aee 100644 --- a/Makefile.am

[PATCH 4/6] modem: probe gprs_provision drivers

2011-01-20 Thread Jukka Saunamaki
--- src/modem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index e966a6e..a302590 100644 --- a/src/modem.c +++ b/src/modem.c @@ -424,6 +424,7 @@ static void modem_change_state(struct ofono_modem *modem,

[offline-atoms PATCHv2] Make gprs atom offline-safe.

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Allow use of GPRS atom both in online and offline (post_sim) states. The GPRS now considers the removal of the netreg atom as implicit detach and registration change to NOT_REGISTERED. --- src/gprs.c | 15 +-- 1 files changed, 13

[PATCH] isimodem: fix sending DTMF

2011-01-20 Thread Kai Vehmanen
isi_call_dtmf_send_resp() handles the success case incorrectly, and thus all send_tones attempts fail with bogus error codes. --- drivers/isimodem/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c

Re: oFono exits on new voicecall with disconnected system bus

2011-01-20 Thread Marcel Holtmann
Hi Nicola, that's happen with oFono 0.38 on freerunner with debian sid on the first incoming/outgoing call: ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() id:1, msgtype:0, direction:1, mode:0 ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() Len 0 ofonod[6232]:

Re: [PATCH 1/6] netreg: Deprecate the deregister method

2011-01-20 Thread Denis Kenzior
Hi Aki, @@ -1795,14 +1768,8 @@ static void netreg_load_settings(struct ofono_netreg *netreg) netreg-imsi = g_strdup(imsi); - mode = g_key_file_get_integer(netreg-settings, SETTINGS_GROUP, - Mode, NULL); - - if (mode = 0 mode = 2) -

Re: [PATCH 0/6] Deprecate the Deregister() method

2011-01-20 Thread Denis Kenzior
Hi Aki, On 01/19/2011 03:53 PM, Aki Niemi wrote: Hi All, This set of patches removes the Deregister() method from the netreg atom. This method serves no purpose, since the Online property is used to control oFono's radio on/off state. All patches have been applied, thanks. Regards, -Denis

Re: [offline-atoms PATCHv2] Make gprs atom offline-safe.

2011-01-20 Thread Denis Kenzior
Hi Pekka, On 01/20/2011 07:37 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Allow use of GPRS atom both in online and offline (post_sim) states. The GPRS now considers the removal of the netreg atom as implicit detach and registration change to NOT_REGISTERED.

Re: [PATCH v2 0/2] LaunchBrowser Proactive command Support

2011-01-20 Thread Denis Kenzior
Hi Jeevaka, On 01/20/2011 06:52 AM, Jeevaka Badrappan wrote: Hi, Following set of patches adds the basic support for LaunchBrowser proactive command to ofono. When a LaunchBrowser proactive command is received, oFono will inform the agent to LaunchBrowser with the specified URL. If

RE: [PATCH 4/4] atmodem: sim-auth atom driver.

2011-01-20 Thread Jeevaka.Badrappan
Hi Andrzej, ofono-boun...@ofono.org wrote: +static void at_discover_apps_cb(gboolean ok, GAtResult *result, + gpointer user_data) +{ + struct cb_data *cbd = user_data; + GAtResultIter iter; + ofono_sim_list_apps_cb_t cb = cbd-cb; + struct

[sim-auth PATCH 4/5] Add doc/gba-authentication.txt

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- doc/gba-authentication.txt | 70 1 files changed, 70 insertions(+), 0 deletions(-) create mode 100644 doc/gba-authentication.txt diff --git a/doc/gba-authentication.txt b/doc/gba-authentication.txt new

[sim-auth PATCH 3/5] Add GBA_U to SIM authentication API

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- doc/sim-authentication-api.txt | 90 1 files changed, 90 insertions(+), 0 deletions(-) diff --git a/doc/sim-authentication-api.txt b/doc/sim-authentication-api.txt index 27090e7..2db80bb 100644 ---

[sim-auth PATCH 0/5] SIM Authentication D-Bus API

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Hi all, Here is my proposed SIM authentication API, marked as experimental. First two patches are hopefully easy to swallow. The uglier GBA_U part and some generic GBA blather can be found in last three patches. Unfortunately the IMS support requires

[sim-auth PATCH 5/5] Add doc/gba-authentication.txt to dist

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 65b488a..462b05f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -396,8 +396,8 @@ doc_files = doc/overview.txt doc/ofono-paper.txt

[sim-auth PATCH 2/5] Add doc/sim-authentication-api.txt to dist

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index c1c34ca..65b488a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -394,6 +394,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt

[sim-auth PATCH 1/5] Add doc/sim-authentication-api.txt

2011-01-20 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com The authentication suites include SIM authentication (basic A8 authentication used with GSM) and AKA authentication on USIM. The SIM and AKA can be used to implement EAP, AKA Digest and GBA authentication algorithms. --- doc/sim-authentication-api.txt |

Re: [PATCH 0/3] sim: add getters for mcc and mnc

2011-01-20 Thread Denis Kenzior
Hi Jukka, On 01/19/2011 01:21 AM, Jukka Saunamaki wrote: These patches add getter functions for home PLMN MCC and MCC values to SIM atom. Jukka Saunamaki (3): sim: store mcc and mnc separate from imsi sim: getters for mcc and mnc definition sim: getters for mcc and mnc

Re: [PATCH 1/4] Remove initialisers for enum ofono_atom_type.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: They have no effect, enum already ensures the values are unique. --- src/ofono.h | 48 1 files changed, 24 insertions(+), 24 deletions(-) Patch has been applied, thanks.

Re: [PATCH 1/2] simutil: SIM applications directory decoding utils.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: --- src/simutil.c | 57 + src/simutil.h |8 2 files changed, 65 insertions(+), 0 deletions(-) Patch has been applied with one minor amend on my part:

Re: [PATCH 2/2] unit: Add a test for applications directory decoding utility.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: --- unit/test-simutil.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 2/4] Add SIM authentication atom's driver definitions.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: Structures and function declarations for the SIM authentication atom as proposed by Pekka Pessi, with just one method at the moment. --- Makefile.am|2 +- include/sim-auth.h | 64

Re: [PATCH 3/4] Add the sim-auth atom.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: Add dummy SIM authentication atom. --- Makefile.am|2 +- src/ofono.h|2 + src/sim-auth.c | 134 3 files changed, 137 insertions(+), 1 deletions(-)

Re: [PATCH 4/4] atmodem: sim-auth atom driver.

2011-01-20 Thread Denis Kenzior
Hi Andrew, On 01/19/2011 02:07 AM, Andrzej Zaborowski wrote: --- Makefile.am|3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/sim-auth.c | 162 4 files changed, 169

Re: [PATCH 4/4] atmodem: sim-auth atom driver.

2011-01-20 Thread Denis Kenzior
Hi Jeevaka, +buffer = g_malloc(len); missing check for buffer memory allocation failure Actually he's using g_malloc, so the application will simply abort. +sad = g_new0(struct sim_auth_data, 1); missing check for sad memory allocation failure Same here. My view is that

Re: Ofono has too tight limits for SIM lock code lengths

2011-01-20 Thread Denis Kenzior
Hi Jussi, On 01/19/2011 03:04 AM, Jussi Kangas wrote: Hi, I've been testing SIM locks with Ofono and it looks to me that method is_valid_pin in src/common.c has somewhat too tight rules for PIN lenghts. SIM or subsidy lock codes can be longer than 8 digits (as dictated in 22.022 chapter

Re: [PATCHv2 2/2] sms: Introduce message code independent of protocol stack

2011-01-20 Thread Denis Kenzior
Hi Faiyaz, +static void message_destroy(gpointer userdata) +{ + struct message *m = userdata; + + m-data = NULL; + m-atom = NULL; Lets remove the above two assignments, they're not really needed. + g_free(m); +} + snip diff --git a/src/message.h b/src/message.h new

[PATCH] TODO: add CDMA Connection Manager tasks.

2011-01-20 Thread christian . lam
From: Christian Lam christian@nokia.com --- TODO | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a36e9ed..2852f23 100644 --- a/TODO +++ b/TODO @@ -640,3 +640,19 @@ CDMA NETWORK ACQUISITION Priority: Medium Complexity: C2 +

Re: [PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-01-20 Thread Lucas De Marchi
Hi Martin On Thu, Jan 20, 2011 at 3:45 AM, martin...@intel.com wrote: From: Martin Xu martin...@intel.com Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP connection can't work ---  plugins/ofono.rules |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) We have

[PATCH] README: Annotate kernel dependencies

2011-01-20 Thread Gustavo F. Padovan
--- README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/README b/README index 176a2de..71c8c2d 100644 --- a/README +++ b/README @@ -20,3 +20,10 @@ Configure automatically searches for all required components and packages. To compile and install run:

Re: [PATCH] README: Annotate kernel dependencies

2011-01-20 Thread Denis Kenzior
Hi Gustavo, On 01/20/2011 01:03 PM, Gustavo F. Padovan wrote: --- README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] TODO: add CDMA Connection Manager tasks.

2011-01-20 Thread Denis Kenzior
Hi Christian, On 01/20/2011 12:09 PM, christian@nokia.com wrote: From: Christian Lam christian@nokia.com --- TODO | 16 1 files changed, 16 insertions(+), 0 deletions(-) Patch does not apply: Applying: TODO: add CDMA Connection Manager tasks.

Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-20 Thread Denis Kenzior
Hi Martin, On 01/19/2011 11:45 PM, martin...@intel.com wrote: From: Martin Xu martin...@intel.com Tramsmit ACCM and receive ACCM is mixed up. According to RFC1662 Section 7.1, ACCM Configuration Option is used to inform the peer which control characters MUST remain mapped when the peer

Re: [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package

2011-01-20 Thread Denis Kenzior
Hi Martin, On 01/19/2011 11:45 PM, martin...@intel.com wrote: From: Martin Xu martin...@intel.com Using my Huawei EM770W modem, if set ACCM as 0x, RXJ- event breaks PPP link, after IP package transmit for a while. Using default ACCM, the issue can be fixed. I tested it at China

[PATCH v2] TODO: add CDMA Connection Manager tasks

2011-01-20 Thread christian . lam
From: Christian Lam christian@nokia.com --- TODO | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a36e9ed..41f1f7f 100644 --- a/TODO +++ b/TODO @@ -640,3 +640,18 @@ CDMA NETWORK ACQUISITION Priority: Medium Complexity: C2 +

[PATCHv3 0/2] Make message state feature independent of the stack

2011-01-20 Thread Faiyaz Baxamusa
This set of patches enable the org.ofono.Message interface code to be independent of the protocol stack. This will enable both GSM and CDMA SMS stack to reuse the interface code. The changes have been tested with phonesim using send-sms script. Faiyaz Baxamusa (2): doc: Add messagemanager-api

[PATCHv3 1/2] doc: Add messagemanager-api and change message-api

2011-01-20 Thread Faiyaz Baxamusa
--- Makefile.am|4 +- ...message-api.txt = cdma-messagemanager-api.txt} |0 doc/message-api.txt| 89 doc/messagemanager-api.txt | 88 +++ 4 files

[PATCHv3 2/2] sms: Introduce message code independent of protocol stack

2011-01-20 Thread Faiyaz Baxamusa
--- Makefile.am |3 +- src/message.c | 228 src/message.h | 54 + src/sms.c | 247 +++-- 4 files changed, 312 insertions(+), 220 deletions(-) create mode 100644

Re: [PATCHv3 0/2] Make message state feature independent of the stack

2011-01-20 Thread Denis Kenzior
Hi Faiyaz, On 01/20/2011 03:42 PM, Faiyaz Baxamusa wrote: This set of patches enable the org.ofono.Message interface code to be independent of the protocol stack. This will enable both GSM and CDMA SMS stack to reuse the interface code. The changes have been tested with phonesim using

Re: [PATCH v2] TODO: add CDMA Connection Manager tasks

2011-01-20 Thread Denis Kenzior
Hi Christian, On 01/20/2011 01:24 PM, christian@nokia.com wrote: From: Christian Lam christian@nokia.com --- TODO | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis

[RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
--- doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@ -82,6 +82,17 @@ Properties boolean Powered [readwrite]

[RFC 0/1] Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
This is a RFC to initiate discussion regarding the addition of a modem technology type indicator property to the modem DBus interface. The need for such a property has arisen as we cannot use the current interface to guarantee understanding of a modem device's technology type to the upper layers

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Marcel Holtmann
Hi Dara, doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@ -82,6 +82,17 @@ Properties boolean Powered [readwrite]

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Denis Kenzior
Hi Jukka, +/* + * Callback from provisioning plugin. + */ +typedef void (*ofono_gprs_provision_cb_t)( + const struct ofono_gprs_provision_data settings[], + int count, void *user_data); + +struct ofono_gprs_provision_driver { + const char

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
Hi Marcel On 01/20/2011 01:34 PM, ext Marcel Holtmann wrote: Hi Dara, doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Marcel Holtmann
Hi Dara, doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@ -82,6 +82,17 @@ Properties boolean Powered

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
Hi Marcel On 01/20/2011 02:05 PM, ext Marcel Holtmann wrote: Thanks - sounds good to me. I'll prepare a patch to reflect this for gsm/cdma types and assume the hfp type extension is future work. not really. Actually HFP support is part of oFono already. Sorry - I meant hfp as an

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Denis Kenzior
Hi Dara, On 01/20/2011 04:17 PM, Dara Spieker-Doyle wrote: Hi Marcel On 01/20/2011 02:05 PM, ext Marcel Holtmann wrote: Thanks - sounds good to me. I'll prepare a patch to reflect this for gsm/cdma types and assume the hfp type extension is future work. not really. Actually HFP support

[PATCH] doc: Add modem Type property

2011-01-20 Thread Dara Spieker-Doyle
Add support for providing the type of the attached modem device including GSM (3GPP), CDMA (3GPP2) and Bluetooth HFP. --- doc/modem-api.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe806c8 100644 ---

RE: [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package

2011-01-20 Thread Xu, Martin
-Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, January 21, 2011 3:11 AM To: ofono@ofono.org Cc: Xu, Martin Subject: Re: [PATCH 2/3] Use default ACCM (0x) to trasmit package Hi Martin, On 01/19/2011 11:45 PM, martin...@intel.com wrote:

RE: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-20 Thread Xu, Martin
Hi Denis: -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, January 21, 2011 3:09 AM To: ofono@ofono.org Cc: Xu, Martin Subject: Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue Hi Martin, On 01/19/2011 11:45 PM,

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Jukka Saunamaki
Hi On Thu, 2011-01-20 at 15:51 -0600, Denis Kenzior wrote: So I don't really see the point in an asynchronous provisioning driver. If you want to do this over D-Bus or something then you might as well provision via the ConnectionManager interface. The other problem with being async is that