Re: [PATCH] Phonesim HACKING updated to refer to phonesim.conf instead of modem.conf.

2011-02-01 Thread Aki Niemi
Hi Essi, 2011/2/1 Essi Vehmersalo essi.vehmers...@nokia.com: -automatically includes this option. +automatically includes this option. See phonesim.conf sample configuration +under ofono/plugins on how to configure oFono to use phonesim.   Run phonesim in foreground using the following

Re: [PATCH v7] ifx: Adding modem selftest for Infineon modem

2011-02-01 Thread Marcel Holtmann
Hi Robertino, Infineon modem selftest, during ifx_enable(). Two steps trigger, with timeout. In case one fails, modem will not power up. --- plugins/ifx.c | 50 +++--- 1 files changed, 47 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2] atmodem: convert dst from hours to seconds

2011-02-01 Thread Jeevaka Badrappan
--- drivers/atmodem/network-registration.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index 4913611..3df72af 100644 --- a/drivers/atmodem/network-registration.c +++

Re: [PATCH 0/2] Fix issue with DST

2011-02-01 Thread Rémi Denis-Courmont
On Tuesday 01 February 2011 13:44:03 ext Jeevaka Badrappan, you wrote: Hi, Following patch converts the DST from hours to seconds which is the expected outcome. Is it? I think DST is just a boolean. -- Rémi Denis-Courmont Nokia Devices RD, Maemo Software, Helsinki

RE: [PATCH 0/2] Fix issue with DST

2011-02-01 Thread Jeevaka.Badrappan
ofono-boun...@ofono.org wrote: On Tuesday 01 February 2011 13:44:03 ext Jeevaka Badrappan, you wrote: Hi, Following patch converts the DST from hours to seconds which is the expected outcome. Is it? I think DST is just a boolean. Refere 3GPP TS 24.008 section 10.5.3.12 Regards, Jeevaka

[PATCH 0/1] Add pin retry count support for mbm

2011-02-01 Thread Jeevaka Badrappan
Hi, Following patch adds pin retry count support for mbm modem. Regards, Jeevaka Jeevaka Badrappan (1): atmodem: Add pin retry count support for mbm drivers/atmodem/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-)

Re: [PATCH 1/1] atmodem: Add pin retry count support for mbm

2011-02-01 Thread Marcel Holtmann
Hi Jeevaka, drivers/atmodem/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) and this is conflicting with Remi's patch for the generic CPINR now. Regards Marcel ___ ofono mailing list

Re: [PATCH] atmodem: implement standard PIN retries

2011-02-01 Thread Marcel Holtmann
Hi Remi, drivers/atmodem/sim.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 0938998..dfd40f8 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@

Re: [PATCH] TODO: SMS Validity Period

2011-02-01 Thread Miia Leinonen
Hi Marcel, Seems that you are not going to go with me on this. I do understand your point that this is very marginal feature, me myself I only use it couple times a year (which also answers to your question) and I might be in a rare group. But I do appreciate the feature when I need it. I am

[PATCH 0/1] Add pin retry count support for mbm

2011-02-01 Thread Jeevaka Badrappan
Hi, Following patch adds pin retry count support for mbm modem. Regards, Jeevaka Jeevaka Badrappan (1): atmodem: Add pin retry count support for mbm drivers/atmodem/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-)

[PATCH 1/1] atmodem: Add pin retry count support for mbm

2011-02-01 Thread Jeevaka Badrappan
--- drivers/atmodem/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index dfd40f8..d9c0d8d 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -58,6 +58,7 @@

[PATCH v2 0/3] ISI modem version detection with plugin

2011-02-01 Thread Jessica Nilsson
The same patch as before, but split up in three parts as per your suggestion. As before, please note that this does not build unless the gisi patch gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions is added first. We are currently looking at your comments on

[PATCH v2 1/3] u8500: add plugin for u8500

2011-02-01 Thread Jessica Nilsson
--- Makefile.am |4 + plugins/ofono.rules |3 + plugins/u8500.c | 507 +++ 3 files changed, 514 insertions(+), 0 deletions(-) create mode 100644 plugins/u8500.c diff --git a/Makefile.am b/Makefile.am index a38fcb9..4762cc8

[PATCH v2 2/3] udev: u8500 support and style fix

2011-02-01 Thread Jessica Nilsson
--- plugins/udev.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index ce1efe6..49b5eb8 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -185,7 +185,8 @@ static void add_hso(struct ofono_modem *modem, devnode =

[PATCH 3/4] nettime: Documentation

2011-02-01 Thread Antti Paila
--- doc/network-time-api.txt | 36 1 files changed, 36 insertions(+), 0 deletions(-) create mode 100644 doc/network-time-api.txt diff --git a/doc/network-time-api.txt b/doc/network-time-api.txt new file mode 100644 index 000..9133a73 --- /dev/null +++

[PATCH 4/4] nettime: Mock Timed for testing

2011-02-01 Thread Antti Paila
--- test/test-nettime | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) create mode 100755 test/test-nettime diff --git a/test/test-nettime b/test/test-nettime new file mode 100755 index 000..908a5db --- /dev/null +++ b/test/test-nettime @@ -0,0

[PATCH 2/4] nettime: Makefile.am modification

2011-02-01 Thread Antti Paila
--- Makefile.am |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index a38fcb9..2d54025 100644 --- a/Makefile.am +++ b/Makefile.am @@ -337,6 +337,9 @@ builtin_modules += example_provision builtin_sources += examples/provision.c endif

[PATCH] ste: Add support for CBS interface

2011-02-01 Thread Lasse Kunnasluoto
STE modems support standard AT commands in CBS --- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 0b02a0d..cf8aed8 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -48,6 +48,7 @@ #include ofono/netreg.h #include

RE: [PATCH 3/4] nettime: Documentation

2011-02-01 Thread Jeevaka.Badrappan
Hi Antti, ofono-boun...@ofono.org wrote: --- doc/network-time-api.txt | 36 1 files changed, 36 insertions(+), 0 deletions(-) create mode 100644 doc/network-time-api.txt diff --git a/doc/network-time-api.txt b/doc/network-time-api.txt new file mode

Re: [PATCH 0/3] EF-SPN API to sim-atom

2011-02-01 Thread Denis Kenzior
Hi Marcel, On 02/01/2011 04:38 AM, Marcel Holtmann wrote: Hi Denis, On Thu, 2011-01-27 at 15:22 +0200, Jukka Saunamaki wrote: Here is an asynchronous implementation of SIM Service Provider Name (EF-SPN) getter API. The trick is to delay setting sim ready until spn reading is finished.

Re: [PATCH 1/1] atmodem: Add pin retry count support for mbm

2011-02-01 Thread Marcel Holtmann
Hi Jeevaka, drivers/atmodem/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH v2 2/3] udev: u8500 support and style fix

2011-02-01 Thread Marcel Holtmann
Hi Jessica, plugins/udev.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) so you wanna combine the udev rule change and the udev change together actually. They both belong together. The actual modem plugin driver is not related. diff --git a/plugins/udev.c b/plugins/udev.c

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-01 Thread Marcel Holtmann
Hi Jessica, drivers/isimodem/debug.c | 132 drivers/isimodem/debug.h |9 +++ drivers/isimodem/mtc.h | 38 + drivers/isimodem/version.h | 26 + 4 files changed, 205 insertions(+), 0 deletions(-) create mode

Re: [RFC] voice call API changes (proposal)

2011-02-01 Thread Andras Domokos
Hi Denis, On 01/31/2011 09:58 PM, ext Denis Kenzior wrote: Hi Andras, On 01/31/2011 05:56 AM, Andras Domokos wrote: Here is a proposal for expanding the VoiceCallManager interface with call related Supplementary Services signals, and the VoiceCall interface with new properties. ---

Re: [PATCH] ste: Add support for CBS interface

2011-02-01 Thread Marcel Holtmann
Hi Lasse, STE modems support standard AT commands in CBS --- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH v2 2/3] udev: u8500 support and style fix

2011-02-01 Thread Andreas WESTIN
Hi Marcel, Jessica is out of office. On 2011-02-01 16:39, Marcel Holtmann wrote: Hi Jessica, plugins/udev.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) so you wanna combine the udev rule change and the udev change together actually. They both belong together. The

Re: [PATCH v2 2/3] udev: u8500 support and style fix

2011-02-01 Thread Marcel Holtmann
Hi Andreas, diff --git a/plugins/udev.c b/plugins/udev.c index ce1efe6..49b5eb8 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -185,7 +185,8 @@ static void add_hso(struct ofono_modem *modem, devnode = udev_device_get_devnode(udev_device); if

Re: [PATCH] atmodem: implement standard PIN retries

2011-02-01 Thread Marcel Holtmann
Hi Remi, drivers/atmodem/sim.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 0938998..dfd40f8 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@

[PATCH 2/9] common: implement initializer for ofono_call

2011-02-01 Thread Lucas De Marchi
--- src/common.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/common.c b/src/common.c index 8bf9dbb..f25f105 100644 --- a/src/common.c +++ b/src/common.c @@ -762,3 +762,10 @@ const char *ofono_uuid_to_str(const struct ofono_uuid *uuid) return

[PATCH 4/9] calypsomodem: use ofono_call initializer

2011-02-01 Thread Lucas De Marchi
--- drivers/calypsomodem/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/calypsomodem/voicecall.c b/drivers/calypsomodem/voicecall.c index 01be990..fed442c 100644 --- a/drivers/calypsomodem/voicecall.c +++ b/drivers/calypsomodem/voicecall.c @@ -314,7

[PATCH 6/9] huaweimodem: use ofono_call initializer

2011-02-01 Thread Lucas De Marchi
--- drivers/huaweimodem/voicecall.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/huaweimodem/voicecall.c b/drivers/huaweimodem/voicecall.c index a30513a..53377d9 100644 --- a/drivers/huaweimodem/voicecall.c +++ b/drivers/huaweimodem/voicecall.c @@ -56,10

[PATCH 7/9] ifxmodem: use ofono_call initializer

2011-02-01 Thread Lucas De Marchi
--- drivers/ifxmodem/voicecall.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 716652c..e7f72fc 100644 --- a/drivers/ifxmodem/voicecall.c +++ b/drivers/ifxmodem/voicecall.c @@ -87,10 +87,12 @@ static

[RFC 2/2] doc: Add description for history agent interface

2011-02-01 Thread Marcel Holtmann
--- doc/history-agent-api.txt | 83 + 1 files changed, 83 insertions(+), 0 deletions(-) create mode 100644 doc/history-agent-api.txt diff --git a/doc/history-agent-api.txt b/doc/history-agent-api.txt new file mode 100644 index 000..373974d ---

[RFC 1/2] plugins: Add basic support for history agent interface

2011-02-01 Thread Marcel Holtmann
--- plugins/history-agent.c | 509 +++ 1 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 plugins/history-agent.c diff --git a/plugins/history-agent.c b/plugins/history-agent.c new file mode 100644 index 000..42298c1 ---

Re: [PATCH 1/9] include: define initializer for ofono_call

2011-02-01 Thread Marcel Holtmann
Hi Lucas, Some fields in struct ofono_call such as cnap_validity and clip_validity are not correctly initialized as 0 since this means they are present. If driver does not implement the necessary handlers, it might send to core an ofono_call signalling that cnap and clip are available when

[PATCH 2/5] doc: fix misspelling

2011-02-01 Thread Lucas De Marchi
--- doc/sim-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 65c920d..c8091f7 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -129,7 +129,7 @@ Properties boolean Present [readonly] string

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-01 Thread Aki Niemi
Hi Marcel, On Tue, 2011-02-01 at 16:43 +0100, ext Marcel Holtmann wrote: +enum isi_version { + ISI_20 = 0, + ISI_25 = 1 +}; so what is the final decision here now. ISI doing auto-detection and this gets not exposed to the modem drivers or we do. Like I replied earlier, I don't

Re: [PATCH 0/3] EF-SPN API to sim-atom

2011-02-01 Thread Jukka Saunamaki
Hi On Tue, 2011-02-01 at 22:38 +0200, ext Aki Niemi wrote: That reminds me, I think there are SIMs out there that use the CPHS ONS instead of SPN, and these can be used interchangeably. Jukka, don't you actually also need the ONS? In theory maybe, but in practice so far all cases where

Re: [PATCH v8] ifx: Adding modem selftest for Infineon modem

2011-02-01 Thread Marcel Holtmann
Hi Robertino, Infineon modem selftest, during ifx_enable(). Two steps trigger, with timeout. In case one fails, modem will not power up. --- plugins/ifx.c | 58 ++-- 1 files changed, 51 insertions(+), 7 deletions(-) diff --git