Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Denis Kenzior
Hi Kai, > So handling this might still be useful even if reliable re-enabling > of messages would not work reliably (assumption being that recycling and > reregistering will reliably reenable message delivery). Or do you have > practical experience of cases where even a power cycle won't help...

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Kai, > > So yes, there might be conditions where you crash before fsync really > > completes and you lose the SMS. However, there's nothing in the world > > you can do about this case anyway, since both the write and the fsync > > succeeded. > > I think this is perfectly reasonable. Even if s

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Kai, > >> - The history agent does not wait until the agent replies it has > >> handled the message, but instead it calls agent_request_dispatch > >> and then already returns to core (which acks the message to modem). > > > > I know this actually. The missing piece is the storing to disk h

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hi Denis, On 02 Feb 2011, Denis Kenzior wrote: > Another fun fact about CMT delivery is that if you do not ack in a > 'reasonable' amount of time, the modem _silently_ turns off SMS > delivery. So putting acks over D-Bus is simply a bad idea. ack, very much agreed. And now that I realized RX fra

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hello Marcel, On 02 Feb 2011, Marcel Holtmann wrote: >> - This relates to another TODO -> persistant storage of RX-TPDUs >>for incomplete messages. If we've acked a TPDU to network, >>we must have stored it to persistant storage. > > Where are we not doing this. We do store t

Re: [RFC] voicecall API changes (proposal 2)

2011-02-02 Thread Denis Kenzior
Hi Andras, > + > + boolean ForwardedCall > + > + Contains the indication whether the incoming voice call > + is a redirected call due to a call forwarding operation > + or not. Please drop the Call suffix, you are already on

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Mikhail, > > How is this any better? If all messages get send when the agents > > registers to oFono. And we can easily use D-Bus results to either > > delete > > messages from the spool or not. Since D-Bus is asynchronous and that > > will just work out fine. > > Am I right in assuming that t

Re: [PATCH] smart-messaging: set agent to NULL after free

2011-02-02 Thread Denis Kenzior
Hi Lucas, On 02/02/2011 12:53 PM, Lucas De Marchi wrote: > If agent is not set to NULL after it's freed, the following situation > would not work: > > smart_messaging_register_agent() > smart_messaging_unregister_agent() > smart_messaging_register_agent() > > And this one could potentially crash

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Denis Kenzior
Hi Mikhail, > > Am I right in assuming that the SMS history roundtrip is not performed before > acking the constituent TPDUs to the network? If it is, we have problems even > regardless of D-Bus method call timeouts. > This has been discussed to death a bazillion times. So lets recap very qu

[PATCH] smart-messaging: set agent to NULL after free

2011-02-02 Thread Lucas De Marchi
If agent is not set to NULL after it's freed, the following situation would not work: smart_messaging_register_agent() smart_messaging_unregister_agent() smart_messaging_register_agent() And this one could potentially crash oFono: smart_messaging_register_agent() smart_messaging_unregister_agent

RE: [PATCH v8] ifx: Adding modem selftest for Infineon modem

2011-02-02 Thread Ramakrishna, AnandX
Hi Marcel, I am resending this email as MS outlook was fast before I could format the message. Sorry for that. -Original Message- From: Ramakrishna, AnandX Sent: Wednesday, February 02, 2011 10:08 AM To: ofono@ofono.org Subject: RE: [PATCH v8] ifx: Adding modem selftest for Infineon mod

Re: [PATCH 1/8] bluetooth: add server support

2011-02-02 Thread Gustavo F. Padovan
Hi Frederic, * Frederic Danis [2011-02-01 15:17:56 +0100]: > Hello Gustavo, > > Le 31/01/2011 21:51, Gustavo F. Padovan a écrit : > > Initial code to have support to listen over a RFCOMM socket for incoming > > connections. > > --- > > Makefile.am |1 + > > plugins/bluetooth.c |

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Predon, Frederic
Hi Marcel, > > > I toughth we talked about CFUN=4 in ifx_disable on IRC. This one is > > > needed to bring the modem up in offline mode. I'd rather not remove > > > this > > > one. > > > > In a ideal world, the CFUN=4 in the dlc_setup will not be needed > because the modem remembers is last state

[RFC] voicecall API changes (proposal 2)

2011-02-02 Thread Andras Domokos
--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 17 + doc/voicecallmanager-api.txt | 28 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index 41

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread mikhail.zabaluev
Hi, > -Original Message- > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On > Behalf Of ext Marcel Holtmann > Sent: Wednesday, February 02, 2011 6:44 PM > To: ofono@ofono.org > Subject: RE: [RFC 2/2] doc: Add description for history agent interface > > > here's a few comm

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Marcel Holtmann
Hi Fred, > > > plugins/ifx.c | 21 ++--- > > > 1 files changed, 2 insertions(+), 19 deletions(-) > > > > > > diff --git a/plugins/ifx.c b/plugins/ifx.c > > > index 411c012..ae53193 100644 > > > --- a/plugins/ifx.c > > > +++ b/plugins/ifx.c > > > @@ -345,23 +345,6 @@ error: > > >

RE: [PATCH v8] ifx: Adding modem selftest for Infineon modem

2011-02-02 Thread Ramakrishna, AnandX
Hi Marcel, I am replying to this email behalf of Robertino. I appreciate if you can review my comments/proposed solution before I submit the next patch. -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Tuesday, Februar

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Predon, Frederic
Hi Marcel, > > plugins/ifx.c | 21 ++--- > > 1 files changed, 2 insertions(+), 19 deletions(-) > > > > diff --git a/plugins/ifx.c b/plugins/ifx.c > > index 411c012..ae53193 100644 > > --- a/plugins/ifx.c > > +++ b/plugins/ifx.c > > @@ -345,23 +345,6 @@ error: > > ofono_mode

Re: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Marcel Holtmann
Hi Jeevaka, > plugins/ifx.c | 21 ++--- > 1 files changed, 2 insertions(+), 19 deletions(-) > > diff --git a/plugins/ifx.c b/plugins/ifx.c > index 411c012..ae53193 100644 > --- a/plugins/ifx.c > +++ b/plugins/ifx.c > @@ -345,23 +345,6 @@ error: > ofono_modem_set_powered(m

[PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Jeevaka Badrappan
--- plugins/ifx.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 411c012..ae53193 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -345,23 +345,6 @@ error: ofono_modem_set_powered(modem, FALSE); } -stati

Re: [PATCH 2/2] examples: fix issue with dst print

2011-02-02 Thread Denis Kenzior
Hi Jeevaka, On 02/02/2011 07:10 AM, Jeevaka Badrappan wrote: > --- > examples/nettime.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis. ___ ofono mailing list ofono@ofono.org http://lis

Re: [PATCH 1/2] include: fix comment on dst value

2011-02-02 Thread Denis Kenzior
Hi Jeevaka, On 02/02/2011 07:10 AM, Jeevaka Badrappan wrote: > --- > include/types.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis. ___ ofono mailing list ofono@ofono.org http://lists.

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Kai, > here's a few comments about the SMS delivery part. These apply to > the history plugin interface as well, so not specifically only about > this patchset. and this is just a RFC so I really want comments. > > + void MessageReceived(dict info) > > + > > + In

Re: [PATCH 2/2] voicecall: try harder to avoid Dial mismatches

2011-02-02 Thread Denis Kenzior
Hi Pekka, On 02/02/2011 08:57 AM, Pekka Pessi wrote: > Hi Denis, > > 2011/2/2 Denis Kenzior : >> On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote: >>> From: Pekka Pessi >>> >>> There were some cases where Dial returned an incorrect call object, >>> e.g., after oFono crash and recover. >>> ---

Re: [PATCH 0/3] EF-SPN API to sim-atom

2011-02-02 Thread Denis Kenzior
Hi Jukka, On 02/02/2011 01:19 AM, Jukka Saunamaki wrote: > Hi Denis, > > On Tue, 2011-02-01 at 19:20 -0600, ext Denis Kenzior wrote: >>> There is also this weird corner case when the SIM has no SPN available. >>> AFAIK, a failed read isn't cached, so bootstrapping that particular SIM >>> will inc

Re: [RFC] voice call API changes (proposal)

2011-02-02 Thread Denis Kenzior
Hi Andras, On 02/02/2011 01:51 AM, Andras Domokos wrote: > Hi Denis, > > On 02/01/2011 05:54 PM, ext Denis Kenzior wrote: >> Hi Andras, >> > + > +boolean Forwarded > + > +Contains the indication whether the voice call is a > +forwarded call or n

Re: [PATCH 2/2] voicecall: try harder to avoid Dial mismatches

2011-02-02 Thread Pekka Pessi
Hi Denis, 2011/2/2 Denis Kenzior : > On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote: >> From: Pekka Pessi >> >> There were some cases where Dial returned an incorrect call object, >> e.g., after oFono crash and recover. >> --- >>  src/voicecall.c |   15 +++ >>  1 files changed, 1

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hi, here's a few comments about the SMS delivery part. These apply to the history plugin interface as well, so not specifically only about this patchset. On 01 Feb 2011, Marcel Holtmann wrote: > + void MessageReceived(dict info) > + > + Incoming text message. > +

[PATCH 2/2] examples: fix issue with dst print

2011-02-02 Thread Jeevaka Badrappan
--- examples/nettime.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/nettime.c b/examples/nettime.c index 3843ce2..f586f07 100644 --- a/examples/nettime.c +++ b/examples/nettime.c @@ -59,7 +59,7 @@ static void example_nettime_info_received(struct ofono_nettime

[PATCH 1/2] include: fix comment on dst value

2011-02-02 Thread Jeevaka Badrappan
--- include/types.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/types.h b/include/types.h index 31f2682..d25f409 100644 --- a/include/types.h +++ b/include/types.h @@ -105,7 +105,7 @@ struct ofono_network_time { int mday; /* Day of month [1..31],

RE: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Kjetil ASDAL
Hi Lucas, Lucas wrote: > I don't know about LTE, but I can effectively disable umts in my > huawei modem just by choosing a frequency not available in my country. > Then, when going online the modem is forced to use one of the GSM > ones. That may very well be so, but I still think this is at

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-02 Thread Aki Niemi
On Wed, 2011-02-02 at 10:03 +0100, ext Andreas WESTIN wrote: > On 2011-02-01 20:32, Aki Niemi wrote: > > Like I replied earlier, I don't see the need for this. Also, it will not > > work well with the isiusb plugin, which has the potential to work with > > any ISI modem. I'm not willing to break th

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Lucas De Marchi
Hi Kjetil, On Wed, Feb 2, 2011 at 10:00 AM, Kjetil ASDAL wrote: > When you say "band selection", I assume you are talking about frequency bands. > AFAIK, the frequency band is a setting within the radio access technology, and > I don't think it is possible to "disable" LTE by deselecting certain

RE: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Kjetil ASDAL
Hi Marcel, Marcel wrote: > Couldn't this be achieved by actual band selection if you really really > wanted this? Do we actually have different LTE band at all. I am still > not all that familiar with the low-level radio technology behind LTE. When you say "band selection", I assume you are tal

[RFC] Fix Uplink data transfer in RawIP mode

2011-02-02 Thread Carlos Pargada
Fix Uplink Data transfer in RawIP mode with IFW Modem Change Data flow from stream mode to PAcket mode between GatRawIP and GatMux. --- gatchat/gatio.c| 98 ++- gatchat/gatio.h|1 + gatchat/gatrawip.c | 75 +

Re: [PATCH] test: test-sms test script added

2011-02-02 Thread Lucas De Marchi
Hi Konrad On Wed, Feb 2, 2011 at 8:44 AM, Konrad Slowinski wrote: > --- >  Makefile.am   |    3 +- >  test/test-sms |  213 > + >  2 files changed, 215 insertions(+), 1 deletions(-) >  create mode 100755 test/test-sms It's good to have scri

Re: [PATCH] test: test-sms test script added

2011-02-02 Thread Marcel Holtmann
Hi Konrad, > Makefile.am |3 +- > test/test-sms | 213 > + > 2 files changed, 215 insertions(+), 1 deletions(-) > create mode 100755 test/test-sms patch has been applied. I like this. Can we get a few more of these style test scri

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-02 Thread Marcel Holtmann
Hi Aki, > > > +enum isi_version { > > > + ISI_20 = 0, > > > + ISI_25 = 1 > > > +}; > > > > so what is the final decision here now. ISI doing auto-detection and > > this gets not exposed to the modem drivers or we do. > > Like I replied earlier, I don't see the need for this. Also, it will not >

[PATCH] test: test-sms test script added

2011-02-02 Thread Konrad Slowinski
--- Makefile.am |3 +- test/test-sms | 213 + 2 files changed, 215 insertions(+), 1 deletions(-) create mode 100755 test/test-sms diff --git a/Makefile.am b/Makefile.am index a38fcb9..758fb10 100644 --- a/Makefile.am +++ b/Makefile.a

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Marcel Holtmann
Hi Sjur, > >> > The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are > >> > suggesting something like 'all-but-lte', right? > >> I think it would be nice if user could be able to select multiple > >> preferred bands, not just only one. The use case I came up with was > >> this 'all

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Sjur Brændeland
Hi Marcel & Aki >> > The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are >> > suggesting something like 'all-but-lte', right? >> I think it would be nice if user could be able to select multiple >> preferred  bands, not just only one. The use case I came up with was >> this 'all-bu

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Rémi Denis-Courmont
On Wednesday 02 February 2011 11:42:42 ext Marcel Holtmann, you wrote: > Right now I have no idea on how the hardware will ever support this > properly. RAT selection is already so different that I prefer to keep it > like this. It is simple. We can cross the LTE bridge once this becomes a > real p

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Marcel Holtmann
Hi Paavo, > > The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are > > suggesting something like 'all-but-lte', right? > I think it would be nice if user could be able to select multiple > preferred bands, not just only one. The use case I came up with was > this 'all-but-lte'. ca

Re: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Paavo Leinonen
Hi Aki, On 02/01/2011 10:25 PM, Aki Niemi wrote: The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are suggesting something like 'all-but-lte', right? I think it would be nice if user could be able to select multiple preferred bands, not just only one. The use case I came up with

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-02 Thread Andreas WESTIN
Hi Aki, On 2011-02-01 20:32, Aki Niemi wrote: Like I replied earlier, I don't see the need for this. Also, it will not work well with the isiusb plugin, which has the potential to work with any ISI modem. I'm not willing to break that potential until we just absolutely have to. U8500 uses shrm

Re: [PATCH 0/5 v3] Neighbor Cell Info Atom

2011-02-02 Thread Antti Paila
Hi, What is the status of this set of patches? Do we still need more time for review or can neighbor cell info atom be integrated to oFono? Original patch set was submitted on 12/01/2011. Best Regards, Antti ___ ofono mailing list ofono@ofono.org htt