Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

2011-02-17 Thread Aki Niemi
Hi Andreas, 2011/2/16 Andreas WESTIN andreas.wes...@stericsson.com: This UICC stuff seems to be leftovers form patch 8/18. Well they are related to SMS, debug prints. But yes they are also UICC. Do you want them in patch 8 ? That would be my preference. That is, a patch to bring in the

Re: [PATCH 17/18] isimodem: CBS for wgmodem2.5

2011-02-17 Thread Andreas WESTIN
Hi Denis, On 2011-02-16 17:10, Denis Kenzior wrote: Hi Andreas, Have you thought of adapting cbs_extract_topic_ranges function for all of this somehow? Yes we are looking at it now. Cheers Andreas ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/2] emulator: add dialing support

2011-02-17 Thread Guillaume Zajac
Hi Gustavo, On 16/02/2011 22:41, Gustavo F. Padovan wrote: It handles client ATD*99# request and then initiate the PPP negotiation. IP forward through the new ppp interface is not done yet. Initially based on patches from Zhenhua Zhangzhenhua.zh...@intel.com --- src/emulator.c | 113

[PATCH] test-server:Add test of PPP disconnect reason

2011-02-17 Thread Guillaume Zajac
--- gatchat/test-server.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index e574d64..c0a5a4d 100644 --- a/gatchat/test-server.c +++ b/gatchat/test-server.c @@ -137,6 +137,12 @@ static void

Re: [PATCH 2/2] emulator: add dialing support

2011-02-17 Thread Gustavo F. Padovan
Hi Guillaume, * Guillaume Zajac guillaume.za...@linux.intel.com [2011-02-17 14:27:31 +0100]: Hi Gustavo, On 16/02/2011 22:41, Gustavo F. Padovan wrote: It handles client ATD*99# request and then initiate the PPP negotiation. IP forward through the new ppp interface is not done yet.

[PATCH 0/2] Fix reference handling in hfp_ag

2011-02-17 Thread Frédéric Dalleau
Hi, these patch fixes reference handling in hfp_ag. First patch makes sure that GATServer properly disconnects client when modem is put offline. Second patch fixes a Glib warning about a socket closed twice. dun_gw may need something similar. Frédéric Dalleau (2): emulator: unref GIOChannel

[PATCH 1/2] emulator: unref GIOChannel after creation

2011-02-17 Thread Frédéric Dalleau
--- src/emulator.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index 567692d..5744903 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -75,6 +75,8 @@ void ofono_emulator_register(struct ofono_emulator *em, int fd) if

[PATCH 2/2] hfp_ag: Do not close client fd on unref

2011-02-17 Thread Frédéric Dalleau
--- plugins/hfp_ag.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/plugins/hfp_ag.c b/plugins/hfp_ag.c index cbf3ccd..cb4a0be 100644 --- a/plugins/hfp_ag.c +++ b/plugins/hfp_ag.c @@ -40,7 +40,6 @@ static struct server *server; static guint modemwatch_id;

Re: [PATCH 0/2] Fix reference handling in hfp_ag

2011-02-17 Thread Denis Kenzior
Hi Frédéric, On 02/17/2011 09:55 AM, Frédéric Dalleau wrote: Hi, these patch fixes reference handling in hfp_ag. First patch makes sure that GATServer properly disconnects client when modem is put offline. Second patch fixes a Glib warning about a socket closed twice. dun_gw may need

Re: [PATCH] test-server:Add test of PPP disconnect reason

2011-02-17 Thread Denis Kenzior
Hi Guillaume, On 02/17/2011 07:48 AM, Guillaume Zajac wrote: --- gatchat/test-server.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index e574d64..c0a5a4d 100644 --- a/gatchat/test-server.c +++

Re: [PATCH] test-server:Add test of PPP disconnect reason

2011-02-17 Thread Guillaume Zajac
Hi Denis, On 17/02/2011 17:14, Denis Kenzior wrote: Hi Guillaume, On 02/17/2011 07:48 AM, Guillaume Zajac wrote: --- gatchat/test-server.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index e574d64..c0a5a4d

[PATCH] bluetooth: remove unneeded g_io_channel_shutdown

2011-02-17 Thread Frédéric Danis
--- plugins/hfp_ag.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/plugins/hfp_ag.c b/plugins/hfp_ag.c index 6acb4dd..6edd73d 100644 --- a/plugins/hfp_ag.c +++ b/plugins/hfp_ag.c @@ -95,19 +95,19 @@ static void hfp_ag_connect_cb(GIOChannel *io, GError *err,

Re: [PATCH] test-server:Add test of PPP disconnect reason

2011-02-17 Thread Guillaume Zajac
Hi Denis, On 17/02/2011 17:50, Denis Kenzior wrote: Hi Guillaume, On 02/17/2011 10:37 AM, Guillaume Zajac wrote: Hi Denis, On 17/02/2011 17:14, Denis Kenzior wrote: Hi Guillaume, On 02/17/2011 07:48 AM, Guillaume Zajac wrote: --- gatchat/test-server.c |6 ++ 1 files changed,

[PATCH] emulator: force creation of atom at modem offline state

2011-02-17 Thread Frédéric Danis
this allows to fix problem when atom created in online state are destroyed when modem goes to offline state --- src/emulator.c |3 ++- src/modem.c| 14 ++ src/ofono.h|5 + 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/src/emulator.c

[PATCH] test-server:Add test of PPP disconnect reason to avoid crash

2011-02-17 Thread Guillaume Zajac
--- gatchat/test-server.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index e574d64..28bad1d 100644 --- a/gatchat/test-server.c +++ b/gatchat/test-server.c @@ -137,6 +137,12 @@ static void

Re: [PATCH] test-server:Add test of PPP disconnect reason to avoid crash

2011-02-17 Thread Denis Kenzior
Hi Guillaume, On 02/17/2011 11:27 AM, Guillaume Zajac wrote: --- gatchat/test-server.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 7/9] message-waiting: Watch for changes to relevant SIM files.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: --- src/message-waiting.c | 88 - 1 files changed, 87 insertions(+), 1 deletions(-) diff --git a/src/message-waiting.c b/src/message-waiting.c index 72cf582..f5406ca 100644

Re: [PATCH 8/9] call-forwarding: Watch for changes to relevant SIM files.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: --- src/call-forwarding.c | 39 +-- 1 files changed, 37 insertions(+), 2 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index d13f990..d610521 100644 ---

Re: [PATCH 1/9] modem.c: Go to PRE_SIM modem state on OFONO_SIM_STATE_INSERTED.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: The assumption so far was that SIM state would only go from NOT_PRESENT - INSERTED - READY - NOT_PRESENT because there's no method to unauthenticate from SIM without removing. We need to be able to switch to INSERTED when SIM is

Re: [PATCH 2/9] sim: Implement basic Refresh.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: --- src/ofono.h |4 ++ src/sim.c | 163 ++ 2 files changed, 155 insertions(+), 12 deletions(-) Patch has been applied, but some comments below: + if

Re: [PATCH 3/9] sim: Watch for changes to relevant SIM files.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: The watch callbacks are notified when a watched file is changed during a Refresh. Currently in most of the callbacks we free all the information read from the file, and schedule a re-read. I wonder if we need some sort of check if

Re: [PATCH 4/9] voicecall: Watch for changes to relevant SIM files.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: --- src/voicecall.c | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 5/9] network: Watch for changes to relevant SIM files.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: --- src/network.c | 66 + 1 files changed, 66 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 9/9] stk: Partially handle Refresh command.

2011-02-17 Thread Denis Kenzior
Hi Andrew, On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote: Only the four NAA initialisation modes are handled at the moment. --- src/stk.c | 65 + 1 files changed, 65 insertions(+), 0 deletions(-) Patch has been applied,

[PATCH 2/5] bluetooth: add a bluetoothd connect watch

2011-02-17 Thread Gustavo F. Padovan
This fix a issue with sending DBus messages when bluetoothd is not up yet. --- plugins/bluetooth.c | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 32be96e..8ca9f5f 100644 --- a/plugins/bluetooth.c

[PATCH 1/5] bluetooth: move find_adapter_cb to better place.

2011-02-17 Thread Gustavo F. Padovan
--- plugins/bluetooth.c | 52 +- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 175ebaa..32be96e 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -633,6 +633,32 @@

[PATCH 3/5] bluetooth: change how we report DBus errors

2011-02-17 Thread Gustavo F. Padovan
--- plugins/bluetooth.c | 33 - 1 files changed, 20 insertions(+), 13 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 8ca9f5f..161ae4b 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -267,19 +267,16 @@ static void

[PATCH 4/5] bluetooth: fix crash by removing record

2011-02-17 Thread Gustavo F. Padovan
When bluetoothd is not running we should not call RemoveRecord() --- plugins/bluetooth.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 161ae4b..5f2d80d 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c

[PATCH 5/5] bluetooth: add DBG() messages

2011-02-17 Thread Gustavo F. Padovan
--- plugins/bluetooth.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 5f2d80d..7c2d5b0 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -280,6 +280,8 @@ static void device_properties_cb(DBusPendingCall

[PATCH] atmodem: CEREG support for LTE network status reporting in AT modem

2011-02-17 Thread Tomasz Gregorek
From: Tomasz Gregorek tomasz.grego...@stericsson.com This is a proposal for CEREG support based on the AT modem. Support in driver should work, though I have an issue with the core. The core has one gprs status currently. In case of having second status for LTE, there is need of having two

Re: [PATCH 1/5] bluetooth: move find_adapter_cb to better place.

2011-02-17 Thread Marcel Holtmann
Hi Gustavo, plugins/bluetooth.c | 52 +- 1 files changed, 26 insertions(+), 26 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/5] bluetooth: add a bluetoothd connect watch

2011-02-17 Thread Marcel Holtmann
Hi Gustavo, This fix a issue with sending DBus messages when bluetoothd is not up yet. --- plugins/bluetooth.c | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) patch has been applied. Regards Marcel ___ ofono

Re: [PATCH 4/5] bluetooth: fix crash by removing record

2011-02-17 Thread Marcel Holtmann
Hi Gustavo, When bluetoothd is not running we should not call RemoveRecord() --- plugins/bluetooth.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list

Re: [PATCH 5/5] bluetooth: add DBG() messages

2011-02-17 Thread Marcel Holtmann
Hi Gustavo, plugins/bluetooth.c |4 1 files changed, 4 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono