[RFC PATCH 5/5] isimodem: implement SSN handling

--- drivers/isimodem/voicecall.c | 359 ++ 1 files changed, 359 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 9507255..165f3b4 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem/v

[RFC PATCH 4/5] atmodem: implement SSN handling

--- drivers/atmodem/voicecall.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index ee055da..7d70c85 100644 --- a/drivers/atmodem/voicecall.c +++ b/drivers/atmodem/voicec

[RFC PATCH 3/5] voicecall: implement SSN handling functions

--- src/voicecall.c | 174 +++ 1 files changed, 174 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index ec001c0..7eee7dd 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -70,6 +70,8 @@ struct voicecall {

[RFC PATCH 2/5] voicecall: add SSN function declarations

--- include/voicecall.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index f00eb08..5e6da02 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -160,6 +160,12 @@ void ofono_voicecall_set_data(struct ofono_voicecal

[RFC PATCH 1/5] ssn: remove SSN atom completely

--- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147 - drivers/isimodem/isimodem.c |2 - drivers/isimodem/isimodem.h |3 - drivers/isimodem/ssn.c | 503 --

[PATCH 0/5] Voice call SS notifications (4th version)

Implementation proposal for handling some of the voice call related Supplementary Services (SS) notifications. Implementation details: - removed SSN atom and all the dependencies - (re)implemented voice call SS notification handling framework - added voice call SS notification handling to AT modem

Re: patch to fix BMC #13679 Huawei EM770: ofonod crash when disable/enable 3G technology

Hi Martin, On 03/04/2011 12:53 AM, Xu, Martin wrote: > Hi Denis: > >>> struct ofono_gprs *gprs; >>> struct ofono_gprs_context *gc; >>> gboolean voice; >>> + gboolean online; >> >> I don't think you really need this one, you can use the presence of gprs >> atom instead. > Gprs atom i

Re: [PATCH 2/2] mbmmodem: do not check for NULL pointer

Hi Lucas, > cb_data_new() uses g_new0(), hence there's no need to check the return > value being NULL. > --- > drivers/mbmmodem/location-reporting.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) patch has been applied. Thanks. Regards Marcel

Re: [PATCH 1/2] huawei: do not check for NULL pointer

Hi Lucas, > cb_data_new() uses g_new0(), hence there's no need to check the return > value being NULL. > --- > plugins/huawei.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono

Re: [PATCH] Fix huawei_disconnect function issue

Hi Marcel, On Fri, Mar 4, 2011 at 8:04 AM, Marcel Holtmann wrote: > Anyhow, we need to get rid of the if (cbd == NULL) check first. A while > back we changed cb_data_new() to use g_new0() instead of g_try_new0() to > simplify the code. So first that should be all cleaned up. > > A quick grep show

[PATCH 1/2] huawei: do not check for NULL pointer

cb_data_new() uses g_new0(), hence there's no need to check the return value being NULL. --- plugins/huawei.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 6f05677..afa804d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c

[PATCH 2/2] mbmmodem: do not check for NULL pointer

cb_data_new() uses g_new0(), hence there's no need to check the return value being NULL. --- drivers/mbmmodem/location-reporting.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index b76a5c

Re: [RFC PATCH 2/3] voicecall: add SSN handling functions

Hi Denis, On 03/03/2011 10:03 PM, ext Denis Kenzior wrote: Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- include/types.h |2 + include/voicecall.h |6 ++ src/voicecall.c | 156 +++ 3 files changed, 164 inserti

Re: [RFC PATCH 1/3] ssn: remove SSN atom completely

Hi Denis, On 03/03/2011 09:51 PM, ext Denis Kenzior wrote: Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147 ---

Re: [PATCH] gisi: M6 coding style violation corrections

Hi Antti, 2011/3/4 Antti Paila : > --- >  gisi/iter.c |   16 >  1 files changed, 8 insertions(+), 8 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Fix huawei_disconnect function issue

Hi Martin, > huawei_disconnect is used to recovery the io and gprs context when > io error happends, see commit 39382730d7758b093ca6271f4e9dea875fa04b3a > However, io error not only happends at PPP disconnect, in theory it > can happends at any situation. I also observed that it happens when modem

[PATCH] Fix usage of test/test-call-settings: add missing properties

--- test/test-call-settings |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/test/test-call-settings b/test/test-call-settings index 187b405..97cec86 100755 --- a/test/test-call-settings +++ b/test/test-call-settings @@ -15,7 +15,10 @@ def property_changed(name, value):

[PATCH] Add the possibility to specify the modem in test/test-call-settings

--- test/test-call-settings | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/test/test-call-settings b/test/test-call-settings index f31fd1a..187b405 100755 --- a/test/test-call-settings +++ b/test/test-call-settings @@ -14,15 +14,12 @@ def property_chang

[PATCH] Allow test/test-call-settings to exit if new value is equal to actual value

--- test/test-call-settings |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/test/test-call-settings b/test/test-call-settings index f49ad0b..f31fd1a 100755 --- a/test/test-call-settings +++ b/test/test-call-settings @@ -62,6 +62,10 @@ if __name__ == "__main__":

[PATCH] gisi: M6 coding style violation corrections

--- gisi/iter.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gisi/iter.c b/gisi/iter.c index f3f6f5a..8308c00 100644 --- a/gisi/iter.c +++ b/gisi/iter.c @@ -56,7 +56,7 @@ void g_isi_sb_iter_init_full(GIsiSubBlockIter *iter, const GIsiMessage *msg,