Re: [PATCH] call-forwarding: fix for showing call forwarding states

2011-03-11 Thread Denis Kenzior
Hi Jussi, On 03/09/2011 04:27 AM, Jussi Kangas wrote: > --- > Hi, > > Here is a fix for call forwarding issue Jarko found a while back. ( TODO > issue "Call forwarding state handling change" and mailing list > conversation "Ofono CF states not always correct" ). > > Br, > Jussi > > src/call-fo

RE: [PATCH 1/3] ifx: integration of kernel mux (n_gsm) and its line discipline

2011-03-11 Thread Marcel Holtmann
Hi Guillaume, > > > diff --git a/plugins/ifx.c b/plugins/ifx.c > > > index 527a8c4..9c2a5c1 100644 > > > --- a/plugins/ifx.c > > > +++ b/plugins/ifx.c > > > @@ -26,8 +26,12 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > +#include > >

Re: [PATCH] atmodem: Enable network time for AT modem

2011-03-11 Thread Marcel Holtmann
Hi Antti, > > > drivers/atmodem/network-registration.c |2 ++ > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/atmodem/network-registration.c > > > b/drivers/atmodem/network-registration.c > > > index 4913611..2d589f0 100644 > > > --- a/drivers/atmodem

Re: [PATCH] simfs: fix GLib-CRITICAL issue occuring when there is no SIM card.

2011-03-11 Thread Denis Kenzior
Hi Guillaume, On 03/09/2011 06:32 AM, Lucas, GuillaumeX wrote: > From: Guillaume Lucas > > During modem release, when there is no SIM card, a GLib-CRITICAL > issue occurs during the free of the sim fs context. > --- > src/simfs.c | 26 ++ > 1 files changed, 14 insertio

Re: [PATCH] TODO: mark 'GPS power control atom' task as done

2011-03-11 Thread Denis Kenzior
Hi Lucas, On 03/11/2011 02:29 PM, Lucas De Marchi wrote: > --- > TODO | 11 --- > doc/features.txt |8 > 2 files changed, 8 insertions(+), 11 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mai

Re: [PATCH] stk: fix issue with null data object

2011-03-11 Thread Denis Kenzior
Hi Andrew, On 03/11/2011 03:39 AM, Andrzej Zaborowski wrote: > This will let the caller correctly detect NULL alpha id. > --- > src/stkutil.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis

[PATCH] stk: fix issue with null data object

2011-03-11 Thread Andrzej Zaborowski
This will let the caller correctly detect NULL alpha id. --- src/stkutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index abd1c99..c64cb7a 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -309,7 +309,7 @@ static gboolean parse_dataobj

[PATCH] TODO: mark 'GPS power control atom' task as done

2011-03-11 Thread Lucas De Marchi
--- TODO | 11 --- doc/features.txt |8 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/TODO b/TODO index c432cba..9db9e0b 100644 --- a/TODO +++ b/TODO @@ -444,17 +444,6 @@ Miscellaneous Complexity: C8 Owner: Jukka Saunamäki -- Add suppor

Re: [PATCH] dun_gw: Fix automatic GIOChannel closing when a bluetooth connection is attempted.

2011-03-11 Thread Denis Kenzior
Hi Guillaume, On 03/11/2011 07:39 AM, Guillaume Zajac wrote: > --- > plugins/dun_gw.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.

Re: [PATCH v2] test/test-message-waiting: Add a new test file to validate org.ofono.MessageWaiting

2011-03-11 Thread Denis Kenzior
Hi Bertrand, On 03/09/2011 07:31 AM, Bertrand Aygon wrote: > --- > Makefile.am |3 ++- > test/test-message-waiting | 40 > 2 files changed, 42 insertions(+), 1 deletions(-) > create mode 100755 test/test-message-waiting > Patch has b

Re: [PATCH] Isimodem: Crash while setting SCA

2011-03-11 Thread Denis Kenzior
Hi Arun, On 03/11/2011 06:49 AM, ext-arun.1.ravind...@nokia.com wrote: > From: Arun Ravindran > > --- > drivers/isimodem/sms.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > I applied the patch, however... > diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c > inde

Re: [PATCH] atmodem: fix PB reading when fields are omitted

2011-03-11 Thread Denis Kenzior
Hi Paavo, On 03/11/2011 06:25 AM, Paavo Leinonen wrote: > Fix SIM PB reading when numeric fields have been omitted. > > --- > > Hi, > > Here is the fix for SIM PB reading as proposed. > > BR, > Paavo > > drivers/atmodem/phonebook.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions

Re: [RFC PATCH 3/5] voicecall: implement SSN handling functions

2011-03-11 Thread Denis Kenzior
Hi Andras, > +static struct voicecall *voicecall_select(struct ofono_voicecall *vc, > + unsigned int id, int code) > +{ > + struct voicecall *v = NULL; > + GSList *l; > + > + if (id != 0) { > + l = g_slist_find_custom(vc->call_lis

Re: [PATCH 0/5] Voice call SS notifications (4th version)

2011-03-11 Thread Denis Kenzior
Hi Andras, On 03/04/2011 11:12 AM, Andras Domokos wrote: > Implementation proposal for handling some of the voice call > related Supplementary Services (SS) notifications. > > Implementation details: > - removed SSN atom and all the dependencies > - (re)implemented voice call SS notification hand

Re: Setting PDP mode

2011-03-11 Thread Denis Kenzior
Hi claudio, On 03/10/2011 02:33 AM, claudio wrote: > > Hi, > > It's possible to set the pdp mode through ofono ? I need to set the pdp > mode to auto, ip and ppp, I'm not sure what you mean by 'auto' pdp mode. The protocol selection (IP, IPv6 or dual stack IPv4 & IPv6 combined) is currently wo

Re: Request for info for issuing AT commands

2011-03-11 Thread Denis Kenzior
Hi Debanjan, On 03/11/2011 12:08 AM, Debanjan Biswas (debiswas) wrote: > Thanks for the info Bertrand. I will have a look. A gentle reminder to not top-post on this mailing list. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono

RE: Setting PDP mode

2011-03-11 Thread Aygon, Bertrand
> Hi, > > It's possible to set the pdp mode through ofono ? I need to set the pdp > mode to auto, ip and ppp, > > What are the dbus interface and properties to use ? Hi, You should have a look at doc/connman-api.txt. In the org.ofono.ConnectionContext interface, there is a 'Protocol' properties.

RE: [HELP Required]Routing Of SCO data to BT Host Speaker

2011-03-11 Thread milan.satpathy
Hi Daniel, Thanks for the quick assistance. I tried the same approach as suggested by you. Steps: -- 1.$pacmd 2.$list-sources ( got 2 sources ) name: (and) name: 3.$list-sinks ( got 1 sink ) name: 4.created a shell script "ofono.sh" with contents as below: pactl load-module mod

[PATCH] dun_gw: Fix automatic GIOChannel closing when a bluetooth connection is attempted.

2011-03-11 Thread Guillaume Zajac
--- plugins/dun_gw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/dun_gw.c b/plugins/dun_gw.c index 53edc74..3bc4836 100644 --- a/plugins/dun_gw.c +++ b/plugins/dun_gw.c @@ -101,7 +101,7 @@ static void dun_gw_connect_cb(GIOChannel *io, GError *err, gpointer us

[PATCH] Isimodem: Crash while setting SCA

2011-03-11 Thread ext-arun . 1 . ravindran
From: Arun Ravindran --- drivers/isimodem/sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c index 957b342..c90c06d 100644 --- a/drivers/isimodem/sms.c +++ b/drivers/isimodem/sms.c @@ -292,7 +292,7 @@ static void isi_sc

Re: [PATCH] atmodem: Enable network time for AT modem

2011-03-11 Thread Antti Paila
Hi Marcel, On Tue, 2011-03-08 at 09:12 -0800, ext Marcel Holtmann wrote: > Hi Antti, > > > drivers/atmodem/network-registration.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/atmodem/network-registration.c > > b/drivers/atmodem/network-registrati

[PATCH] atmodem: fix PB reading when fields are omitted

2011-03-11 Thread Paavo Leinonen
Fix SIM PB reading when numeric fields have been omitted. --- Hi, Here is the fix for SIM PB reading as proposed. BR, Paavo drivers/atmodem/phonebook.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/phonebook.c b/drivers/atmodem/phonebook.c index 9

[PATCH 08/12] gatchat: fix gatsyntax to support +CPOS

2011-03-11 Thread Jarko Poutiainen
--- gatchat/gatsyntax.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index 2fc70b8..f1d896b 100644 --- a/gatchat/gatsyntax.c +++ b/gatchat/gatsyntax.c @@ -64,6 +64,9 @@ static void gsmv1_hint(GAtSyntax *syntax

[PATCH 12/12] test: add test-gnss

2011-03-11 Thread Jarko Poutiainen
--- Makefile.am|3 +- test/test-gnss | 91 2 files changed, 93 insertions(+), 1 deletions(-) create mode 100755 test/test-gnss diff --git a/Makefile.am b/Makefile.am index 3dae7f4..daa5dd0 100644 --- a/Makefile.am +++ b/Makefile.

[PATCH 07/12] gatchat: implementation for +CPOS send

2011-03-11 Thread Jarko Poutiainen
--- gatchat/gatchat.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 3fd564d..64f131d 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -1468,6 +1468,19 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, con

[PATCH 06/12] gatchat:new hint to handle +CPOS

2011-03-11 Thread Jarko Poutiainen
--- gatchat/gatsyntax.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/gatsyntax.h b/gatchat/gatsyntax.h index afc0bd3..2580ec6 100644 --- a/gatchat/gatsyntax.h +++ b/gatchat/gatsyntax.h @@ -29,7 +29,8 @@ extern "C" { enum _GAtSyntaxExpectHint { G_AT_SY

[PATCH 11/12] ofono.conf: add positioning agent interface

2011-03-11 Thread Jarko Poutiainen
--- src/ofono.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ofono.conf b/src/ofono.conf index 0dfa038..8a83cd0 100644 --- a/src/ofono.conf +++ b/src/ofono.conf @@ -13,6 +13,7 @@ + -- 1.7.0.4 _

[PATCH 05/12] gatchat:introduce send for +CPOS

2011-03-11 Thread Jarko Poutiainen
--- gatchat/gatchat.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.h b/gatchat/gatchat.h index 8cbb559..eb82daa 100644 --- a/gatchat/gatchat.h +++ b/gatchat/gatchat.h @@ -124,6 +124,14 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, const char

[PATCH 09/12] atmodem: add gnss driver

2011-03-11 Thread Jarko Poutiainen
--- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 279 + 4 files changed, 286 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/gnss.c diff --git

[PATCH 10/12] ste: add support for gnss

2011-03-11 Thread Jarko Poutiainen
--- plugins/ste.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index efae573..749f673 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -58,6 +58,7 @@ #include #include #include +#include #include #include @@ -65,17 +66,

[PATCH 04/12] src: add gnss atom and agent implementation

2011-03-11 Thread Jarko Poutiainen
--- Makefile.am |3 +- src/gnss.c | 357 +++ src/gnssagent.c | 152 +++ src/gnssagent.h | 40 ++ 4 files changed, 551 insertions(+), 1 deletions(-) create mode 100644 src/gnss.c create mode 100644 src/gn

[PATCH 02/12] include: add gnss.h file

2011-03-11 Thread Jarko Poutiainen
--- Makefile.am|2 +- include/gnss.h | 76 2 files changed, 77 insertions(+), 1 deletions(-) create mode 100644 include/gnss.h diff --git a/Makefile.am b/Makefile.am index 3f20717..7d6acce 100644 --- a/Makefile.am +++ b/Makefile.

[PATCH 03/12] src: add atom type for gnss

2011-03-11 Thread Jarko Poutiainen
--- src/ofono.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 995a1a5..2c6899e 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -131,6 +131,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_EMULATOR_DUN, OFONO_ATOM_TYPE_EMULATOR_HF

[PATCH 01/12] dbus: add gnss interface definition

2011-03-11 Thread Jarko Poutiainen
--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 19a138a..bf3e8a4 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -56,6 +56,8 @@ extern "C" { #define OFONO_STK_INTERFACE OFONO_SERVICE ".SimToolkit" #define OFON

[PATCH 00/12] basic E911 support

2011-03-11 Thread Jarko Poutiainen
Hi, This is second attempt to provide implementation for basic E911 support. Br, Jarko Jarko Poutiainen (12): dbus: add gnss interface definition include: add gnss.h file src: add atom type for gnss src: add gnss atom and agent implementation gatchat:introduce send for +CPOS gatchat:

RE: [PATCH 1/2] stk: fix issue with null data object

2011-03-11 Thread Jeevaka.Badrappan
Hi Andrew, Andrzej Zaborowski wrote: > Hi Jeevaka > > On 7 March 2011 16:35, Jeevaka Badrappan > wrote: >> As per the specification, if alphad identifier is provided and is a >> null data object, no information should be given to the user. > > What do do you think of the following change? > >

Re: [PATCH 6/9] gatchat: fix gatsyntax to support +CPOS

2011-03-11 Thread Jarko Poutiainen
Hi Denis, On Fri, 2011-03-11 at 01:11 +0200, Denis Kenzior wrote: > Hi Jarko, > > Fair enough, sorry for 'shooting the messenger' so to speak ;) > Non taken. :) > Essentially. You might have to define a new syntax hint for this > prompt, namely EXPECT_BROKEN_PROMPT or something like that. > O