Re: Reg: Supporting Operator Preferred List in oFono

2011-03-24 Thread Sankar
Hi Denis, On Wed, Mar 23, 2011 at 7:56 PM, Denis Kenzior denk...@gmail.com wrote: Hi Sankar, On 03/23/2011 06:52 AM, Sankar wrote: Hi , I would like to know if there is any proposal to support the Operator Preferred List in oFono. This is being a key feature, allowing the user to

[PATCH] gatserver: add ATF command

2011-03-24 Thread Olivier Guiter
--- gatchat/gatserver.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 57cc58e..8266ead 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -274,7 +274,8 @@ static gboolean

[PATCH] emulator: add AT hook_control_cb() CB and register it

2011-03-24 Thread Guillaume Zajac
--- src/emulator.c | 44 +--- 1 files changed, 41 insertions(+), 3 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c84f0a9..586c7ec 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -177,6 +177,41 @@ error:

[PATCH] gatserver: add v250 ATL and ATM commands

2011-03-24 Thread Olivier Guiter
--- gatchat/gatserver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 8266ead..0381723 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -94,6 +94,8 @@ struct v250_settings { int

[PATCH 1/2] isimodem/sim: added PIN and SIM state handling

2011-03-24 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Using PN_SECURITY resource to obtain PIN statuses. Using ofono_sim_ready_notify() aka __ofono_sim_recheck_pin() to report the ready state. --- drivers/isimodem/debug.c | 59 + drivers/isimodem/debug.h |6 + drivers/isimodem/sim.c | 584

[PATCH 2/2] TODO: remove me from ofono_sim_ready_notify()

2011-03-24 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com __ofono_sim_recheck_pin() is fine by me --- TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index fc65b35..f8926a3 100644 --- a/TODO +++ b/TODO @@ -70,7 +70,6 @@ SIM / SIM File system Priority: High

[PATCH 0/1] isimodem: fix network registration for older modems

2011-03-24 Thread Mika Liljeberg
Hi, Here's a patch to fix network registration with older ISI modems. Verified with N95. Claudio, could you give this a spin and let me know if this fixes the problem for your 6760? Br, MikaL [PATCH 1/1] isimodem: fix network registration for older modems

[PATCH 1/1] isimodem: fix network registration for older modems

2011-03-24 Thread Mika Liljeberg
--- drivers/isimodem/network-registration.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c index a30fc8c..8bf2423 100644 --- a/drivers/isimodem/network-registration.c +++

[PATCH 1/2] gprs: fix memory leak

2011-03-24 Thread Mika Liljeberg
--- src/gprs.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 00f6d6d..f9e327a 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -865,6 +865,7 @@ static void pri_activate_callback(const struct ofono_error *error, void *data)

[PATCH 0/2] GPRS patches

2011-03-24 Thread Mika Liljeberg
Hi, Here's a memory leak fix and a new test script for GPRS. Br, MikaL [PATCH 1/2] gprs: fix memory leak [PATCH 2/2] test: add a script to set any GPRS context property Makefile.am |3 ++- src/gprs.c|2 ++ test/set-context-property | 38

[PATCH 2/2] test: add a script to set any GPRS context property

2011-03-24 Thread Mika Liljeberg
--- Makefile.am |3 ++- test/set-context-property | 38 ++ 2 files changed, 40 insertions(+), 1 deletions(-) create mode 100755 test/set-context-property diff --git a/Makefile.am b/Makefile.am index b0cbcd7..fce9cd8 100644 ---

Re: Reg: Supporting Operator Preferred List in oFono

2011-03-24 Thread Marcel Holtmann
Hi Sankar, I would like to know if there is any proposal to support the Operator Preferred List in oFono. This is being a key feature, allowing the user to add/delete/modify the PLMNSel, PLMNWact files on the card, which are

Re: [PATCH 1/1] isimodem: fix network registration for older modems

2011-03-24 Thread Aki Niemi
Hi Mika, 2011/3/24 Mika Liljeberg mika.liljeb...@nokia.com: ---  drivers/isimodem/network-registration.c |   10 --  1 files changed, 8 insertions(+), 2 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list

Re: [PATCH 1/2] isimodem/sim: added PIN and SIM state handling

2011-03-24 Thread Aki Niemi
Hi Pekka, 2011/3/24 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com Using PN_SECURITY resource to obtain PIN statuses. Using ofono_sim_ready_notify() aka __ofono_sim_recheck_pin() to report the ready state. ---  drivers/isimodem/debug.c |   59 +  

[PATCH 00/12] Basic E911 support

2011-03-24 Thread Jarko Poutiainen
Hi, This is third attempt to provide implementation for basic E911 support. Br, Jarko Jarko Poutiainen (12): dbus: add gnss interface definition include: add gnss.h file src: add atom type for gnss src: add gnss atom and agent implementation gatchat: introduce send for +CPOS

[PATCH 01/12] dbus: add gnss interface definition

2011-03-24 Thread Jarko Poutiainen
--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 38864fb..4dd9db5 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -56,6 +56,8 @@ extern C { #define OFONO_STK_INTERFACE OFONO_SERVICE .SimToolkit #define

[PATCH 02/12] include: add gnss.h file

2011-03-24 Thread Jarko Poutiainen
--- Makefile.am|3 +- include/gnss.h | 69 2 files changed, 71 insertions(+), 1 deletions(-) create mode 100644 include/gnss.h diff --git a/Makefile.am b/Makefile.am index b0cbcd7..bff2374 100644 --- a/Makefile.am +++

[PATCH 04/12] src: add gnss atom and agent implementation

2011-03-24 Thread Jarko Poutiainen
--- Makefile.am |3 +- src/gnss.c | 386 +++ src/gnssagent.c | 158 +++ src/gnssagent.h | 43 ++ 4 files changed, 589 insertions(+), 1 deletions(-) create mode 100644 src/gnss.c create mode 100644

[PATCH 03/12] src: add atom type for gnss

2011-03-24 Thread Jarko Poutiainen
--- src/ofono.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index b9ca314..81570fe 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -132,6 +132,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_EMULATOR_DUN,

[PATCH 06/12] gatchat: new hint to handle +CPOS

2011-03-24 Thread Jarko Poutiainen
--- gatchat/gatsyntax.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/gatsyntax.h b/gatchat/gatsyntax.h index afc0bd3..2580ec6 100644 --- a/gatchat/gatsyntax.h +++ b/gatchat/gatsyntax.h @@ -29,7 +29,8 @@ extern C { enum _GAtSyntaxExpectHint {

[PATCH 07/12] gatchat: implementation for +CPOS send

2011-03-24 Thread Jarko Poutiainen
--- gatchat/gatchat.c | 37 + 1 files changed, 33 insertions(+), 4 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 3fd564d..eeb8d24 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -53,6 +53,7 @@ struct at_command {

[PATCH 05/12] gatchat: introduce send for +CPOS

2011-03-24 Thread Jarko Poutiainen
--- gatchat/gatchat.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.h b/gatchat/gatchat.h index 8cbb559..eb82daa 100644 --- a/gatchat/gatchat.h +++ b/gatchat/gatchat.h @@ -124,6 +124,14 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, const char

[PATCH 08/12] gatchat: fix gatsyntax to support +CPOS

2011-03-24 Thread Jarko Poutiainen
--- gatchat/gatsyntax.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index 2fc70b8..469ffc3 100644 --- a/gatchat/gatsyntax.c +++ b/gatchat/gatsyntax.c @@ -44,6 +44,7 @@ enum GSMV1_STATE {

[PATCH 10/12] ste: add support for gnss

2011-03-24 Thread Jarko Poutiainen
--- plugins/ste.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 36b3148..f7fe2b4 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -57,6 +57,7 @@ #include ofono/gprs-context.h #include ofono/radio-settings.h #include

[PATCH 11/12] ofono.conf: add positioning agent interface

2011-03-24 Thread Jarko Poutiainen
--- src/ofono.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ofono.conf b/src/ofono.conf index 0dfa038..8a83cd0 100644 --- a/src/ofono.conf +++ b/src/ofono.conf @@ -13,6 +13,7 @@ allow send_interface=org.ofono.SimToolkitAgent/ allow

[PATCH 09/12] atmodem: add gnss driver

2011-03-24 Thread Jarko Poutiainen
--- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 282 + 4 files changed, 289 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/gnss.c diff

[PATCH 12/12] test: add test-gnss

2011-03-24 Thread Jarko Poutiainen
--- Makefile.am|3 +- test/test-gnss | 91 2 files changed, 93 insertions(+), 1 deletions(-) create mode 100755 test/test-gnss diff --git a/Makefile.am b/Makefile.am index b5a3d6e..626a310 100644 --- a/Makefile.am +++

Re: [PATCH 5/6] stkutil: Complete the TLV parsing/builder to support BIP commands

2011-03-24 Thread Denis Kenzior
Hi Philippe, struct stk_network_access_name { -unsigned char name[127]; +unsigned char name[100]; unsigned char len; This part really makes no sense. Since you parse it into a string, might as well just use that. All the above comments are just relevant. Thank you for

Re: [PATCH 2/6] stk-api.txt: Describe new d-bus APIs related to BIP commands.

2011-03-24 Thread Denis Kenzior
Hi Philippe, boolean ConfirmCallSetup(string information, byte icon_id) @@ -245,6 +252,7 @@ Methodsbyte RequestSelection(string title, byte icon_id, Possible Errors: [service].Error.SimToolkit.EndSession void DisplayActionInformation(string text,

[PATCH] dun: Add ATX command in emulator (X0 only)

2011-03-24 Thread Olivier Guiter
--- src/emulator.c | 57 +++- 1 files changed, 56 insertions(+), 1 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c84f0a9..101d6b8 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -177,6 +177,59 @@ error:

[PATCH] build: Add gatchat to core sources

2011-03-24 Thread Aki Niemi
Otherwise, --disable-atmodem breaks build. --- Makefile.am |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index b0cbcd7..39d8962 100644 --- a/Makefile.am +++ b/Makefile.am @@ -154,8 +154,7 @@ endif if ATMODEM builtin_modules +=

[PATCH] doc: Complete possible errors

2011-03-24 Thread Philippe Nunes
--- doc/stk-api.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 529c734..f8a115e 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -96,6 +96,7 @@ Methods byte RequestSelection(string title, byte icon_id,

Re: [PATCH] doc: Complete possible errors

2011-03-24 Thread Denis Kenzior
Hi Philippe, On 03/24/2011 11:42 AM, Philippe Nunes wrote: --- doc/stk-api.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

[PATCH] voicecall: fix voicecalls_release_queue

2011-03-24 Thread Frédéric Danis
voicecalls_release_queue uses struct ofono_call instead of struct voicecall (which is used in calls list parameter and function voicecalls_release_next) --- src/voicecall.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index

Re: [PATCH 1/2] gprs: fix memory leak

2011-03-24 Thread Denis Kenzior
Hi Mika, On 03/24/2011 07:32 AM, Mika Liljeberg wrote: --- src/gprs.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Good catch. Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/2] test: add a script to set any GPRS context property

2011-03-24 Thread Denis Kenzior
Hi Mika, On 03/24/2011 07:32 AM, Mika Liljeberg wrote: --- Makefile.am |3 ++- test/set-context-property | 38 ++ 2 files changed, 40 insertions(+), 1 deletions(-) create mode 100755 test/set-context-property Patch has been applied,

Re: [PATCH 2/2] TODO: remove me from ofono_sim_ready_notify()

2011-03-24 Thread Denis Kenzior
Hi Pekka, On 03/24/2011 06:45 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com __ofono_sim_recheck_pin() is fine by me --- TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. Regards, -Denis

Re: [PATCH] gatserver: add ATF command

2011-03-24 Thread Denis Kenzior
Hi Olivier, On 03/24/2011 05:03 AM, Olivier Guiter wrote: --- gatchat/gatserver.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH] gatserver: add v250 ATL and ATM commands

2011-03-24 Thread Denis Kenzior
Hi Olivier, +static void at_l_cb(GAtServer *server, GAtServerRequestType type, + GAtResult *result, gpointer user_data) +{ + s_template_cb(type, result, server, server-v250.s5, L, 0, 3); Copy paste error? I presume you mean v250.l here Regards, -Denis

[PATCH] Set owner CSSU/CSSI support task

2011-03-24 Thread Nicolas Bertrand
--- TODO |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index ed644c9..6769906 100644 --- a/TODO +++ b/TODO @@ -21,3 +21,7 @@ Call Management - Add support for +CSSU / +CSSI notifications. These can be used to simulate the remote party putting the

Re: [PATCH] voicecall: fix voicecalls_release_queue

2011-03-24 Thread Denis Kenzior
Hi Frédéric, On 03/24/2011 12:43 PM, Frédéric Danis wrote: voicecalls_release_queue uses struct ofono_call instead of struct voicecall (which is used in calls list parameter and function voicecalls_release_next) --- src/voicecall.c |4 ++-- 1 files changed, 2 insertions(+), 2