RE: [RFC PATCH 08/20] include: add set preferred ue mode api

2011-04-12 Thread Vijay.Nayani
Hi Denis, -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: 11 April 2011 22:35 To: ofono@ofono.org Cc: Nayani Vijay Subject: Re: [RFC PATCH 08/20] include: add set preferred ue mode api Hi Vijay, On 04/11/2011 05:20 AM, Vijay Nayani wrote: ---

RE: [RFC PATCH 17/20] atmodem: add lte specific functions

2011-04-12 Thread Vijay.Nayani
-Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: 11 April 2011 22:55 To: ofono@ofono.org Cc: Nayani Vijay Subject: Re: [RFC PATCH 17/20] atmodem: add lte specific functions On 04/11/2011 05:20 AM, Vijay Nayani wrote: Changes include: Registration of

RE: [RFC PATCH 20/20] modem: Add netreg watch for tech switch

2011-04-12 Thread Vijay.Nayani
Hi Denis, + case PREFERRED_UE_MODE_CS_PS_DATA_CENTRIC: + /* +* All atoms needs to be created which is +* already done +*/ + break; + } + break; + case

RE: [RFC PATCH 10/20] doc: add PreferredMode property to modem

2011-04-12 Thread Vijay.Nayani
Hi Dennis, data centric. + PS mode 1 UE registers only to EPS + services, and UE's usage setting + is voice centric. + I don't like that this is being exposed on the

RE: [RFC PATCH 17/20] atmodem: add lte specific functions

2011-04-12 Thread Vijay.Nayani
Hi Marcel, Let me thank for the comments. I am happy to see default context stuff dominate our discussion which is kind of my expectation as well. I agree that these things are not so clear from the spec point of view and hopeful that they will shape out via for discussion and some support from

Re: [RFC PATCH 08/20] include: add set preferred ue mode api

2011-04-12 Thread Denis Kenzior
Hi Vijay, +void ofono_modem_set_preferred_ue_mode(struct ofono_modem *modem, int +mode); + Are you assuming that the UE mode cannot be changed? If so, doesn't this map to +CEMODE AT command? Doesn't it allow a set operation to change the UE mode? We have made this currently read

Re: [RFC PATCH 17/20] atmodem: add lte specific functions

2011-04-12 Thread Denis Kenzior
This is really not working out, since you still need to get the interface for this context. The fact that a context is active does not necessarily mean that all the resources have been properly allocated. Namely a gprs-context allocated and all the implications (e.g. AT channel

Re: [RFC PATCH 20/20] modem: Add netreg watch for tech switch

2011-04-12 Thread Denis Kenzior
Hi Vijay, So what exactly needs to be done here? I see this as sort of placeholder for calling enablers for managing atoms. Relevent calls can be made considering access tech and modem operational mode. This would come into play as a result of acess technology switch (CSFB to LTE and

Re: [RFC PATCH 09/20] modem: add preferred ue mode handling

2011-04-12 Thread Denis Kenzior
Hi Vijay, These values are really not telling anyone anything. How do you envision the upper layers using this information? Current preferred mode would show up as part of modem property for EPS modem on the similar lines of onlne,powered,lockdown..etc. Yes, I know what a property is ;)

Re: [RFC PATCH 10/20] doc: add PreferredMode property to modem

2011-04-12 Thread Denis Kenzior
Hi Vijay, I don't like that this is being exposed on the modem interface. This really belongs on a separate atom. Not all modems are going to be LTE enabled yet... Preferred mode is modem property on which mode modem is going to operate. Currently we have restricted this to read only

Re: [RFC PATCH 17/20] atmodem: add lte specific functions

2011-04-12 Thread Denis Kenzior
Hi Vijay, That is still an assumption that needs to be confirmed. So does the default context activation from just uses APN == and then the network picks the APN to activate. Or does it just use the APN value from CID 1 for example. At this point , if the returned cid is out of range

[PATCH] isimodem: fix call_create_resp handling

2011-04-12 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com In case of call creation failure modem may return a valid call id in order to send CALL_SERVICE_DENIED_IND which we do not handle. Fixes MeeGo bug#15855. --- drivers/isimodem/voicecall.c | 39 +-- 1 files changed, 33

[PATCH] isimodem: notify sms-status-reports, too

2011-04-12 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/sms.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c index 6f6b247..40dfa1d 100644 --- a/drivers/isimodem/sms.c +++ b/drivers/isimodem/sms.c @@ -564,6

Re: [PATCH] isimodem: fix call_create_resp handling

2011-04-12 Thread Aki Niemi
Hi Pekka, 2011/4/12 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com In case of call creation failure modem may return a valid call id in order to send CALL_SERVICE_DENIED_IND which we do not handle. Fixes MeeGo bug#15855. ---  drivers/isimodem/voicecall.c |   39

Re: [PATCH] isimodem: notify sms-status-reports, too

2011-04-12 Thread Aki Niemi
Hi Pekka, 2011/4/12 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com ---  drivers/isimodem/sms.c |   11 ++-  1 files changed, 10 insertions(+), 1 deletions(-) I actually ended up pushing a fix for this as part of the wgmodem2.5 additions. Thanks anyway! Cheers, Aki