Re: [RFC PATCH 2/2] network-registration.c: implement CIND for Telit UC864-G

Hi Bernhard, > *UC864 has a incompatible CIND > *use specific constants for a KISS callback function > *add a Telit specific check for "not measurable" strength > > Co-authored-by: Christopher Vogl > Signed-off-by: Bernhard Guillon no signed-off-by lines please. > --- > drivers/atmodem/netwo

Re: [RFC PATCH 1/2] Add basic Telit UC864-G support:

Hi Bernhard, > *add a basic plugin based on different ofono plugins > *use Telit specific QSS for SIM-state > *add verry basic GPS support (usable with gypsy) > *add udev support and rules > *update Makefile > > Co-authored-by: Christopher Vogl > Signed-off-by: Bernhard Guillon we are not usin

Re: [PATCH] voicecall: add +VTS support for HFP emulator

Hi Frédéric, > +static void emulator_vts_cb(struct ofono_emulator *em, > + struct ofono_emulator_request *req, void *userdata) > +{ > + struct ofono_voicecall *vc = userdata; > + struct ofono_error result; > + const char *str; > + > + switch (ofono_emulator_requ

Re: [PATCH 2/4] voicecall: add ATD support for HFP emulator

Hi Frederic, >>> So, I think that voicecall should return an OFONO_ERROR_TYPE_CME 30, and >>> ofono_emulator_send_final should take care of replying the right string. >>> >> >> Nope, you have to take your pick, either CME ERROR: 30, or NO CARRIER. >> I'd expect most implementations to reply with a

Re: [PATCH 2/4] voicecall: add ATD support for HFP emulator

Hello Denis, Le 18/05/2011 18:13, Denis Kenzior a écrit : Hi Frederic, +if (!strncmp(number, "*31#", 4)) { +number += 4; +clir = OFONO_CLIR_OPTION_INVOCATION; +} else if (!strncmp(number, "#31#", 4)) { +number += 4; +clir = OFONO_CLIR_OPTION_SUPPRESSION

Re: [PATCH] emulator: fix dun_ath_cb() not to remove GAtServer io_disconnect() CB

Hi Guillaume, On 05/19/2011 08:03 AM, Guillaume Zajac wrote: > --- > src/emulator.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/emulator.c b/src/emulator.c > index c17b901..251bed8 100644 > --- a/src/emulator.c > +++ b/src/emulator.c > @@ -219,15 +219,19

[PATCH] emulator: fix dun_ath_cb() not to remove GAtServer io_disconnect() CB

--- src/emulator.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..251bed8 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -219,15 +219,19 @@ static void dun_ath_cb(GAtServer *server, GAtServerRequestType type,

Re: Emulator not unregistered while sending ATH0

Hi again Denis, I have found the issue I will submit a fix. See explanations below. On 19/05/2011 14:12, Guillaume Zajac wrote: Hi Denis, I have mixed some stuff concerning GIOChannels... On 19/05/2011 12:13, Guillaume Zajac wrote: Hi Denis, I noticed that when I send +++ -> ATH0 during a P

Re: [PATCH] isimodem: Improper handling of missed call

Hi Arun, 2011/5/18 Arun Ravindran : > +       case CALL_STATUS_MT_RELEASE: > +               if ((call->prev_status == CALL_STATUS_MT_ALERTING) || > +                               (call->prev_status == CALL_STATUS_COMING) || > +                               (call->prev_status == CALL_STATUS_WAIT

Re: Emulator not unregistered while sending ATH0

Hi Denis, I have mixed some stuff concerning GIOChannels... On 19/05/2011 12:13, Guillaume Zajac wrote: Hi Denis, I noticed that when I send +++ -> ATH0 during a PPP session the ppp server is well unregistered. However when the physical layer is removed (bluetooht or TCP), the associated emu

[RFC PATCH 1/2] Add basic Telit UC864-G support:

From: Bernhard Guillon *add a basic plugin based on different ofono plugins *use Telit specific QSS for SIM-state *add verry basic GPS support (usable with gypsy) *add udev support and rules *update Makefile Co-authored-by: Christopher Vogl Signed-off-by: Bernhard Guillon --- Makefile.am

[RFC PATCH 2/2] network-registration.c: implement CIND for Telit UC864-G

From: Bernhard Guillon *UC864 has a incompatible CIND *use specific constants for a KISS callback function *add a Telit specific check for "not measurable" strength Co-authored-by: Christopher Vogl Signed-off-by: Bernhard Guillon --- drivers/atmodem/network-registration.c | 38 +

Emulator not unregistered while sending ATH0

Hi Denis, I noticed that when I send +++ -> ATH0 during a PPP session the ppp server is well unregistered. However when the physical layer is removed (bluetooht or TCP), the associated emulator is not unregistered. As we used in gatutil.c set_close_on_unref(TRUE), it means there is still on re

[PATCH_v6 5/5] connman: add plugin in oFono to request/release private network

--- Makefile.am |3 + plugins/connman.c | 299 + 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 plugins/connman.c diff --git a/Makefile.am b/Makefile.am index e1eaf15..ffb85ae 100644 --- a/Makefile.am +++ b/Mak

[PATCH_v6 4/5] emulator: add request/release private network calls

--- src/emulator.c | 75 --- 1 files changed, 65 insertions(+), 10 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..0a83403 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -25,6 +25,7 @@ #include #include +#in

[PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am

--- Makefile.am |3 +- src/ofono.h |6 +++ src/private-network.c | 91 + 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 src/private-network.c diff --git a/Makefile.am b/Makefile.am index d7e5626..

[PATCH_v6 2/5] private-network: add header into include and Makefile.am

--- Makefile.am |4 +- include/private-network.h | 56 + 2 files changed, 58 insertions(+), 2 deletions(-) create mode 100644 include/private-network.h diff --git a/Makefile.am b/Makefile.am index a413a47..d7e5626 100644 --- a/Makef

[PATCH_v6 1/5] gatppp: Add new contructor to use external fd

--- gatchat/gatppp.c | 33 - gatchat/gatppp.h |1 + gatchat/ppp.h |2 +- gatchat/ppp_net.c | 47 --- 4 files changed, 66 insertions(+), 17 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c in

[PATCH_v6 0/5] Private network request to ConnMan

Hi, With subject and blurb :) I forgot to close fd when ppp_net_new() returns NULL. This version include this change. Guillaume Zajac (5): gatppp: Add new contructor to use external fd private-network: add header into include and Makefile.am private-network: add request/release functions an

[PATCH_v6 5/5] connman: add plugin in oFono to request/release private network

--- Makefile.am |3 + plugins/connman.c | 299 + 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 plugins/connman.c diff --git a/Makefile.am b/Makefile.am index e1eaf15..ffb85ae 100644 --- a/Makefile.am +++ b/Mak

[PATCH_v6 4/5] emulator: add request/release private network calls

--- src/emulator.c | 75 --- 1 files changed, 65 insertions(+), 10 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..0a83403 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -25,6 +25,7 @@ #include #include +#in

[PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am

--- Makefile.am |3 +- src/ofono.h |6 +++ src/private-network.c | 91 + 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 src/private-network.c diff --git a/Makefile.am b/Makefile.am index d7e5626..

[PATCH_v6 1/5] gatppp: Add new contructor to use external fd

--- gatchat/gatppp.c | 33 - gatchat/gatppp.h |1 + gatchat/ppp.h |2 +- gatchat/ppp_net.c | 47 --- 4 files changed, 66 insertions(+), 17 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c in

[PATCH_v6 2/5] private-network: add header into include and Makefile.am

--- Makefile.am |4 +- include/private-network.h | 56 + 2 files changed, 58 insertions(+), 2 deletions(-) create mode 100644 include/private-network.h diff --git a/Makefile.am b/Makefile.am index a413a47..d7e5626 100644 --- a/Makef

[PATCH_v6 0/5] *** SUBJECT HERE ***

*** BLURB HERE *** Guillaume Zajac (5): gatppp: Add new contructor to use external fd private-network: add header into include and Makefile.am private-network: add request/release functions and new feature to Makefile.am emulator: add request/release private network calls connman: ad