[PATCH] sms: Add delay before submitting multiple SMS to modem

2012-08-22 Thread Guillaume Zajac
For 3GPP GSM test case 34.2.9.1 and 34.2.9.1 and WCDMA test case 16.1.9.1 and 16.1.9.2, we need to transmitmultiple SMS using same RRC channel. oFono needs to wait its tx queue to be filled in with the next SMS before submitting the first one to use +CMMS=1 modem option. --- src/sms.c |4 +++-

[PATCH] sim: return from CPIN when SIM unlocked for telit

2012-08-22 Thread Christopher Vogl
Only return from CPIN when the modem informs that the SIM is unlocked. --- drivers/atmodem/sim.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index d480185..cf3345c 100644 ---

[PATCH] telit: sim status notification without polling

2012-08-22 Thread Christopher Vogl
Use AT#QSS=2 instead of AT#QSS=1 to get an URC when the SIM is not only inserted but also when PIN is unlocked and when SMS + phonebook are ready to be used. Disable sim state notification in telit_enable() so that we sure get a notification when we enable it later again. This way we don't have

[PATCH 1/8] ussd: Recover idle state in case of response sending failure

2012-08-22 Thread Philippe Nunes
GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ussd.c b/src/ussd.c index 74888b2..0ad4f61 100644

[PATCH 2/8] stkagent: '+' is considered as a digit

2012-08-22 Thread Philippe Nunes
The function 'valid_phone_number_format' does not comply with GCF test cases expectation. For STK, the character '+' should be considered as a whole digit. --- src/stkagent.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/src/stkagent.c

[PATCH 3/8] call-forwarding: return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as a CF query is not necessarily done after a CF setting via SS. --- src/call-forwarding.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 5acbd67..91e34c6 100644 --- a/src/call-forwarding.c +++

[PATCH 4/8] call-forwarding: class applied is the class given by SS code

2012-08-22 Thread Philippe Nunes
GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied when no class is specified in the SS code. --- src/call-forwarding.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/call-forwarding.c

[PATCH 5/8] call-barring: Return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as a CB query is not necessarily done after a CB setting via SS. --- src/call-barring.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 53847fb..68533c2 100644 --- a/src/call-barring.c +++

[PATCH 6/8] call-barring: class applied is the class given by SS code

2012-08-22 Thread Philippe Nunes
The default class is applied when no class is specified in the SS code. --- src/call-barring.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 68533c2..a372792 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@

[PATCH 7/8] call-settings: Return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as clir query is not necessarily done after a clir setting via SS. --- src/call-settings.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 4bfb561..51f96bf 100644 --- a/src/call-settings.c +++

[PATCH 8/8] call-settings: class applied is the class given by SS code.

2012-08-22 Thread Philippe Nunes
The default class is applied when no class is specified by SS code. --- src/call-settings.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 51f96bf..d63d9d8 100644 --- a/src/call-settings.c +++ b/src/call-settings.c

Re: [PATCH 2/8] stkagent: '+' is considered as a digit

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: The function 'valid_phone_number_format' does not comply with GCF test cases expectation. For STK, the character '+' should be considered as a whole digit. --- src/stkagent.c | 26 -- 1 file changed, 24

Re: [PATCH] sms: Add delay before submitting multiple SMS to modem

2012-08-22 Thread Denis Kenzior
Hi Guillaume, On 08/22/2012 04:29 AM, Guillaume Zajac wrote: For 3GPP GSM test case 34.2.9.1 and 34.2.9.1 and WCDMA test case 16.1.9.1 and 16.1.9.2, we need to transmitmultiple SMS using same RRC channel. oFono needs to wait its tx queue to be filled in with the next SMS before submitting the

Re: [PATCH 1/8] ussd: Recover idle state in case of response sending failure

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [PATCH 3/8] call-forwarding: return specific errors for SS query

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: Trace is modified as a CF query is not necessarily done after a CF setting via SS. --- src/call-forwarding.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 5/8] call-barring: Return specific errors for SS query

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: Trace is modified as a CB query is not necessarily done after a CB setting via SS. --- src/call-barring.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 7/8] call-settings: Return specific errors for SS query

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: Trace is modified as clir query is not necessarily done after a clir setting via SS. --- src/call-settings.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 4/8] call-forwarding: class applied is the class given by SS code

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied when no class is specified in the SS code. --- src/call-forwarding.c | 22 +++--- 1 file changed, 11

Re: [PATCH 8/8] call-settings: class applied is the class given by SS code.

2012-08-22 Thread Denis Kenzior
Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: The default class is applied when no class is specified by SS code. --- src/call-settings.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index

Re: [PATCH] sim: return from CPIN when SIM unlocked for telit

2012-08-22 Thread Denis Kenzior
Hi Christopher, On 08/22/2012 09:24 AM, Christopher Vogl wrote: Only return from CPIN when the modem informs that the SIM is unlocked. --- drivers/atmodem/sim.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) Patch has been applied,