Re: [PATCH] sms: Add delay before submitting multiple SMS to modem

2012-08-24 Thread Guillaume Zajac
Hi Denis, On 23/08/2012 19:33, Denis Kenzior wrote: Hi Guillaume, On 08/23/2012 09:26 AM, Guillaume Zajac wrote: Hi Denis, On 23/08/2012 15:48, Denis Kenzior wrote: Hi Guillaume, snip Unfortunately I come to the conclusion that if I want to send one same SMS to 3/4/5/... recipients with

[PATCH 0/3] Add STK APDU editor

2012-08-24 Thread Nicolas Bertrand
Add to phonesim the capability to symply send STK APDU Nicolas Bertrand (3): phonesim: accept STK command without application controlbase_ui: Add manual stk command editor control: Link functionnality to STK command editor src/control.cpp| 12 src/control.h |2

[PATCH 2/3] controlbase_ui: Add manual stk command editor

2012-08-24 Thread Nicolas Bertrand
--- src/controlbase.ui | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/controlbase.ui b/src/controlbase.ui index 4eb1355..e230d7c 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -1161,6 +1161,52 @@ /widget

[PATCH 3/3] control: Link functionnality to STK command editor

2012-08-24 Thread Nicolas Bertrand
--- src/control.cpp | 12 src/control.h |2 ++ 2 files changed, 14 insertions(+) diff --git a/src/control.cpp b/src/control.cpp index 3f1dd45..f518201 100644 --- a/src/control.cpp +++ b/src/control.cpp @@ -91,6 +91,8 @@ ControlWidget::ControlWidget(const QString ruleFile,

Re: [PATCH v2] ussd: Recover idle state in case of response sending failure

2012-08-24 Thread Philippe Nunes
On 08/23/2012 08:03 PM, Denis Kenzior wrote: Hi Philippe, On 08/23/2012 11:27 AM, Philippe Nunes wrote: GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c | 12 1 file

[RFC] Multi-recipient SMS implementation proposals

2012-08-24 Thread Guillaume Zajac
Hi all, Mutli-recipient SMS implementation is needed to pass GCF test cases 34.2.9.1 and 34.2.9.2 for GSM; 16.1.9.1 and 16.1.9.2 for WCDMA. A new task should be added to oFono TODO and as requested by Denis we have to discuss first the proposals. I have in mind 2 solutions: 1- Add a new API

[PATCH] gdbus: Fix crash error when calling g_dbus_remove_all_watches

2012-08-24 Thread Tomasz Bursztyka
--- Hi, While using gdbus on some other code, I found out that bug around g_dbus_remove_all_watches() usage. Tomasz gdbus/watch.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gdbus/watch.c b/gdbus/watch.c index d749176..968a38a 100644 --- a/gdbus/watch.c +++

Re: [PATCH] telit: sim status notification without polling

2012-08-24 Thread Christopher Vogl
Hi Denis, On 23/08/12 19:37, Denis Kenzior wrote: Hi Christopher, Also, one other thing I'm concerned about is the CFUN=4 usage when we try to set the modem offline. Your comments indicate that the Telit modem resets the SIM when we issue CFUN=4. Going from Online True - False we don't

[RFC v1] gatchat: Print error message if opening tun failes

2012-08-24 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de This is a very common misstake. Let's help the users to configure their system correctly. --- Hi, I was not able to find out why the check in at_grps_context_prope() does not hit when the tun module is not loaded. Therefore, this on gets only an RFC

[PATCH] mmsd: (resending) Add list-services script

2012-08-24 Thread Ronald Tessier
Add list-services script. This script lists all services with their properties. Ronald Tessier (1): test: Add test script to list services properties test/list-services | 27 +++ 1 file changed, 27 insertions(+) create mode 100755 test/list-services -- 1.7.9.5

[PATCH] test: Add test script to list services properties

2012-08-24 Thread Ronald Tessier
--- test/list-services | 27 +++ 1 file changed, 27 insertions(+) create mode 100755 test/list-services diff --git a/test/list-services b/test/list-services new file mode 100755 index 000..bd52d71 --- /dev/null +++ b/test/list-services @@ -0,0 +1,27 @@

[PATCH 00/12] mmsd: (resending) Support Delivery Report notification

2012-08-24 Thread Ronald Tessier
These patches concern mmsd and add delivery report notification support. Add MMS M-Delivery.ind PDU decoding support. Update meta file of the sent message to store the received msg_id and to add a group [delivery_status] if delivery_report is requested. Upon MMS M-Delivery.ind PDU reception,

[PATCH 03/12] service: Store msg_id provided by M-Send.conf PDU

2012-08-24 Thread Ronald Tessier
--- src/service.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index db9c514..b073ca9 100644 --- a/src/service.c +++ b/src/service.c @@ -629,7 +629,7 @@ static gboolean result_request_send_conf(struct mms_request *request)

[PATCH 02/12] mmsutil: Decode delivery_ind msg

2012-08-24 Thread Ronald Tessier
--- src/mmsutil.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mmsutil.c b/src/mmsutil.c index a9a12eb..7042276 100644 --- a/src/mmsutil.c +++ b/src/mmsutil.c @@ -964,6 +964,24 @@ static gboolean decode_send_req(struct wsp_header_iter *iter,

[PATCH 05/12] service: Add a group [delivery_status] in the msg status

2012-08-24 Thread Ronald Tessier
This group contains an entry for each message recipients. Each recipient entry will be updated when the corresponding report will be received and then remove the temporary stored delivery report. --- src/service.c | 33 + 1 file changed, 33 insertions(+) diff

[PATCH 06/12] service: Support M-Delivery.ind in mms_service_push_notify()

2012-08-24 Thread Ronald Tessier
--- src/service.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/service.c b/src/service.c index ec1b1b9..8087477 100644 --- a/src/service.c +++ b/src/service.c @@ -2325,6 +2325,21 @@ static void process_request_queue(struct mms_service *service)

[PATCH 07/12] service: Support delivery_ind notif on start

2012-08-24 Thread Ronald Tessier
--- src/service.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/service.c b/src/service.c index 8087477..b3ecc1e 100644 --- a/src/service.c +++ b/src/service.c @@ -1357,7 +1357,8 @@ static gboolean load_message_from_store(const char *service_id, else if

[PATCH 04/12] service: Move mms_address_to_string() up

2012-08-24 Thread Ronald Tessier
--- src/service.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/service.c b/src/service.c index b073ca9..c3dc40a 100644 --- a/src/service.c +++ b/src/service.c @@ -354,6 +354,19 @@ static gboolean mmap_file(const char *path, void

[PATCH 09/12] service: Process delivery_ind notification

2012-08-24 Thread Ronald Tessier
--- src/service.c | 111 ++--- 1 file changed, 107 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index b3ecc1e..44184cb 100644 --- a/src/service.c +++ b/src/service.c @@ -1300,6 +1300,104 @@ static void

[PATCH 08/12] store: Define MMS_META_UUID_XXX len and suffix

2012-08-24 Thread Ronald Tessier
--- src/store.c |8 +++- src/store.h |5 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/store.c b/src/store.c index b09c17b..f1c5714 100644 --- a/src/store.c +++ b/src/store.c @@ -42,8 +42,6 @@ #define TFR #endif -#define MMS_SHA1_UUID_LEN 20 - static

[PATCH 11/12] test: Add ReportChanged to monitored signals

2012-08-24 Thread Ronald Tessier
--- test/monitor-mms | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/monitor-mms b/test/monitor-mms index 188d028..ef17a13 100755 --- a/test/monitor-mms +++ b/test/monitor-mms @@ -29,6 +29,10 @@ def property_changed(name, value, member, path, interface): iface =

[PATCH 10/12] service: Send a delivery changed signal

2012-08-24 Thread Ronald Tessier
--- src/service.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 44184cb..ba23b4a 100644 --- a/src/service.c +++ b/src/service.c @@ -218,6 +218,40 @@ static void

[PATCH 0/4] Immediate digit response

2012-08-24 Thread Philippe Nunes
For GET-INPUT proactive command, the command qualifier can require to send the response immediately after the user has entered a digit. In this mode, the entered digit shall not be displayed and the character '+' is not allowed for user input. Philippe Nunes (4): stk: check if immediate digit

[PATCH 2/4] stkagent: Add argument to notify when immediate digit response is required

2012-08-24 Thread Philippe Nunes
--- src/stkagent.c |6 -- src/stkagent.h |5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/stkagent.c b/src/stkagent.c index 7c3f697..ed5d28a 100644 --- a/src/stkagent.c +++ b/src/stkagent.c @@ -554,8 +554,9 @@ static void get_digit_cb(DBusPendingCall *call,

[PATCH 3/4] doc: Update STK API regarding the new argument immediate_response

2012-08-24 Thread Philippe Nunes
--- doc/stk-api.txt | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 471e5d6..0d96246 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -170,8 +170,9 @@ Methods byte RequestSelection(string title, byte

[PATCH 1/4] stk: check if immediate digit response is requested

2012-08-24 Thread Philippe Nunes
--- src/stk.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index 7a7bd75..3883d11 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1519,6 +1519,7 @@ static gboolean handle_command_get_inkey(const struct stk_command *cmd, gboolean alphabet =

[PATCH 4/4] test: Print the immediate_response argument for RequestDigit

2012-08-24 Thread Philippe Nunes
--- test/test-stk-menu |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test-stk-menu b/test/test-stk-menu index a9f92e8..3bd4483 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -113,10 +113,11 @@ class StkAgent(dbus.service.Object):

[PATCH] phonesim: Add GET_INPUT test case

2012-08-24 Thread Philippe Nunes
This test case is used to check the immediate digit response flag. --- src/conformancesimapplication.cpp | 25 - src/qsimcommand.cpp | 32 src/qsimcommand.h |3 +++ 3 files changed, 55 insertions(+), 5

Re: [PATCH] phonesim: Add GET_INPUT test case

2012-08-24 Thread Denis Kenzior
Hi Philippe, On 08/24/2012 09:35 AM, Philippe Nunes wrote: This test case is used to check the immediate digit response flag. --- src/conformancesimapplication.cpp | 25 - src/qsimcommand.cpp | 32 src/qsimcommand.h

Re: [PATCH 3/4] doc: Update STK API regarding the new argument immediate_response

2012-08-24 Thread Denis Kenzior
Hi Philippe, On 08/24/2012 09:28 AM, Philippe Nunes wrote: --- doc/stk-api.txt | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 471e5d6..0d96246 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -170,8 +170,9 @@

Re: [PATCH 0/4] Immediate digit response

2012-08-24 Thread Denis Kenzior
Hi Philippe, On 08/24/2012 09:28 AM, Philippe Nunes wrote: For GET-INPUT proactive command, the command qualifier can require to send the response immediately after the user has entered a digit. In this mode, the entered digit shall not be displayed and the character '+' is not allowed for user

Re: [PATCH] test: Add test script to list services properties

2012-08-24 Thread Denis Kenzior
Hi Ronald, On 08/24/2012 07:58 AM, Ronald Tessier wrote: --- test/list-services | 27 +++ 1 file changed, 27 insertions(+) create mode 100755 test/list-services Patch has been applied, thanks. Regards, -Denis ___

Re: [RFC] Multi-recipient SMS implementation proposals

2012-08-24 Thread Marcel Holtmann
Hi Guillaume, snip 2-Modify existing SendMessage API in adding a new mms argument: GDBUS_ASYNC_METHOD(SendMessage, GDBUS_ARGS({ to, s }, { text, s }, { mms, i }), GDBUS_ARGS({ path, o }), sms_send_message) oFono 1.x has a stable API. Why are you proposing to